Repository navigation
[access] refactor(object): conflict readings and unique hints take fewer parameters - #7575
Conversation
…eters ConflictReport::readingsFor takes the readings it guards instead of the sent and read values; the read check stays first and still withholds the values of a property the caller may not read. UniqueHintChecker::check takes a UniqueHintScope (register and schema references, untyped as before) instead of two loose references; the scope builds the per-property lookup. Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check does not come from this PR. The PHPUnit step inside the Nextcloud container fails with 11 errors and 11 failures. None of them are in files this diff touches. The failing tests are:
The same set fails on unrelated open PRs #7541, #7543, #7538 and #7540. Outside the container these tests pass on plain The tests this PR changes pass in the same run: ConflictReport, the UniqueHintChecker tests including the access golden, and the SaveObject save-call and update-path tests. Generated by Claude Code |
|
The two red frontend checks on this PR come from
This PR changes only No fix exists yet. They need an eslint cleanup and translations of those two keys in every locale (docs/l10n-workflow.md §6.15), which belong in their own PRs. Generated by Claude Code |
|
The red
No fix exists yet. A repo-wide Generated by Claude Code |
|
The red phpcs reports 11 errors, all in files this PR does not change:
These errors are already on No fix exists yet, and those files belong to other lanes, so the fix is outside this PR. Generated by Claude Code |
|
The red phpstan reports 24 errors in 12 files, and this PR changes none of them:
The errors are mostly calls to methods missing from the narrowed interfaces ( No fix exists yet. The fixes belong to the lanes that own those files, not to this PR. Generated by Claude Code |
|
Psalm reports 60 errors across 35 files under
These errors are already on No fix exists yet. These files belong to other lanes, so the fixes do not belong in this PR. Generated by Claude Code |
|
The red The gate reports 14 translation keys used in The fix is a separate Generated by Claude Code |
|
The red PHPMD reports 616 findings across No fix exists yet, and it does not belong in this PR. Generated by Claude Code |
|
The red Seven whole-tree gates fail, with the same counts as on the unrelated open PR #7541 and on #7540:
The diff-scoped gates pass. This PR changes no controller, so gates 7, 17 and 49 cannot have picked up anything from it. Gates 12 and 40 check Vue files, which this PR does not touch. The one new No fix exists yet. These are gate debts already on Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49041/49051 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:18 UTC
Download the full PDF report from the workflow artifacts.
Lane K17 (round 10c), SIG unit interfacing.
What changed
ConflictReport::readingsFor(5 → 4 params): takes the conflict readings it guards (built by a new staticreadings(sent, read, stored)) instead of the sent and read values. ThecanReadPropertycheck still runs first, and a property the caller may not read still answers only{status: withheld}.UniqueHintChecker::check(5 → 4 params): takes a newUniqueHintScope(register and schema references,mixedas before, so nothing is coerced) instead of two loose references. The scope builds the per-propertyUniqueHintLookup. The only caller isSaveObject, at its two call sites (create and update).Tests
ConflictReportTestcovers allowed and withheld properties, andUniqueHintCheckerAccessGoldenTestcovers visible, hidden and self-excluded holders. Both pass unchanged apart from building the scope.canReadPropertybranch fails 3 ConflictReport tests, and swapping register and schema in the scope fails the Quality suite.Numbers (lane_measure K17, this branch alone)
AI-assisted: written by Claude Code (Claude) for lane K17.
Generated by Claude Code