Repository navigation
refactor(objects): share Files helpers and the relation row of ObjectDetails - #7541
Conversation
openFolder, openFile and formatFileSize move from ObjectDetails and UploadFiles into src/composables/nextcloudFiles.js, listed in each component's methods so the templates call them unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
A named import that matches a method name becomes a setup binding in an SFC that also has <script setup>, shadowing the method in the dev/test template build; the namespace import keeps openFolder an options binding. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
The two tabs carried the same NcListItem with cube icon and relation label; ObjectRelationItem renders it once. The relations DOM golden passes unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite failing: not this PR's. The same check (and Generated by Claude Code |
|
Parity fails on the key "We could not count the objects. Close this window and try again.", which is missing from the locale catalogues. The check is equally red on development's head These checks are still running here and are already red on that base: Generated by Claude Code |
|
The format job is red on development too, but two of the files it flags were added by this PR: The fix is Generated by Claude Code |
|
Hydra reports 8 failed gates here. Seven also fail on development's head The fix is Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49035/49045 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 15:19 UTC
Download the full PDF report from the workflow artifacts.
What changed
src/composables/nextcloudFiles.js:openFolder,openFile,formatFileSize— the Nextcloud Files links and size formatting ObjectDetails carried (and UploadFiles carriedopenFolderof), byte-identical bodies. Each component lists them inmethodsfrom a namespace import (import * as nextcloudFiles), so the templates call them unchanged. The namespace import matters in UploadFiles: in an SFC that also has<script setup>, a named import with the method's name becomes a setup binding and shadows the method in the dev/test template build (checked withcompileScript:openFolderstays anoptionsbinding).src/views/object/ObjectRelationItem.vue: the NcListItem row (cube icon, title, relation label) the Uses and Used by tabs both inlined. Root element is the same NcListItem with the same props, so the DOM is unchanged.Tests first:
ObjectDetails.relations.dom.golden.spec.jsrecords the Uses / Used by markup (rows with titles and labels, and the empty state) on the old markup, committed before the change; it passes unchanged after it.What ran
npx jest src/views/object src/modals/file: all passed, snapshots unchanged.npm run build: succeeds.Numbers (lane_measure.py, K35 vue_red)
This PR alone on development: 319 → 286. With #7493 and #7498 and the upload PR merged together: see lane report.
AI-assisted: written by Claude Code (claude-opus-5-5) in cloud lane K35.
Generated by Claude Code