Repository navigation
[access] test(backgroundjob): cover transfer, sync, log clean-up, state history and review reminder job gaps - #7560
Conversation
…y and review reminder job gaps Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check is not caused by this PR. It fails at the step "PHPUnit unit suite (in-container, HARD GATE)". That step currently fails on every PR, including the JS-only #7510.
The 26 extra tests are exactly the ones this PR adds, and they all pass. The failing tests are Generated by Claude Code |
|
This PR only adds PHP test files, so the red quality / … checks come from
The evidence is in #7519. Each check needs its own fix on Generated by Claude Code |
|
This adds to my earlier comment. Three more checks also fail for reasons outside this PR:
This PR changes only Generated by Claude Code |
|
If the quality / Frontend Tests (unit) check (the jest suite) is red, this PR is not the cause. The PR only adds PHPUnit files under Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:24 UTC
Download the full PDF report from the workflow artifacts.
SIG coverage round t1, lane T04: PHP unit tests for the transfer and maintenance background jobs. The
[access]prefix is there because transfers and log clean-up touch archival and retention.Covered
This PR adds new test files only. It changes no production code and adds no coverage metadata.
The tests close these gaps:
sinceis derived.The jitter in
TransferExecutionJob::backoffSecondscomes fromrandom_int, so the tests only assert that the scheduled time falls after a frozen "now".Ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/tj.xml --filter '<new + existing tests for these six jobs>' tests/Unit/BackgroundJobran 83 tests with 404 assertions and no failures. 10 tests are risky, all in the existing Golden tests; none of the new files is risky. Because this was a subset run, the coverage above is a lower bound.weak.phpover tests/Unit/BackgroundJob reports none of the new files.Mutation samples (each reverted)
< 1->< 0-> 1 test failed!== ''->=== ''-> 1 test failed=== ''->=== 'x'-> 1 test failedempty($eligibleObjects) === true->false-> 1 test failed!== null->=== null-> 2 tests failed<= 0->< 0-> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code