explicitly check for fresh vars in canonicalize by lcnr · Pull Request #163874 · rust-lang/rust

lcnr · 2026-10-06T09:28:16Z

otherwise we don't detect the bug in #148632 with the new solver.

r? types

lcnr · 2026-10-06T09:28:40Z

i am pretty sure this shouldn't affect perf, checking type flags should be O(1) after all

explicitly check for fresh vars in canonicalize

rust-bors · 2026-10-06T10:28:15Z

☀️ Try build successful (CI)
Build commit: ef793ff (ef793ff0c26fe462a1675c884f89d90f7b8f38d4)
Base parent: b57eb9a (b57eb9a5fd94f30697f51fc88fbe898e67c7aae6)

rust-timer · 2026-10-06T13:05:03Z

Finished benchmarking commit (ef793ff): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.7%, 2.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-3.8%, -2.1%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.7%	[-14.1%, -1.9%]	9
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	20
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	5
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	20

Bootstrap: 489.693s -> 490.853s (0.24%)
Artifact size: 409.33 MiB -> 408.57 MiB (-0.19%)

lcnr · 2026-10-06T13:09:49Z

cool

oli-obk

@bors r+ rollup

View changes since this review

rust-bors · 2026-10-06T13:38:18Z

📌 Commit 9ce47de has been approved by oli-obk

It is now in the queue for this repository.

explicitly check for fresh vars in canonicalize otherwise we don't detect the bug in rust-lang#148632 with the new solver. r? types

…uwer Rollup of 17 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)

explicitly check for fresh vars in canonicalize otherwise we don't detect the bug in rust-lang#148632 with the new solver. r? types

…uwer Rollup of 16 pull requests Successful merges: - #163887 (Remove `NonOwner` variant from `AstOwner`) - #163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` ) - #162156 (add IBM f128 type) - #163925 (Submodule update of rustc-perf) - #163658 ([PAC] Stop hard coding key and discriminator, consult schema instead) - #163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell) - #163893 (Panic on `StableHash` of a `Path` with `GenericArgs`) - #163894 (revisions for TAIT in env bug) - #163902 (Clean up Reference annotations that drifted) - #163905 (Remove redundant closure in bootstrap) - #163921 (abby DSL: implement ambiguity) - #163927 (abby DSL: change `where` syntax to `predicates`) - #163933 (Add `synchronization` import lib to windows-gnullvm dist) - #163937 (Abby test DSL: dont ICE on foralls with unused bound vars) > [!WARNING] > This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.

Rollup merge of #163874 - lcnr:ice-on-fresh-vars, r=oli-obk explicitly check for fresh vars in canonicalize otherwise we don't detect the bug in #148632 with the new solver. r? types

…uwer Rollup of 16 pull requests Successful merges: - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`) - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` ) - rust-lang/rust#162156 (add IBM f128 type) - rust-lang/rust#163925 (Submodule update of rustc-perf) - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead) - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN) - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize) - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell) - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`) - rust-lang/rust#163894 (revisions for TAIT in env bug) - rust-lang/rust#163902 (Clean up Reference annotations that drifted) - rust-lang/rust#163905 (Remove redundant closure in bootstrap) - rust-lang/rust#163921 (abby DSL: implement ambiguity) - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`) - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist) - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars) > [!WARNING] > This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.

explicitly check for fresh vars in canonicalize

9ce47de

rustbot assigned oli-obk Oct 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 6, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 6, 2026

rust-bors Bot pushed a commit that referenced this pull request Oct 6, 2026

Auto merge of #163874 - lcnr:ice-on-fresh-vars, r=<try>

ef793ff

explicitly check for fresh vars in canonicalize

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 6, 2026

oli-obk approved these changes Oct 6, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 17 pull requests #163884

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 12 pull requests #163929

Closed

This was referenced Oct 7, 2026

Rollup of 14 pull requests #163943

Closed

Rollup of 16 pull requests #163945

Merged

rust-bors Bot merged commit f40e841 into rust-lang:main Oct 7, 2026
15 checks passed

rustbot added this to the 1.101.0 milestone Oct 7, 2026

This was referenced Oct 8, 2026

Stabilize the next-generation trait solver rust-lang/goals#113

Open

[ICE]: unexpected self type for 'Goal' #159102

Closed

Navigation Menu

Repository navigation

explicitly check for fresh vars in canonicalize - #163874

explicitly check for fresh vars in canonicalize#163874
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:ice-on-fresh-vars

lcnr commented Oct 6, 2026 •

edited by rustbot

Loading

Uh oh!

lcnr commented Oct 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Oct 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Oct 6, 2026

Uh oh!

lcnr commented Oct 6, 2026

Uh oh!

oli-obk left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lcnr commented Oct 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lcnr commented Oct 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Oct 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Oct 6, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lcnr commented Oct 6, 2026

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lcnr commented Oct 6, 2026 •

edited by rustbot

Loading

oli-obk left a comment •

edited by rustbot

Loading