Skip to content

Clean up Reference annotations that drifted - #163902

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
traviscross:TC/add-reference-annotations_cleanup-drift
Oct 7, 2026
Merged

Clean up Reference annotations that drifted#163902
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
traviscross:TC/add-reference-annotations_cleanup-drift

Conversation

@traviscross

@traviscross traviscross commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The Reference warns when a //@ reference: annotation points to a rule that isn't in the Reference. Some of these had accumulated. Let's clean them up.

r? @PLeVasseur

cc @DanielEScherzer

(As work within the scope of the lang-docs team, this falls outside the scope of the forge#1040 policy; nonetheless, I'll note that this work was done with the assistance of AI tools and that this has been prearranged with all reviewers.)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 6, 2026
@rustbot

This comment was marked as resolved.

Sign in to view
@traviscross
Clean up Reference annotations that drifted
879c65a 
The Reference warns when a `//@ reference:` annotation points to a
rule that isn't in the Reference.  Some of these had accumulated.
Let's clean them up.
@traviscross
traviscross force-pushed the TC/add-reference-annotations_cleanup-drift branch from e1bf4fe to 879c65a Compare October 7, 2026 01:39
@traviscross traviscross self-assigned this Oct 7, 2026
@traviscross traviscross added T-lang-docs Relevant to the lang-docs team. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2026
PLeVasseur
PLeVasseur reviewed Oct 7, 2026
View reviewed changes

@PLeVasseur PLeVasseur left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traviscross. This looks good.

I had a thought on something we could improve while we're here or on another PR.

View changes since this review

Comment thread tests/ui/layout/aggregate-lang/struct-align.rs
@traviscross
traviscross marked this pull request as ready for review October 7, 2026 06:23
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2026
@rustbot

rustbot commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in coverage tests.

cc @Zalathar

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 7, 2026
@traviscross

traviscross commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=PLeVasseur,traviscross rollup

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 879c65a has been approved by PLeVasseur,traviscross

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026
@Kobzol

Kobzol commented Oct 7, 2026

Copy link
Copy Markdown
Member

Can we gate CI on these being correct? It seems unfortunate that having the links be wrong causes only warnings.

@traviscross

traviscross commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Can we gate CI on these being correct? It seems unfortunate that having the links be wrong causes only warnings.

Agreed it's unfortunate, but I don't know how we could gate CI at the moment. These identifiers change on the Reference side. We wouldn't want people to need to fix the tests in unrelated Rust PRs to get those PRs to merge.

@Kobzol

Kobzol commented Oct 7, 2026

Copy link
Copy Markdown
Member

The way we do that with other subtrees/submodules is that the discrepancies get fixed in sync PRs. So the person doing a sync from the reference repo into rust-lang/rust would have to fix them up, rust-lang/rust contributors shouldn't really be affected. It wouldn't be that different from what you did in this PR, it's just that CI would catch these breakages during synces, which might also hopefully cause them to be resolved in a more fine-grained manner (fixes happening more fixes = less fixes to do in each sync).

@traviscross

traviscross commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Thanks; makes sense. Will think about that. Our syncs are fairly automated (which we rely on in various ways), so that could be one hurdle.

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163902 - traviscross:TC/add-reference-annot…
83ff72a 
…ations_cleanup-drift, r=PLeVasseur,traviscross

Clean up Reference annotations that drifted

The Reference warns when a `//@ reference:` annotation points to a rule that isn't in the Reference.  Some of these had accumulated. Let's clean them up.

r? @PLeVasseur

cc @DanielEScherzer

(As work within the scope of the lang-docs team, this falls outside the scope of the `forge#1040` policy; nonetheless, I'll note that this work was done with the assistance of AI tools and that this has been prearranged with all reviewers.)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163902 - traviscross:TC/add-reference-annot…
5809dd8 
…ations_cleanup-drift, r=PLeVasseur,traviscross

Clean up Reference annotations that drifted

The Reference warns when a `//@ reference:` annotation points to a rule that isn't in the Reference.  Some of these had accumulated. Let's clean them up.

r? @PLeVasseur

cc @DanielEScherzer

(As work within the scope of the lang-docs team, this falls outside the scope of the `forge#1040` policy; nonetheless, I'll note that this work was done with the assistance of AI tools and that this has been prearranged with all reviewers.)
This was referenced Oct 7, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
1d81eb4 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #163887 (Remove `NonOwner` variant from `AstOwner`)
 - #163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - #162156 (add IBM f128 type)
 - #163925 (Submodule update of rustc-perf)
 - #163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - #163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - #163874 (explicitly check for fresh vars in canonicalize)
 - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - #163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - #163894 (revisions for TAIT in env bug)
 - #163902 (Clean up Reference annotations that drifted)
 - #163905 (Remove redundant closure in bootstrap)
 - #163921 (abby DSL: implement ambiguity)
 - #163927 (abby DSL: change `where` syntax to `predicates`)
 - #163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - #163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
@rust-bors
rust-bors Bot merged commit 081b1fa into rust-lang:main Oct 7, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Unrolled build for #163902 in rollup 163945
0cd5c89 
Rollup merge of #163902 - traviscross:TC/add-reference-annotations_cleanup-drift, r=PLeVasseur,traviscross

Clean up Reference annotations that drifted

The Reference warns when a `//@ reference:` annotation points to a rule that isn't in the Reference.  Some of these had accumulated. Let's clean them up.

r? @PLeVasseur

cc @DanielEScherzer

(As work within the scope of the lang-docs team, this falls outside the scope of the `forge#1040` policy; nonetheless, I'll note that this work was done with the assistance of AI tools and that this has been prearranged with all reviewers.)
github-actions Bot pushed a commit to rust-lang/stdarch that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
4a6bf8e 
…uwer

Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`)
 - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - rust-lang/rust#162156 (add IBM f128 type)
 - rust-lang/rust#163925 (Submodule update of rustc-perf)
 - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize)
 - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - rust-lang/rust#163894 (revisions for TAIT in env bug)
 - rust-lang/rust#163902 (Clean up Reference annotations that drifted)
 - rust-lang/rust#163905 (Remove redundant closure in bootstrap)
 - rust-lang/rust#163921 (abby DSL: implement ambiguity)
 - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`)
 - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
8002d19 
…uwer

Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`)
 - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - rust-lang/rust#162156 (add IBM f128 type)
 - rust-lang/rust#163925 (Submodule update of rustc-perf)
 - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize)
 - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - rust-lang/rust#163894 (revisions for TAIT in env bug)
 - rust-lang/rust#163902 (Clean up Reference annotations that drifted)
 - rust-lang/rust#163905 (Remove redundant closure in bootstrap)
 - rust-lang/rust#163921 (abby DSL: implement ambiguity)
 - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`)
 - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Oct 9, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
69596b6 
…uwer

Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`)
 - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - rust-lang/rust#162156 (add IBM f128 type)
 - rust-lang/rust#163925 (Submodule update of rustc-perf)
 - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize)
 - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - rust-lang/rust#163894 (revisions for TAIT in env bug)
 - rust-lang/rust#163902 (Clean up Reference annotations that drifted)
 - rust-lang/rust#163905 (Remove redundant closure in bootstrap)
 - rust-lang/rust#163921 (abby DSL: implement ambiguity)
 - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`)
 - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@PLeVasseur PLeVasseur PLeVasseur left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@traviscross traviscross

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang-docs Relevant to the lang-docs team.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@traviscross @rustbot @Kobzol @PLeVasseur