Add if-installed:auto:spellcheck to pre-push script by bb1yd · Pull Request #163870 · rust-lang/rust

bb1yd · 2026-10-06T08:39:35Z

rustbot · 2026-10-06T08:39:41Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

lqd · 2026-10-06T08:51:14Z

That would require everyone to have the spellchecker installed locally which is also a tradeoff vs only seeing these issues on CI 🤔 .

bb1yd · 2026-10-06T08:57:38Z

I personally feel that this is acceptable.

This helps the contributor to find out typos sooner and saves CI resources. I assume that the size of the spellchecker is small and isn't a problem for most computers.

Kobzol · 2026-10-06T09:21:12Z

The difference between the JS/Python lints is that most people don't ever modify those, and the auto modified will thus ensure that we don't run the linter. But spellcheck is different, because it runs on most important source files in the repo.

Let's use if-installed:auto:spellcheck as a compromise. That will only run the linter if you already have the correct version of the typos tool installed.

bb1yd · 2026-10-06T09:39:41Z

sure

Kobzol · 2026-10-06T10:09:19Z

Thanks!

@bors r+ rollup

rust-bors · 2026-10-06T10:09:22Z

📌 Commit 2553cca has been tentatively approved by Kobzol

It will be put into the queue for this repository once PR CI succeeds.

@Kobzol

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

…uwer Rollup of 13 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@Kobzol

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

…uwer Rollup of 17 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)

@Kobzol

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

…uwer Rollup of 25 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #162156 (add IBM f128 type) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@Kobzol

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

…uwer Rollup of 24 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

…uwer Rollup of 23 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@Kobzol

Rollup merge of #163870 - bb1yd:enable-auto-spellcheck, r=Kobzol Add if-installed:auto:spellcheck to pre-push script Fixes #163815 r? @Kobzol

rust-timer · 2026-10-08T10:30:22Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (d709ed9): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.1%]	4
Improvements ✅ (secondary)	-0.3%	[-0.6%, -0.1%]	16
All ❌✅ (primary)	-0.1%	[-0.3%, -0.1%]	4

Max RSS (memory usage)

Results (primary -0.9%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Cycles

Results (secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Artifact size: 408.59 MiB -> 409.32 MiB (0.18%)

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - rust-lang/rust#163806 (even more `tests/crashes` migration for `-Znext-solver`) - rust-lang/rust#163508 (Document the `rustc_on_unimplemented` attribute.) - rust-lang/rust#163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - rust-lang/rust#163863 (use the type name instead of `Self` in constructor paths again) - rust-lang/rust#163864 (Remove CLAUDE.md) - rust-lang/rust#163877 (Add regression test for duplicated rustdoc search results between std and core) - rust-lang/rust#163916 (Shrink `PartialRes` and its alignment) - rust-lang/rust#149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - rust-lang/rust#152557 (Oneshot `is_ready`) - rust-lang/rust#157273 (Stabilize `optimize` attribute) - rust-lang/rust#162000 (peel_transparent_wrappers only works on non-1ZST) - rust-lang/rust#163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - rust-lang/rust#163348 (perf:cache FFI safety results in improper_ctypes lint) - rust-lang/rust#163768 (Move more `rustdoc-html` tests in the right location) - rust-lang/rust#163778 (check is_indirect_first_projection when replacing in RefProp) - rust-lang/rust#163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - rust-lang/rust#163807 (Add `has_reliable_f16b` for Arm) - rust-lang/rust#163809 (Switch TLS implementation for wasi and bump SDK version to 34) - rust-lang/rust#163826 (Update books) - rust-lang/rust#163849 (ci: update to PowerShell 7.6.6) - rust-lang/rust#163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - rust-lang/rust#163870 (Add if-installed:auto:spellcheck to pre-push script)

rustbot assigned Kobzol Oct 6, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 6, 2026

add if-installed:auto:spellcheck to pre-push script

2553cca

bb1yd force-pushed the enable-auto-spellcheck branch from ad1eaf9 to 2553cca Compare October 6, 2026 09:47

bb1yd changed the title ~~Add auto:spellcheck to pre-push script~~ Add if-installed:auto:spellcheck to pre-push script Oct 6, 2026

bb1yd marked this pull request as ready for review October 6, 2026 09:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 6, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 6, 2026

Rollup merge of rust-lang#163870 - bb1yd:enable-auto-spellcheck, r=Ko…

9242ed0

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 13 pull requests #163879

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 6, 2026

Rollup merge of rust-lang#163870 - bb1yd:enable-auto-spellcheck, r=Ko…

9778817

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 17 pull requests #163884

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026

Rollup merge of rust-lang#163870 - bb1yd:enable-auto-spellcheck, r=Ko…

a2b6d9f

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 25 pull requests #163919

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026

Rollup merge of rust-lang#163870 - bb1yd:enable-auto-spellcheck, r=Ko…

b48cef9

…bzol Add if-installed:auto:spellcheck to pre-push script Fixes rust-lang#163815 r? @Kobzol

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 24 pull requests #163934

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 23 pull requests #163957

Merged

rust-bors Bot merged commit 46e5d12 into rust-lang:main Oct 8, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 8, 2026

rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026

Unrolled build for #163870 in rollup 163957

d709ed9

Rollup merge of #163870 - bb1yd:enable-auto-spellcheck, r=Kobzol Add if-installed:auto:spellcheck to pre-push script Fixes #163815 r? @Kobzol

github-actions Bot mentioned this pull request Oct 9, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

Navigation Menu

Repository navigation

Add if-installed:auto:spellcheck to pre-push script - #163870

Add if-installed:auto:spellcheck to pre-push script#163870
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bb1yd:enable-auto-spellcheck

bb1yd commented Oct 6, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

lqd commented Oct 6, 2026

Uh oh!

bb1yd commented Oct 6, 2026 •

edited

Loading

Uh oh!

Kobzol commented Oct 6, 2026 •

edited

Loading

Uh oh!

bb1yd commented Oct 6, 2026

Uh oh!

Kobzol commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

bb1yd commented Oct 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

lqd commented Oct 6, 2026

Uh oh!

bb1yd commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bb1yd commented Oct 6, 2026

Uh oh!

Kobzol commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bb1yd commented Oct 6, 2026 •

edited by rustbot

Loading

bb1yd commented Oct 6, 2026 •

edited

Loading

Kobzol commented Oct 6, 2026 •

edited

Loading