use the type name instead of `Self` in constructor paths again by cyrgani · Pull Request #163863 · rust-lang/rust

cyrgani · 2026-10-06T07:41:38Z

Fixes #163800 by restoring Substructure.type_ident and using it instead of Self for constructor paths in Clone and Default's expansions.
r? @nnethercote

rustbot · 2026-10-06T07:41:41Z

Changes to the code generated for builtin derived traits.

cc @nnethercote

nnethercote · 2026-10-06T08:59:56Z

Thanks for doing this. Annoying how much code has to be put back. I give you a gold star for adding a test: ⭐

nnethercote · 2026-10-06T09:00:02Z

@bors r+

rust-bors · 2026-10-06T09:00:06Z

📌 Commit e1a95eb has been tentatively approved by nnethercote

It will be put into the queue for this repository once PR CI succeeds.

@nnethercote

…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

JonathanBrouwer · 2026-10-06T09:49:55Z

@bors try jobs=test-various

use the type name instead of `Self` in constructor paths again try-job: test-various

rust-bors · 2026-10-06T09:50:02Z

⌛ Trying commit e1a95eb with merge 02ed528…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/37445677251

@nnethercote

…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

@nnethercote

…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

…uwer Rollup of 13 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@nnethercote

…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

rust-bors · 2026-10-06T15:57:23Z

💥 Test timed out after 21600s

…uwer Rollup of 17 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)

@nnethercote

…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

…uwer Rollup of 25 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #162156 (add IBM f128 type) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@nnethercote

…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

…uwer Rollup of 24 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

…uwer Rollup of 23 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@nnethercote

Rollup merge of #163863 - cyrgani:annoying-attr-macros, r=nnethercote use the type name instead of `Self` in constructor paths again Fixes #163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote

rust-timer · 2026-10-08T10:04:23Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (8f3ba4b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.1%]	11
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.9%, 1.2%]	2

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	2
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	12
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	2

Artifact size: 408.59 MiB -> 408.67 MiB (0.02%)

rustbot · 2026-10-08T10:14:28Z

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

JonathanBrouwer · 2026-10-08T16:24:13Z

Perf is noise, all PRs in the rollup have the same results

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - rust-lang/rust#163806 (even more `tests/crashes` migration for `-Znext-solver`) - rust-lang/rust#163508 (Document the `rustc_on_unimplemented` attribute.) - rust-lang/rust#163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - rust-lang/rust#163863 (use the type name instead of `Self` in constructor paths again) - rust-lang/rust#163864 (Remove CLAUDE.md) - rust-lang/rust#163877 (Add regression test for duplicated rustdoc search results between std and core) - rust-lang/rust#163916 (Shrink `PartialRes` and its alignment) - rust-lang/rust#149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - rust-lang/rust#152557 (Oneshot `is_ready`) - rust-lang/rust#157273 (Stabilize `optimize` attribute) - rust-lang/rust#162000 (peel_transparent_wrappers only works on non-1ZST) - rust-lang/rust#163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - rust-lang/rust#163348 (perf:cache FFI safety results in improper_ctypes lint) - rust-lang/rust#163768 (Move more `rustdoc-html` tests in the right location) - rust-lang/rust#163778 (check is_indirect_first_projection when replacing in RefProp) - rust-lang/rust#163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - rust-lang/rust#163807 (Add `has_reliable_f16b` for Arm) - rust-lang/rust#163809 (Switch TLS implementation for wasi and bump SDK version to 34) - rust-lang/rust#163826 (Update books) - rust-lang/rust#163849 (ci: update to PowerShell 7.6.6) - rust-lang/rust#163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - rust-lang/rust#163870 (Add if-installed:auto:spellcheck to pre-push script)

use the type name instead of Self in constructor paths again

e1a95eb

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 6, 2026

rustbot assigned nnethercote Oct 6, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 6 pull requests #163873

Closed

rust-bors Bot pushed a commit that referenced this pull request Oct 6, 2026

Auto merge of #163863 - cyrgani:annoying-attr-macros, r=<try>

02ed528

use the type name instead of `Self` in constructor paths again try-job: test-various

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 8 pull requests #163876

Closed

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 13 pull requests #163879

Closed

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 17 pull requests #163884

Closed

theemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 6, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 6, 2026

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 25 pull requests #163919

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 24 pull requests #163934

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 23 pull requests #163957

Merged

rust-bors Bot merged commit 49ccb54 into rust-lang:main Oct 8, 2026
14 of 15 checks passed

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 8, 2026

rustbot added this to the 1.101.0 milestone Oct 8, 2026

cyrgani deleted the annoying-attr-macros branch October 8, 2026 08:40

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 8, 2026

github-actions Bot mentioned this pull request Oct 9, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

cyrgani mentioned this pull request Oct 9, 2026

rustc_builtin_macros cleanup, part 8 #163485

Open

theemathas mentioned this pull request Oct 10, 2026

1.100 beta regression: "cannot find value Masquerade in this scope" #164078

Open

cyrgani mentioned this pull request Oct 10, 2026

restore the old behavior for derive(Default) on fieldless types #164114

Open

Navigation Menu

Repository navigation

use the type name instead of `Self` in constructor paths again - #163863

use the type name instead of `Self` in constructor paths again#163863
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cyrgani:annoying-attr-macros

cyrgani commented Oct 6, 2026

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

nnethercote commented Oct 6, 2026

Uh oh!

nnethercote commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

JonathanBrouwer commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Uh oh!

rustbot commented Oct 8, 2026

Uh oh!

JonathanBrouwer commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

cyrgani commented Oct 6, 2026

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

nnethercote commented Oct 6, 2026

Uh oh!

nnethercote commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

JonathanBrouwer commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rustbot commented Oct 8, 2026

Uh oh!

JonathanBrouwer commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rust-bors Bot commented Oct 6, 2026 •

edited

Loading