Repository navigation
Conversation
Collaborator
|
Changes to the code generated for builtin derived traits. cc @nnethercote |
rustbot
added
S-waiting-on-review
cyrgani
commented
Oct 10, 2026
| extern crate struct_to_enum; | ||
| use struct_to_enum::*; | ||
|
|
||
| #[derive(Clone, Copy, Default, Hash, PartialEq, Eq, PartialOrd, Ord, Debug)] |
Contributor
Author
There was a problem hiding this comment.
This is also interesting: the Default derive produces an error on stable (expected struct, variant or union type, found enum Spooky), on beta (the Self constructor can only be used with tuple or unit structs), but #163863 caused it to compile. After this PR, it will fail again as on stable. Is this okay?
Member
There was a problem hiding this comment.
We shouldn't make any "this code now starts compiling" changes without going through some kind of process, so this is a bug in its own right.
Can you double check none such things slipped through in your other builtin macro refactorings? I remember you writing a series of prs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164078.
This restores the behavior before #161867, where
derive(Default)always generatedUnit {}for any struct without fields, which some (arguably wrong) code depends on.r? @nnethercote