[PastaPastaPasta]

Issue being fixed or feature implemented

Two Dash RPC files repeat the same argument and precondition checks verbatim at every call site.

What was done?

• rpc/governance.cpp: gobject vote-many, gobject vote-alias and voteraw each repeated the conversion and error handling for the vote signal and vote outcome arguments. That is now done by ParseVoteSignal() and ParseVoteOutcome(), with identical error codes and messages. RPCHelpMan already type-checks both arguments as strings before the handler runs, so the order of the get_str() calls can't change which error a request gets.
• rpc/coinjoin.cpp: coinjoin reset/start/status/stop each rejected masternodes right before calling ValidateCoinJoinArguments(). That check now lives inside the helper, which is renamed EnsureClientMixingAvailable() because it never validated arguments. The order of checks and the messages are unchanged.

Net: -28 lines.

How Has This Been Tested?

Built with --enable-debug --enable-werror on Linux x86_64. Ran feature_governance, feature_governance_cl, interface_zmq_dash (uses voteraw), rpc_coinjoin and wallet_dash_rpcs (--legacy-wallet and --descriptors): all pass.

Breaking Changes

None. RPC behavior and error messages are unchanged.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T21:27:49.826181Z	a870b57	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 059546f7-3b07-4aa5-8db6-fb5373074ae8

📥 Commits

Reviewing files that changed from the base of the PR and between 3ddad48 and a870b57.

📒 Files selected for processing: 2

• src/rpc/coinjoin.cpp
• src/rpc/governance.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

CoinJoin reset, start, status, and stop RPC handlers now use a shared masternode guard. These handlers no longer reject requests because CoinJoin is disabled. Governance vote-many, vote-alias, and voteraw now use shared helpers to parse and validate vote signals and outcomes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: knst

Merge Risk: ⚪ Minimal · up to a870b

The CoinJoin handlers continue to reject disabled states, and the governance changes preserve the described validation behavior. No concrete issue prevents merging after normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: deduplicating argument and precondition checks in the governance and CoinJoin RPCs.
Description check		The description directly explains the governance and CoinJoin refactors, preserved RPC behavior, testing, and reported absence of breaking changes.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

✅ Final review complete — no blockers (commit a870b57) · triage: low

[PastaPastaPasta]

approved

[thepastaclaw]

Final validation — Phase 1 + Phase 2

The two commits are narrow, behavior-preserving refactors. Governance vote parsing retains the original parameter ordering, error codes, and messages, while the CoinJoin helper preserves the masternode and enablement checks at all four call sites; no in-scope correctness issues were identified.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

• Triage: low by gpt-6.1-sol (effort low) — This is a small, localized RPC refactor that preserves check ordering, error codes, and messages without changing behavior or any critical surface.
• Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
• Phase 1 model: glm-5.3-flash — zai quota: 5h 97% left, weekly 95% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 14% left, 5h 100% left)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort medium); agent phase2-reviewer

[PastaPastaPasta]

approved