fix(rpc): correct masternode status help for top-level service field

[thephez]

Issue being fixed or feature implemented

The masternode status help says the top-level service field is deprecated, optional, and only returned when -deprecatedrpc=service is passed. In fact the RPC returns it every time. This key reports the host node's own address, so it was deliberately left out of the service deprecation (see rpc_netinfo.py). The help text was taken from the shared deprecated entry, which only applies to the nested dmnState.service key.

What was done?

• Replaced the shared GetRpcResult("service", /*optional=*/true) lookup in masternode status with a dedicated, non-optional result entry: "IP address and port of this masternode".
• The nested dmnState.service key and the shared help entry used by other RPCs are unchanged and still gated by -deprecatedrpc=service.

How Has This Been Tested?

Help-text-only change. rpc_netinfo.py already asserts that the top-level service key is always present in masternode status output, which matches the field now being non-optional.

Breaking Changes

None. RPC output is unchanged; only the help text differs.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[thepastaclaw]

✅ Final review complete — Phase 1 only — no blockers (commit 2fb1e39) · triage: trivial

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 35298331-5c04-4e9b-91f6-82a92f7a5dee

📥 Commits

Reviewing files that changed from the base of the PR and between f35a24c and 2fb1e39.

📒 Files selected for processing (1)

• src/rpc/masternode.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

The masternode status RPC result schema now declares service as a required string. Response construction is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 2fb1e

This corrects the help for a field already returned by masternode status; no material merge risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the RPC help-text correction for the top-level service field in masternode status.
Description check	✅ Passed	The description explains the incorrect deprecation guidance, the dedicated non-optional help entry, the unchanged RPC output, and the existing test coverage.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

Final review — Phase 1 only (trivial change)

Verified the one-line help-text change at exact head 2fb1e39: the dedicated, non-optional service entry matches the unconditional top-level RPC output and the existing rpc_netinfo.py assertion. No actionable findings were supplied or identified. This was a static review; the supplied CI snapshot shows formatting and merge checks passed, while container builds and PR-title validation remained queued.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

• Triage: trivial by gpt-6.1-sol (effort low) — The one-line change corrects RPC help metadata for an always-present field without changing RPC behavior.
• Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — dash-core-commit-history (completed, effort high); agent phase1-reviewer
• Phase 1 model: glm-5.3-flash — zai quota: 5h 99% left, weekly 89% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 15% left, 5h 100% left)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
• Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves