Repository navigation
A run stopped before it judged is passed over beside another run of the Lens on the same head (#681 step 3, record 0203) - #783
Conversation
…the Lens that did not stop, every run stopped is unreadable, and a failing check in a suite not concluded is a wait (#681, step 3) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…it judged is passed over beside another run of the Lens on the same head, amending 0026 (#681) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uite has not concluded, a suite word GitHub does not give or a run given two suites is unreadable, each field read in its form first, and only a failing check waits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, every run stopped never passes, and the suite words pinned in the test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and four older mutants of lens_reading named for its new lines Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request implements a mechanism to pass over check runs that were stopped (cancelled or timed out) before they judged, provided there is another run of the same Lens on the head that did not stop. It includes updates to the architecture documentation, a new decision record, implementation of the logic in kernel/derive.py, and comprehensive unit tests. Feedback on the implementation suggests optimizing the validation of shared runs in kernel/derive.py from O(M * N) to O(N + M) complexity by grouping suite conclusions in a single pass.
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…Lens's own App and file leaves it unreadable, the valid suite words are pinned to an approval, and the design says the Kernel cannot tell when a run stopped Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Part of #681 (step 3 of 4). The simulator's cancelled-run case is split to #749. #681 stays open until #749 lands, and step 4 waits on the Factory Builder.
What
The Kernel passes over a stopped run's checks when another run of the same Lens on the same head did not stop.
The rule. A check of a Lens is passed over, giving no verdict, when:
cancelledortimed_out;Runs are told apart by
run_idalone and never ordered by it (kernel/derive.pyrun_of,lens_reading;kernel/terms.pySTOPPED_SUITES,SUITE_CONCLUSIONS).Every run stopped. The Lens is unreadable: a wait, never a pass and never a failure.
A suite not yet concluded. A failing check there is a wait ("concluding"), even beside another run that passed. A queued item reads it as a failure and leaves the queue, so the queue never reads past a failure.
What still sticks. A completed failure in a run that did not stop still fails the Lens. Every check of a run that did not stop is still read, so decision 0104's defence against a duplicate job stands.
Absent fields. A check lacking
run_idorsuite_conclusion, or whose run is null, reads as before: it is never passed over and never passes another over. This is ruling (B): the fields are optional infacts/1.Unreadable inputs. Either field in any form but its own, a suite word GitHub does not give, or one run given two suite conclusions anywhere on the head (under another Lens's check too) leaves the Lens unreadable.
The port that writes both fields merged as #768 (step 2). The trial fixture
trials/P-65.jsonmerged as #744 (step 1).Record 0203, numbered by the Factory Builder, amends 0026's row "Every check a Lens's own App and workflow file report under its name is read, never the last alone". Design §4 and its §5 table say the same.
What remains is named in the record:
actions: writecould cancel a failing run and re-trigger it.cancelled, with one job failed for real and another timed out, would pass the real failure over. P-65 did not try this.verifyagain regardless.Held by
tests/test_decide.py::Content::test_a_cancelled_runs_checks_are_superseded_by_another_run_of_the_lens_on_the_head. It is written to the four Kernel-side rulings: (a) a stopped run is passed over beside a run that did not stop, and every run stopped is unreadable; (b) a timeout is read as a cancel; (c) a failing check in an unconcluded suite is a wait; (B) a check missing either field reads as before.lens_readingmutants are re-anchored to its new lines.kernel/derive.pyandkernel/terms.pyare killed, and none is stale.make checksis red on one check alone: record 0203 opens a gap until 0200–0202 (#779, #770, #769) merge. After that I merge main into this branch and push, and the Factory reviews that head.Second readers
Carbon (Gemini 4 Carbon), Muse, Astra and a Claude plus security review all read step 3 before its rebase onto main. Their findings were fixed in two commits, 1e17ead and 4feb768:
The rebases since have changed no content, and record 0203 only renumbers the record.
🤖 Generated with Claude Code