Skip to content

Checks: each check is given its workflow run's id and its suite's conclusion, so a cancelled run is told from a later one on the same head (#681, step 2) - #768

Merged
don-petry merged 6 commits into
mainfrom
claude/checks-suite-681-main
Nov 12, 2026
Merged

don-petry merged 6 commits into
mainfrom
claude/checks-suite-681-main

Conversation

@don-petry

@don-petry don-petry commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

User description

Part of "A cancelled run of a Lens is superseded by a later run on the same head" (#681), step 2 of its plan: the port. It follows step 1, the trial P-65 fixture (#744). The Kernel's reading is step 3, a pull request of its own after this one. The simulator's case is "Simulator: a cancelled run of a Lens beside a later run on the same head, with run ids on its checks" (#749).

What changes

Part Change
adapters/checks.py QUERY asks each check run's checkSuite { conclusion }; it already asked workflowRun { databaseId }. check() writes run_id, the workflow run's id or null for a check no workflow ran, and suite_conclusion, GitHub's word lower-cased or null while the suite has not concluded. A field is left out only where GitHub's answer leaves its key out, as the trials recorded before QUERY asked it do. A value in any form but its own is refused, never read as none
schemas/facts.schema.json The two properties, optional, by the Factory Builder's ruling (B). Absent is no default: the Kernel will read no supersession from a check that lacks either, so a cancelled run's failure stands, which fails closed. The held-out cases carry facts/1 and cannot be changed by a lane, so making them required would break the eval until their owner moved them
examples/facts.json, examples/invalid/facts.* The example carries both fields; two counter-examples hold the shape: a run id of 0, and a conclusion not lower-cased
tests/test_adapters.py Checks::test_each_check_is_given_its_runs_id_and_its_suites_conclusion. It holds the following: QUERY asks both fields; the port writes both for every node of P-65's rollup, a cancelled run's failed judging check with its suite cancelled among them; a run id of 1 is read and 0, a string, a bool or null are refused; a suite's conclusion of no whole word, of another type or empty is refused; an answer leaving a key out leaves the field out; and facts/1 holds the same at the schema

22 mutants, all killed. The 71 mutants of adapters/checks.py were all killed on the stacked branch, and the file is unchanged by the move.

Nothing reads the fields yet. sim/world.py, tests/support.py, the held-out cases and the other examples leave them out, which reads as before. No model Lens input is touched.

Verify

make checks passes; tests.test_adapters passes. Full verify is CI's.

Reviews

Read on the branch stacked on #744, whose port commits these are, unchanged but for the mutants' place in tools/mutants.py after the move onto main.

Read Head State
Claude + security be8a29fe Nothing blocking. An absent workflowRun written as null, an id overstated as ordering runs, the counter-example's name and a lost assertion: fixed in 76e0c1ef and 4a6d9044
Muse (Wonder Full) be8a29fe Three minor findings (an absent run key, the id-1 boundary, one whole word): fixed in 76e0c1ef
Carbon (gemini-4-carbon-high) be8a29fe Two majors and three minors, all mutant holes: each half of two guards, the run id asked, the block's place. Fixed in 5bdf6a89
Astra (gpt-6-astra) 5bdf6a89 One major (the schema's own boundaries untested): fixed in 4a4792e6

🤖 Generated with Claude Code

View guided diff Turn on auto-fix


CodeAnt-AI Description

Record check run IDs and suite conclusions to distinguish cancelled runs

What Changed

  • Each check now includes its workflow run ID and suite conclusion, making a cancelled run distinguishable from a later run on the same commit.
  • Checks without a workflow run report a null run ID; unfinished suites report a null conclusion.
  • Older check records without these fields remain accepted and are not treated as evidence that a later run superseded a failure.

Impact

✅ Cancelled check runs distinguishable from later runs
✅ Unfinished check suites remain identifiable
✅ Missing run details do not clear failures

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

don-petry and others added 6 commits November 11, 2026 18:59
…clusion, so a cancelled run is told from a later one on the same head (#681, step 2)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…out, an id of 1 is read, and a suite's conclusion is one whole word, each with a mutant

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…empt from an earlier run, the counter-example named for its 0, and the verify check asserted whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d asked, and the mutants beside the other checks' ones

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…whole number, and a conclusion as text, each with a mutant

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e onto main

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 12, 2026 01:00
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #57a10 Reviewed your PR 21e54f7 Nov 12, 2026 · 01:00 01:05

@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T01:03:06.395737Z 21e54f7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai codeant-ai Bot added the size:XL This PR changes 500-999 lines, ignoring generated files label Nov 12, 2026
@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the check run adapter to retrieve, validate, and include the workflow run ID (run_id) and check suite conclusion (suite_conclusion) from GitHub's GraphQL API, allowing the system to distinguish cancelled runs from subsequent runs on the same head. The JSON schema, example files, and test suite have been updated to support and validate these new fields. As there are no review comments, I have no feedback to provide.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 21e54f7fa5e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants