Repository navigation
Checks: each check is given its workflow run's id and its suite's conclusion, so a cancelled run is told from a later one on the same head (#681, step 2) - #768
Conversation
…clusion, so a cancelled run is told from a later one on the same head (#681, step 2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…out, an id of 1 is read, and a suite's conclusion is one whole word, each with a mutant Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…empt from an earlier run, the counter-example named for its 0, and the verify check asserted whole Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d asked, and the mutants beside the other checks' ones Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…whole number, and a conclusion as text, each with a mutant Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e onto main Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
Code Review
This pull request updates the check run adapter to retrieve, validate, and include the workflow run ID (run_id) and check suite conclusion (suite_conclusion) from GitHub's GraphQL API, allowing the system to distinguish cancelled runs from subsequent runs on the same head. The JSON schema, example files, and test suite have been updated to support and validate these new fields. As there are no review comments, I have no feedback to provide.



User description
Part of "A cancelled run of a Lens is superseded by a later run on the same head" (#681), step 2 of its plan: the port. It follows step 1, the trial P-65 fixture (#744). The Kernel's reading is step 3, a pull request of its own after this one. The simulator's case is "Simulator: a cancelled run of a Lens beside a later run on the same head, with run ids on its checks" (#749).
What changes
adapters/checks.pyQUERYasks each check run'scheckSuite { conclusion }; it already askedworkflowRun { databaseId }.check()writesrun_id, the workflow run's id or null for a check no workflow ran, andsuite_conclusion, GitHub's word lower-cased or null while the suite has not concluded. A field is left out only where GitHub's answer leaves its key out, as the trials recorded beforeQUERYasked it do. A value in any form but its own is refused, never read as noneschemas/facts.schema.jsonfacts/1and cannot be changed by a lane, so making them required would break the eval until their owner moved themexamples/facts.json,examples/invalid/facts.*tests/test_adapters.pyChecks::test_each_check_is_given_its_runs_id_and_its_suites_conclusion. It holds the following:QUERYasks both fields; the port writes both for every node of P-65's rollup, a cancelled run's failed judging check with its suitecancelledamong them; a run id of 1 is read and 0, a string, a bool or null are refused; a suite's conclusion of no whole word, of another type or empty is refused; an answer leaving a key out leaves the field out; andfacts/1holds the same at the schema22 mutants, all killed. The 71 mutants of
adapters/checks.pywere all killed on the stacked branch, and the file is unchanged by the move.Nothing reads the fields yet.
sim/world.py,tests/support.py, the held-out cases and the other examples leave them out, which reads as before. No model Lens input is touched.Verify
make checkspasses;tests.test_adapterspasses. Full verify is CI's.Reviews
Read on the branch stacked on #744, whose port commits these are, unchanged but for the mutants' place in
tools/mutants.pyafter the move onto main.workflowRunwritten as null, an id overstated as ordering runs, the counter-example's name and a lost assertion: fixed in 76e0c1ef and 4a6d9044🤖 Generated with Claude Code
CodeAnt-AI Description
Record check run IDs and suite conclusions to distinguish cancelled runs
What Changed
Impact
✅ Cancelled check runs distinguishable from later runs✅ Unfinished check suites remain identifiable✅ Missing run details do not clear failures💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.