Repository navigation
Trial P-65: a cancelled run's suite concludes cancelled, its judging check failure, and the rollup gives each check its suite's conclusion and its run (#681, step 1) - #744
Conversation
…check failure, and the rollup gives each check its suite's conclusion and its run (#681) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st weigh (a re-run's order, a timeout's cancel, the second before a suite concludes), P-8's measure, batch 4, and a trim to stay under the budget Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… its number Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he reads hold Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
Code Review
This pull request introduces a new trial, P-65, to the software factory design documentation and adds its corresponding trial log file trials/P-65.json. Trial P-65 verifies and documents the behavior of GitHub Actions check suites and workflow runs when a workflow run is cancelled mid-way, showing that the check suite and workflow run conclude as cancelled while any judging job using if: always() concludes as a failure. I have no feedback to provide on these changes.
|
… read on its own Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Factory Builder: renewing this item's Run ceiling. Its ten Runs since a writer last acted all ended in the runner outage of 2026-11-11 (14:00Z to 22:24Z, before the v0.1.8 cut), as environment faults that reviewed nothing. #757 tracks counting such Runs out of the ceiling. A push is no writer's action, so the new head did not renew the count; this comment does. |



User description
Part of #681, "A cancelled run of a Lens is superseded by a later run on the same head": step 1 of its plan, ruled option (B) by the Factory Builder (trial, then port, then Kernel). The fixture alone, in its own PR, as ruled.
Trial P-65: verdict pass
The question and the pass condition were written at 14:02:59Z, before anything ran (
trials/P-65.jsonpass). The trial ran on canary pull request 102, as the Maintainer. Its workflowp65-cancel.ymlwas granted nothing and checked nothing out:p65 / worksleeps 240 s, andp65 / verifyneeds it, runs underif: always(), and fails unless work succeeded.What ran:
cancelled;p65 / workcancelled,p65 / verifyfailurerun_attempttells them apart); the rollup gives only the latest attempt'ssuccesscheckSuite { conclusion }andworkflowRun { runNumber }, beside the run'sdatabaseIdthe port reads already, costs 1, as the port's query does. P-8's measure standsThe section 6 row also names three limits the Kernel step (3) must rule on, from the Claude review:
cancelledtoo (P-42).Every cancel was by hand; a concurrency group's was not tried.
Removed: the
authorizationheaderghsent, from each of the 8 exchanges. The redaction of the eight captures found no credential: it removed only response headers a fixture may not keep. The bodies are trimmed to p65-cancel.yml's suites, runs and checks, as eachcallsays, to keep the PR under the diff budget.Step 8, undone in the canary:
trial/p65-canceldeleted.Grounding: no rule of
sim/grounding.pynames P-65 yet. The port's PR (#681 step 2) adds the fake's cancelled-run case and grounds it on this fixture.Verify
make checkspasses,trialsincluded. Full verify is CI's.Reviews
🤖 Generated with Claude Code
CodeAnt-AI Description
Document how cancelled workflow runs appear in pull request checks
What Changed
Impact
✅ Clearer cancelled-run check results✅ Distinguishable checks for separate workflow runs✅ One-query check attribution💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.