Repository navigation
The simulator gives each check its run and suite, and starts another run of a Lens beside the one it leaves (#749) - #800
Conversation
…run of a Lens beside the one it leaves (#749) Each Lens a workflow runs reports from a workflow run, its suite concluding as its check does; on one seed in four another run starts on the head, by a push back to it, a reopening or a re-run of an earlier run, and the run it leaves stays beside it, cancelled with its judging check failed if it was in progress (trials/P-65.json). The world's invariants read a stopped run passed over beside one that did not stop, and a new one holds that a stopped run never lets a Lens pass that a completed failure fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Kernel's own Lens, a re-run keeps its id and is the person's, and every check names its run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
There was a problem hiding this comment.
Code Review
This pull request implements simulation and validation logic for tracking multiple workflow runs of a Lens on a commit head, addressing issue 749 and trial P-65. It introduces tracking for workflow run IDs and suite conclusions, handles cancelled or stopped runs correctly when a new run is started (via push backs, reopenings, or re-runs), and updates the state evaluation logic to ensure stopped runs do not incorrectly cause a Lens to pass or fail. Corresponding tests have been added to verify these behaviors in both the adapter and simulator tests. I have no feedback to provide as there are no review comments.
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="sim/grounding.py">
<violation number="1" location="sim/grounding.py:93">
P3: This comment cites issue 749 for trials/P-65.json, but the design doc, schema, Kernel and port cite issue 681 for the same trial. Cite one issue number for the trial's provenance so the grounding can be traced.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|



Fixes #749
The simulator now reaches #681 step 3's rule (record 0203, #783). That rule passes over a check from a run whose suite concluded
cancelledortimed_out, beside another run of the same Lens on the head that did not stop. This change adds no new rule and no record, by the Factory Builder's ruling.Protected paths:
sim/world.pyandtests/test_simulator.py, pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder 2026-11-11.What
Run ids and suites. Each check carries
run_idandsuite_conclusion, asadapters/checks.pywrites them:run_idnull and its App's suite.The fault (
another_run). On one seed in four (seed % 4 == 3), another run of a workflow Lens starts on the head. The causes are the three P-65 recorded:The run it leaves stays beside it. If it was in progress, it is cancelled: suite
cancelled,if: always()judging checkfailure. Otherwise it stays as it concluded. The fault prefers a Lens whose run just failed. A person's re-run result is that person's (the ruling on #38).Grounding.
sim/grounding.pyaddsa_check_names_its_run_and_suiteanda_cancelled_run_stays_beside_a_later_run, both ontrials/P-65.json. The port reads each of them from that fixture (tests/test_adapters.py).Invariants, restated in the world's own words:
passed()/failed(). A stopped run is passed over beside one that did not stop, and a failure an earlier run left counts.Held by
tests/test_simulator.py::test_the_seeds_start_another_run_of_a_lens_on_the_head. It holds:cancellednever passes;lens_readingpasses a Lens with a cancelled run beside a passing one;test_invariants_hold_under_faults, on the fixed seeds.sim/world.pyandsim/grounding.py, with the Kernel mutants this test names, are killed. Among them:facts()line and the queue's merge gate.make checkspasses.Seed review
I compared every seed's trace and transitions over 250 steps, before and after: 76 of 300 seeds change.
timed_out, its suitetimed_out. Alone it is now every run stopped, so unreadable (verifying check_unreadable -> defer), where it used to fail (addressing check_failed -> admit), under ruling (b)verifying, notaddressing, so the transitions it makes differNone is unexplained.
Not modelled
concluding) is never served. In P-65 a judging check concluded about a second before its suite; the world concludes both at once.Second readers
sim/AGENTS.mdnames the testlens_reading(it could pass vacuously), and the queue reads earlier runs. Minors: a re-run's result is the person's, which is fixed; the two not modelled above are namedThe fixes in a66ba2b came after the readers; none of them re-read that head.
🤖 Generated with Claude Code