Repository navigation
Conversation
…d a merge group's never is (#681 step 4, record 0206 provisional) #679's concurrency returns now that a cancelled run's check is passed over beside a later run (record 0203), with its review's points: the two expressions are allowed in verify.yml's top-level concurrency alone and named in the rule `expression`, and record 0206 amends 0014's concurrency row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is refused alone outside the required check's workflow, and the check of the repo's files is held to give the allowance to verify.yml alone Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request configures concurrency for the required check's workflow (verify.yml), allowing a newer push to a pull request to cancel its previous run while ensuring merge group runs are never cancelled. It updates the decision records, workflow standards, and the workflow linter (tools/check_workflows.py) to enforce these rules. The review feedback points out an issue with excessive indentation in the linter's continuation lines, suggesting a cleaner wrapping format.
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
… id, so it takes the place of no newer push's waiting run A group keeps one run waiting whatever cancel-in-progress says, so in the pull request's group a re-run of an older head's run would replace the newest head's run waiting. The group is now the pull request's only for its first attempt; record 0206's row says so. A test and a mutant hold it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Closed to reopen fresh from the same branch at the same head (49c2695): this pull request is held as description_edited_after_approval, since its description was edited at 07:20Z after the Factory's approval of 73a6c23 at 07:14Z (dismissed by the push of 49c2695). The new pull request carries the same title and description, unedited. |



Part of #681, its last step (4 of 4). Step 3 landed as #783, and the simulator's case is #800 for #749. #681 is closed once both land.
A newer push now cancels a pull request's run of the required check. A merge group's run is never cancelled. This is "CI: a newer push cancels its pull request's verify run, and a merge group's run is never cancelled" (pull request 679) brought back now that step 3 is on main: decision 0203 passes over a cancelled run's failed
verifybeside a later run on the same head. It carries the points of #679's Claude review, and of this change's readers.Protected edit (
.github/workflows/verify.yml): pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder 2026-11-11. The second edit to it, in 49c2695 (a re-run's group is its own run's id, from cubic's and CodeAnt's read): pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder 2026-11-13, after the push.What
.github/workflows/verify.ymlgains one top-level concurrency; its example copies match it word for word:cancel-in-progresssays (cubic, CodeAnt; fixed in 49c2695).tools/check_workflows.py:lint(text, required=...)allows the two expressions in the required check's workflow alone;run()setsrequiredforverify.ymlonly. In any other workflow each expression, alone too, is refused. This is the first point of CI: a newer push cancels its pull request's verify run, and a merge group's run is never cancelled #679's review.RULES['expression']names both expressions, the second point.lens_job_problemsrefuses any other top-level concurrency in the required check's workflow.Record 0206 (provisional): amends decision 0014's row "A concurrency group on CI", the third point. The Factory Builder confirms its number at enqueue, after 0204 (#784) and 0205 (#776).
Held by
tests/test_tools.py::test_only_a_superseded_pull_request_run_is_cancelled, extended so that:run()refuses the block inexamples/workflows/other.ymland allows it inverify.yml.tools/check_workflows.pymutants are killed, andtests.test_tools.Workflowspasses.make checks: red on one check alone. Record 0206 opens a gap until 0204 and 0205 merge; then I merge main and push.What remains (in record 0206)
.github/workflows/ci.ymlhas no group, so its outdated runs run to the end; they take under a minute.verifyat all. P-65 cancelled by hand. Either case is of a head a newer push replaced.Second readers
run_attempt == 1); the scoping test masked one expression behind the other (each is now tested alone)run()'s scoping toverify.yml(test and mutant added). 2 minors, fixed in record 0206: a re-run from an older head, and the group's cancel and eviction not triedThe fixes in c214084 came after the readers; none of them re-read that head.
🤖 Generated with Claude Code