Repository navigation
i18n: Simplified Chinese translates 114 status and error messages that no catalog had - #7486
Merged
bflatastic merged 1 commit intoNov 14, 2026
Conversation
…t no catalog had untranslated_report lists 167 status and error messages that no complete-message catalog translates. zh-hans.tsv gains 114 @msg rows for the ones no open pull request covers: 3D and Revolve limits, image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, path operations, swatch, graphic style and action set libraries, and zip, script and regular expression errors. Placeholders, backticked names, command ids and listed values stay as the English writes them. The other 53 (composite fonts, SVG filters, read roots and graph design) are left to storytold#7211, storytold#7378 and storytold#7405. docs/localization-parity.md and docs/target-app-parity.md give the new counts: 3,554 @msg rows, and 55 messages the report lists for zh-hans, all of them translated by open pull requests.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
On
mainate56d1c7,untranslated_report(crates/ui-egui/src/i18n/tests.rs) lists 167 status and error messages under "messages, all 23 languages checked": no complete-message catalog has a row for them. With the interface in Simplified Chinese, these messages were shown in English.crates/ui-egui/src/i18n/zh-hans.tsvgains 114@msgrows for the listed messages, among them 3D and Revolve limits, image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, path operation errors, graphic style, swatch and action set library files, and script, zip and regular expression errors.docs/localization-parity.mdand its line indocs/target-app-parity.mdhave the new counts: 3,554@msgrows, and 55 messages the report lists for zh-hans, each translated by open i18n: the justification order error is translated in every complete catalog #7116, i18n: translate the composite font errors in the complete-message languages #7211, Blob Brush: path.blob rejects invalid fidelity, angle and roundness #7330, i18n: SVG filter refusals are translated, and side-by-side menu items differ #7378 or i18n: translate the read-root, linked JavaScript and graph design refusals #7405.This is the Simplified Chinese part of the missing message rows, next to #7423 (French), #7463 (Japanese), #7470 (Brazilian Portuguese) and #7483 (Ukrainian). Checked against
mainate56d1c7:git merge-treewith the heads of #7116, #7211, #7330, #7352, #7378, #7405, #7423, #7434, #7463, #7470, #7472 and #7483 merges without a conflict.How it was tested
The change adds catalog rows only, so it has no new test.
untranslated_reportis a report that does not fail on a gap. Before the change its "messages, all 23 languages checked" list had 167 entries; after it, 53, each of them a row that #7211, #7378 or #7405 adds. Its Simplified Chinese message list holds none of the 114 messages.Focused checks on the final tree, on
mainate56d1c7:cargo test -p vectorcraft-ui-egui --lib i18n: 115 passed, 0 failed.cargo fmt --all -- --check;cargo check --workspace --tests;cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings;cargo xtask brands;cargo xtask layers(30 crates, no layering violations);cargo xtask assets(337 asset files attributed).cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.