Skip to content

i18n: Simplified Chinese translates 114 status and error messages that no catalog had - #7486

Merged
bflatastic merged 1 commit into
storytold:mainfrom
dotCooCoo:fix/zh-hans-missing-message-rows
Nov 14, 2026
Merged

bflatastic merged 1 commit into
storytold:mainfrom
dotCooCoo:fix/zh-hans-missing-message-rows

Conversation

@dotCooCoo

Copy link
Copy Markdown
Contributor

What and why

On main at e56d1c7, untranslated_report (crates/ui-egui/src/i18n/tests.rs) lists 167 status and error messages under "messages, all 23 languages checked": no complete-message catalog has a row for them. With the interface in Simplified Chinese, these messages were shown in English.

This is the Simplified Chinese part of the missing message rows, next to #7423 (French), #7463 (Japanese), #7470 (Brazilian Portuguese) and #7483 (Ukrainian). Checked against main at e56d1c7: git merge-tree with the heads of #7116, #7211, #7330, #7352, #7378, #7405, #7423, #7434, #7463, #7470, #7472 and #7483 merges without a conflict.

How it was tested

The change adds catalog rows only, so it has no new test. untranslated_report is a report that does not fail on a gap. Before the change its "messages, all 23 languages checked" list had 167 entries; after it, 53, each of them a row that #7211, #7378 or #7405 adds. Its Simplified Chinese message list holds none of the 114 messages.

Focused checks on the final tree, on main at e56d1c7:

  • cargo test -p vectorcraft-ui-egui --lib i18n: 115 passed, 0 failed.
  • cargo fmt --all -- --check; cargo check --workspace --tests; cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings; cargo xtask brands; cargo xtask layers (30 crates, no layering violations); cargo xtask assets (337 asset files attributed).
  • cargo xtask ci runs in this pull request's CI.

Checklist

  • cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
  • No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
    unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
    messages. Errors are returned as Result and shown to the user
    (why and how).
  • Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
  • Every new asset has a row in ASSETS.md.

…t no catalog had

untranslated_report lists 167 status and error messages that no
complete-message catalog translates. zh-hans.tsv gains 114 @msg rows for
the ones no open pull request covers: 3D and Revolve limits, image export
and encoding errors, color profiles, color books and swatch exchange
files, binary DXF and DWG import, path operations, swatch, graphic style
and action set libraries, and zip, script and regular expression errors.
Placeholders, backticked names, command ids and listed values stay as the
English writes them.

The other 53 (composite fonts, SVG filters, read roots and graph design)
are left to storytold#7211, storytold#7378 and storytold#7405. docs/localization-parity.md and
docs/target-app-parity.md give the new counts: 3,554 @msg rows, and 55
messages the report lists for zh-hans, all of them translated by open
pull requests.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e56d1c7 and 3341061.

Files ignored due to path filters: 1

  • crates/ui-egui/src/i18n/zh-hans.tsv is excluded by !**/*.tsv
Files selected for processing: 2

  • docs/localization-parity.md
  • docs/target-app-parity.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@bflatastic
bflatastic merged commit 040311b into storytold:main Nov 14, 2026
7 checks passed
@bflatastic

Copy link
Copy Markdown
Member

Merged, thanks @dotCooCoo! It passed its CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants