[dotCooCoo]

What and why

On main at 1e4e353, untranslated_report (crates/ui-egui/src/i18n/tests.rs) lists 167 status and error messages under "messages, all 23 languages checked": no complete-message catalog has a row for them. With the interface in French, these messages were shown in English.

• crates/ui-egui/src/i18n/fr.tsv gains 114 @msg rows for the listed messages: image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, 3D and Revolve limits, and script, zip, line and file errors.
• The rows sit in one commented block at the end of the file. Placeholders, parameter names, command ids and literal values stay as the English writes them. The translations use the catalog's existing terms and the typography its header describes (a no-break space before : ; ? !, and the typographic apostrophe).
• The 53 listed messages that i18n: translate the composite font errors in the complete-message languages #7211, i18n: SVG filter refusals are translated, and side-by-side menu items differ #7378 and i18n: translate the read-root, linked JavaScript and graph design refusals #7405 translate (composite fonts, SVG filters, a linked script outside the read roots and graph design art) are left out, so no row is added twice when those merge.

This is the French part of the missing message rows; each other language goes up as its own pull request. #7307 adds French rows for the messages that other catalogs already translate; none of its rows is among these 114, and git merge-tree with its head 9259437 merges fr.tsv without a conflict.

How it was tested

The change adds catalog rows only, so it has no new test. untranslated_report is a report that does not fail on a gap. After the change, its "messages, all 23 languages checked" list has 53 entries, each of them a row that #7211, #7378 or #7405 adds, and its French message list holds none of the 114 messages.

Focused checks on the final tree, which merges cleanly with main at 1e4e353:

• cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings
• cargo check --workspace --tests
• cargo test -p vectorcraft-ui-egui --lib i18n: 115 passed, 0 failed.
• cargo xtask brands; cargo xtask layers (30 crates, no layering violations); cargo xtask assets (337 asset files attributed).
• cargo fmt --all -- --check reports one diff, in crates/svg/src/lib.rs at line 491, which this pull request does not change; it is on main at 1e4e353 too, and fmt: format crates/svg/src/lib.rs #7400 fixes it.
• cargo xtask ci runs in this pull request's CI.

Checklist

• cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
• No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
  unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
  messages. Errors are returned as Result and shown to the user
  (why and how).
• Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
• Every new asset has a row in ASSETS.md.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

• crates/ui-egui/src/i18n/fr.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

• Source mode: Auto
• Repository: storytold/vectorcraft
• Branch: main
• File: .coderabbit.yaml
• Commit: 124e3cc
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8fda71c7-d430-4801-b3a5-43ba1d71d2da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[bflatastic]

Merged, thanks @dotCooCoo! It passed its CI checks.