Skip to content

i18n: Greek translates 115 status and error messages it showed in English - #7544

Merged
bflatastic merged 2 commits into
storytold:mainfrom
dotCooCoo:fix/el-missing-message-rows
Nov 14, 2026
Merged

bflatastic merged 2 commits into
storytold:mainfrom
dotCooCoo:fix/el-missing-message-rows

Conversation

@dotCooCoo

Copy link
Copy Markdown
Contributor

What and why

untranslated_report (crates/ui-egui/src/i18n/tests.rs) lists, for each complete-message language, the status and error messages its catalog does not translate. Greek's list included 115 messages that this change translates. 113 of them have a Russian row on main (from #7482), and #7423 (French) and #7499 (Traditional Chinese) add rows for them in their languages. The other two, the "index must be a whole number" error and the PDF export warning for knockout groups, have no row in any catalog. With the interface in Greek, these messages were shown in English.

How it was tested

The change adds catalog rows only, so it has no new test. untranslated_report is a report that does not fail on a gap. After the change, its "messages, all 23 languages checked" list has the 53 messages of #7211, #7378 and #7405 and the knockout warning under its scanned key, and its Greek message list holds none of the 115 messages.

Focused checks on the final tree, one commit on main at edb228a (checked on 2026-11-14 as the current main):

  • cargo fmt --all -- --check
  • cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings
  • cargo check --workspace --tests
  • cargo test -p vectorcraft-ui-egui --lib i18n: 118 passed, 1 failed. The failure, translated_messages_keep_the_field_names_and_values_their_english_lists, reports two rows in fr.tsv on main that translate the field names subpath and anchor of the list [subpath, anchor] (its message counts the four dropped names as "4 rows"); this change does not touch fr.tsv, and no Greek row has that list.
  • cargo xtask brands; cargo xtask layers (30 crates, no layering violations); cargo xtask assets (337 asset files attributed).
  • cargo xtask ci runs in this pull request's CI.

Checklist

  • cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
  • No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
    unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
    messages. Errors are returned as Result and shown to the user
    (why and how).
  • Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
  • Every new asset has a row in ASSETS.md.

…lish

Adds a Greek row for 115 status and error messages that the Greek
catalog did not translate: effects, 3D, image export, color profiles,
swatch exchange files, color books, DXF import, the `index` whole-number
error and the PDF export warning for knockout groups. Placeholders,
parameter names, command ids and literal values stay as the English
writes them.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • crates/ui-egui/src/i18n/el.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@bflatastic
bflatastic merged commit d65ca0c into storytold:main Nov 14, 2026
7 checks passed
@bflatastic

Copy link
Copy Markdown
Member

Merged, thanks @dotCooCoo! It passed its CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants