Repository navigation
i18n: Greek translates 115 status and error messages it showed in English - #7544
Merged
bflatastic merged 2 commits intoNov 14, 2026
Merged
Conversation
…lish Adds a Greek row for 115 status and error messages that the Greek catalog did not translate: effects, 3D, image export, color profiles, swatch exchange files, color books, DXF import, the `index` whole-number error and the PDF export warning for knockout groups. Placeholders, parameter names, command ids and literal values stay as the English writes them.
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
untranslated_report(crates/ui-egui/src/i18n/tests.rs) lists, for each complete-message language, the status and error messages its catalog does not translate. Greek's list included 115 messages that this change translates. 113 of them have a Russian row onmain(from #7482), and #7423 (French) and #7499 (Traditional Chinese) add rows for them in their languages. The other two, the "indexmust be a whole number" error and the PDF export warning for knockout groups, have no row in any catalog. With the interface in Greek, these messages were shown in English.crates/ui-egui/src/i18n/el.tsvgains 115@msgrows: image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, 3D and Revolve limits, script, zip, line and file errors, and the two messages above.\line continuation incrates/pdf/src/export/nodes.rs:884, so the report keeps listing it after this change.`answers[{i}]` {e}, so this change leaves that message out too. No other open pull request that changesel.tsvadds one of these 115 messages.How it was tested
The change adds catalog rows only, so it has no new test.
untranslated_reportis a report that does not fail on a gap. After the change, its "messages, all 23 languages checked" list has the 53 messages of #7211, #7378 and #7405 and the knockout warning under its scanned key, and its Greek message list holds none of the 115 messages.Focused checks on the final tree, one commit on
mainatedb228a(checked on 2026-11-14 as the currentmain):cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo test -p vectorcraft-ui-egui --lib i18n: 118 passed, 1 failed. The failure,translated_messages_keep_the_field_names_and_values_their_english_lists, reports two rows infr.tsvonmainthat translate the field namessubpathandanchorof the list[subpath, anchor](its message counts the four dropped names as "4 rows"); this change does not touchfr.tsv, and no Greek row has that list.cargo xtask brands;cargo xtask layers(30 crates, no layering violations);cargo xtask assets(337 asset files attributed).cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.