Skip to content

i18n: Brazilian Portuguese translates 114 status and error messages that no catalog had - #7470

Merged
bflatastic merged 3 commits into
storytold:mainfrom
dotCooCoo:fix/pt-br-missing-message-rows
Nov 14, 2026
Merged

bflatastic merged 3 commits into
storytold:mainfrom
dotCooCoo:fix/pt-br-missing-message-rows

Conversation

@dotCooCoo

Copy link
Copy Markdown
Contributor

What and why

On main at 1e4e353, untranslated_report (crates/ui-egui/src/i18n/tests.rs) lists 167 status and error messages under "messages, all 23 languages checked": no complete-message catalog has a row for them. With the interface in Brazilian Portuguese, these messages were shown in English.

This is the Brazilian Portuguese part of the missing message rows; each other language goes up as its own pull request. Checked against main at 1e4e353: git merge-tree with the heads of #7211, #7378, #7405, #7116, #7330, #7410, #7423, #7426, #7430, #7434 and #7435 merges without a conflict. It conflicts with #7307 in docs/localization-parity.md, where #7307 changes the French row next to the Portuguese one; the resolution keeps both lines.

How it was tested

The change adds catalog rows only, so it has no new test. untranslated_report is a report that does not fail on a gap. After the change, its "messages, all 23 languages checked" list has 53 entries, each of them a row that #7211, #7378 or #7405 adds, and its Brazilian Portuguese message list holds none of the 114 messages.

Focused checks on the final tree, on main at 1e4e353:

  • cargo test -p vectorcraft-ui-egui --lib i18n: 115 passed, 0 failed.
  • cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings; cargo check --workspace --tests; cargo xtask brands; cargo xtask layers (30 crates, no layering violations); cargo xtask assets (337 asset files attributed).
  • cargo fmt --all -- --check reports one diff, in crates/svg/src/lib.rs at line 491, which this pull request does not change; it is on main at 1e4e353 too, and fmt: format crates/svg/src/lib.rs #7400 fixes it.
  • cargo xtask ci runs in this pull request's CI.

Checklist

  • cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
  • No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
    unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
    messages. Errors are returned as Result and shown to the user
    (why and how).
  • Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
  • Every new asset has a row in ASSETS.md.

The untranslated report listed 167 status and error messages that no
complete-message catalog translated. pt-br.tsv now has an @msg row for
the 114 of them that no open pull request already translates: messages
of the 3D and Revolve effects, the image encoders, color profiles, swatch
exchange files, color books and DXF import. Placeholders, parameter names
and literal values stay as the English writes them.

The other 53 (composite font, SVG filter, read root and graph design
messages) are translated by open storytold#7211, storytold#7378 and storytold#7405; adding them here
too would make bundled_catalogs_are_consistent fail on a duplicate row
once those merge.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a47d7ee and 4ca74c0.

Files ignored due to path filters: 1

  • crates/ui-egui/src/i18n/pt-br.tsv is excluded by !**/*.tsv
Files selected for processing: 2

  • docs/localization-parity.md
  • docs/target-app-parity.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@bflatastic
bflatastic merged commit 0e54cf8 into storytold:main Nov 14, 2026
7 checks passed
@bflatastic

Copy link
Copy Markdown
Member

Merged, thanks @dotCooCoo! It passed its CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants