Repository navigation
i18n: Brazilian Portuguese translates 114 status and error messages that no catalog had - #7470
Merged
bflatastic merged 3 commits intoNov 14, 2026
Merged
Conversation
The untranslated report listed 167 status and error messages that no complete-message catalog translated. pt-br.tsv now has an @msg row for the 114 of them that no open pull request already translates: messages of the 3D and Revolve effects, the image encoders, color profiles, swatch exchange files, color books and DXF import. Placeholders, parameter names and literal values stay as the English writes them. The other 53 (composite font, SVG filter, read root and graph design messages) are translated by open storytold#7211, storytold#7378 and storytold#7405; adding them here too would make bundled_catalogs_are_consistent fail on a duplicate row once those merge.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 of 4 tasks
3 of 4 tasks
3 of 4 tasks
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
On
mainat1e4e353,untranslated_report(crates/ui-egui/src/i18n/tests.rs) lists 167 status and error messages under "messages, all 23 languages checked": no complete-message catalog has a row for them. With the interface in Brazilian Portuguese, these messages were shown in English.crates/ui-egui/src/i18n/pt-br.tsvgains 114@msgrows for the listed messages, among them 3D and Revolve limits, image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, path operation errors, graphic style, swatch and action set library files, automation and API parameter errors, and script, zip, line and file errors.docs/localization-parity.mdhas the new counts, anddocs/target-app-parity.mdhas one line for the catalog's message rows.This is the Brazilian Portuguese part of the missing message rows; each other language goes up as its own pull request. Checked against
mainat1e4e353:git merge-treewith the heads of #7211, #7378, #7405, #7116, #7330, #7410, #7423, #7426, #7430, #7434 and #7435 merges without a conflict. It conflicts with #7307 indocs/localization-parity.md, where #7307 changes the French row next to the Portuguese one; the resolution keeps both lines.How it was tested
The change adds catalog rows only, so it has no new test.
untranslated_reportis a report that does not fail on a gap. After the change, its "messages, all 23 languages checked" list has 53 entries, each of them a row that #7211, #7378 or #7405 adds, and its Brazilian Portuguese message list holds none of the 114 messages.Focused checks on the final tree, on
mainat1e4e353:cargo test -p vectorcraft-ui-egui --lib i18n: 115 passed, 0 failed.cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings;cargo check --workspace --tests;cargo xtask brands;cargo xtask layers(30 crates, no layering violations);cargo xtask assets(337 asset files attributed).cargo fmt --all -- --checkreports one diff, incrates/svg/src/lib.rsat line 491, which this pull request does not change; it is onmainat1e4e353too, and fmt: format crates/svg/src/lib.rs #7400 fixes it.cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.