Repository navigation
i18n: German translates the messages no catalog had a row for - #7410
Merged
bflatastic merged 4 commits intoNov 14, 2026
Merged
Conversation
The untranslated report listed 167 status and error messages with no row in any complete-message catalog, and 11 more that other catalogs translate but German did not, so with the interface in German these messages showed in English. - de.tsv gains 116 `@msg` rows for the listed messages: image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, 3D and Revolve limits, and script, zip and file errors. They sit in one commented block after the existing message rows. - de.tsv gains 10 `@msg` rows for the Banner Hems and Grommets errors and the failed recovery save. - The 51 listed messages that open storytold#7211 and storytold#7378 translate (composite fonts and SVG filters), and the justification order error that open storytold#7116 translates, are left out, so no row is added twice. - Placeholders, parameter names, command ids and literal values stay as the English writes them. The translations use the catalog's existing terms and typography. - docs/localization-parity.md and docs/target-app-parity.md give the German counts: 3,563 `@msg` and 48 `@msgplural` rows, 52 messages still listed.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
3 of 4 tasks
3 of 4 tasks
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
On
mainat1e4e353,untranslated_report(crates/ui-egui/src/i18n/tests.rs) lists 167 status and error messages under "messages, all 23 languages checked": no complete-message catalog has a row for them. German also lacked 11 messages that other catalogs translate. With the interface in German, these messages were shown in English.crates/ui-egui/src/i18n/de.tsvgains 116@msgrows for the listed messages: image export and encoding errors, color profiles, color books and swatch exchange files, binary DXF and DWG import, 3D and Revolve limits, and script, zip and file errors.@msgrows for the Banner Hems and Grommets errors and the failed recovery save.docs/localization-parity.mdanddocs/target-app-parity.mdgive the new counts: 3,563@msgand 48@msgpluralrows, 52 messages still listed.This is the German part of the missing message rows; each other language goes up as its own pull request.
How it was tested
The change adds catalog rows only, so it has no new test.
untranslated_reportis a report that does not fail on a gap; after the change its "messages, all 23 languages checked" list has 51 entries, each of them a row that #7211 or #7378 adds, and its German message list has one entry, the row #7116 adds.Focused checks on the final tree, on
mainat1e4e353:cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo test -p vectorcraft-ui-egui --lib i18n: 115 passed, 0 failed.cargo xtask brands;cargo xtask layers(30 crates, no layering violations);cargo xtask assets(337 asset files attributed).cargo fmt --all -- --checkreports one diff, incrates/svg/src/lib.rsat line 491, which this pull request does not change; it is onmainat1e4e353too, and fmt: format crates/svg/src/lib.rs #7400 fixes it.cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.