Repository navigation
Docs: the complete-message language lists match COMPLETE_MESSAGES - #7472
Merged
bflatastic merged 2 commits intoNov 14, 2026
Merged
Conversation
The development guide and the progress doc now name all 23 languages in COMPLETE_MESSAGES: Hindi was missing from the first, and Georgian, Hindi, Turkish and Catalan from the second. The localization summary adds Bosnian to the languages marked full that are not in the list.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 of 4 tasks
3 of 4 tasks
3 of 4 tasks
3 of 4 tasks
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
COMPLETE_MESSAGES(crates/ui-egui/src/i18n/tests.rs:4035-4038) lists 23 languages whose catalogs translate status and error messages: cs, de, el, es, fr, hi, hu, it, ja, ka, ko, pl, pt-br, ru, sv, uk, vi, zh-hans, zh-hant, fi, tr, ca and nl. Three docs lines that name that set did not match it:docs/development.md:297left out Hindi. It now names all 23 languages.docs/target-app-parity.md:1376(Interface languages, vertical type) left out Georgian, Hindi, Turkish and Catalan. It now names all 23 languages.docs/localization-parity.md:18says which languages marked "full" are not in the list. It named Bulgarian, Danish and Indonesian; Bosnian is also marked full (:62) and is not in the list, so it is added.Each line keeps its existing order, with the missing names inserted. No code, catalog row or test changes.
How it was tested
No code changed, so no test was added. The language names in both lists were counted against the 23 codes in
COMPLETE_MESSAGES, each English name checked against itsLangInfocode incrates/ui-egui/src/i18n.rs. The Status column ofdocs/localization-parity.mdwas checked for every non-English row marked full: bs, bg, da and id are the ones outside the list.Checks on the final tree, on
mainat1e4e3534f5(the branch merges into it without conflicts):cargo xtask brands: no vendor names in user-visible text.cargo xtask assets: all 337 asset files attributed inASSETS.md.cargo check --workspace --tests: passes.cargo fmt --all -- --check: reports one diff, incrates/svg/src/lib.rs:491, which this branch does not change; the file is the same onmainat1e4e3534f5.git diff --check: clean.cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.