Repository navigation
i18n: Dutch translates 1,813 of the status and error messages the untranslated report lists - #7362
Merged
Merged
Conversation
The Dutch catalog lacked a row for 1,813 of the status and error messages that the untranslated report finds in the sources, so the status bar showed those messages in English. - nl.tsv gains 1,813 `@msg` rows: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. The translations are VectorCraft's own, written from the English meaning with the catalog's conventions and its existing feature names. Placeholders, parameter names, command ids and literal values stay as the English writes them. - The untranslated report lists 41 Dutch messages after the change: the composite font errors, the justification spacing error and the `connect` end error, which open storytold#7211, storytold#7116 and storytold#7330 translate, and three unknown-parameter and range errors that open storytold#7353 rewrites so that a catalog row can match them. Menu strings, `tl!` literals and undo labels are unchanged. - The row for `{k} has control characters{_1}` does not match the message for a multi-line File Info field, where the last placeholder is empty. - docs/localization-parity.md's Dutch row and a line in docs/target-app-parity.md give the new counts.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
Member
|
Approved, but it conflicts with main after this batch of merges (doc status lines and catalog rows). Could you merge current main? It will go in once the new head is green. |
Contributor
Author
|
@bflatastic Merged main in (1d8c38e). |
3 of 4 tasks
3 of 4 tasks
Ten nl rows translated the field names inside [subpath, anchor], [x, y, width, height] and [width, height], which a command reads only in English. They now keep the English names, as the other catalogs do.
Contributor
Author
|
@bflatastic Merged current main again (5eb428f) and the Dutch rows now keep the bracketed field names in English (55595f0). |
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
bflatastic
pushed a commit
that referenced
this pull request
Nov 14, 2026
Adds a Dutch @msg row for each message in the untranslated report's "messages, all 23 languages checked" list that neither main nor an open pull request translates: 3D and Revolve errors, image export, color profiles, swatch exchange files and color books, script regular expressions, the `index` whole-number check, and DXF and DWG files. Placeholders, backticked names, parameter names and command ids stay as the English writes them. The shared list drops from 168 to 53 messages; the other 53 have Dutch rows in open pull requests #7211, #7378, #7434 and #7362.
bflatastic
pushed a commit
that referenced
this pull request
Nov 15, 2026
…usals
No complete-message catalog had a row for "a linked JavaScript file is
outside the read roots" (an SVG or SVGZ export or save of a document
that links a script outside the read roots) or for "the art of a graph
design in a graph series is drawn again from the design: edit the
design to change it" (an appearance edit of only that art), so the
status bar showed both in English. "the library's file is outside the
read roots" (Copy to User Defined) and "{file} names more than one
linked JavaScript file" (svgInteractivity.removeFile) had no row in ca,
el, fi, hi, ka and vi.
- Add the two refusals to 20 complete-message catalogs and the two
siblings to ca, el, fi, hi, ka and vi (52 rows), next to each
catalog's read-root and graph-design link rows, using their terms.
The nl, sv and tr rows and the other catalogs' sibling rows are in
#7362, #7370, #7359, #7355, #7316, #7307, #7354, #7314, #7350, #7337
and #7352.
- Add a test that checks each reason's row in every complete-message
catalog that has one (translated, keeps `{file}`, and shown inside
the invalid-parameters error of the command that returns it), and
requires at least one catalog to have a row for each reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Dutch (
nl) is inCOMPLETE_MESSAGES(crates/ui-egui/src/i18n/tests.rs), but onmainat71cef8ac8d,i18n::tests::untranslated_reportlisted 1,854 status and error messages with no Dutch row: 448 under "every language" and 1,406 for Dutch alone. With the interface in Dutch, those messages showed in English. Czech is #7355 and Japanese is #7314.crates/ui-egui/src/i18n/nl.tsvgains 1,813@msgrows, in one block under a comment: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. Existing rows are unchanged.true,falseandnullare kept exactly as the English writes them.nl.tsvare left out, so the catalog stays consistent when they merge (bundled_catalogs_are_consistentrejects a second row for the same key). No other new row repeats a key inmain'snl.tsvor a row that another open pull request adds to it.unknown parameter `{within}{key}`; {why},unknown parameter `{within}settings.{format}`; {why}and{name} must be {lo}–{hi}{unit} (got {v}).Template::parseincrates/ui-egui/src/i18n/catalog.rscannot match a row with two placeholders in a row, and open i18n: messages with values side by side can be translated #7353 rewrites these messages so that a catalog row can match them.docs/localization-parity.mdnow gives the catalog's counts: 3,447@msgand 48@msgpluralrows.docs/target-app-parity.mdhas one line for the change under "Evidence: what ships today, by area".Menu strings (50),
tl!literals (35) and undo labels (11) that only Dutch lacks are unchanged. No other catalog changes.One of the 1,813 rows is in the file and is counted by the report, but does not yet put its message into Dutch: the row for
{k} has control characters{_1}does not match the message for a multi-line File Info field. Its last placeholder is empty there (crates/engine/src/cmd/fileinfo.rs), and the last placeholder of a row never matches empty text.How it was tested
No new test: the change adds catalog rows only.
bundled_catalogs_are_consistentand the other i18n tests check every new row for TSV parsing, duplicate keys, placeholder agreement, double-quoted values, bare literals, backticked names and command ids.Untranslated report (
cargo test -p vectorcraft-ui-egui --lib i18n -- --nocapture), onmainat71cef8ac8d:nland 448 under "every language".f3d04df7b8: 41 Dutch messages missing, 3 undernland 38 under "every language". 38 are the messages left out for i18n: translate the composite font errors in the complete-message languages #7211, i18n: the justification order error is translated in every complete catalog #7116 and Blob Brush: path.blob rejects invalid fidelity, angle and roundness #7330, and 3 are the messages i18n: messages with values side by side can be translated #7353 rewrites.Focused checks on Linux. The branch is one commit on
mainat71cef8ac8dand merges cleanly with it. It conflicts with open #7315 indocs/localization-parity.md, and with open #7352 and #7354 indocs/target-app-parity.md.cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo test -p vectorcraft-ui-egui --lib i18n: 111 passed, 0 failed.cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.