Repository navigation
i18n: Italian translates 1,802 more status and error messages - #7315
Merged
Merged
Conversation
it is in COMPLETE_MESSAGES, but the untranslated report listed 1,842 status and error messages with no Italian row, so with the interface in Italian those messages showed in English. - it.tsv gains 1,802 `@msg` rows. The translations are VectorCraft's own, written from the English meaning with the catalog's terms, and await native review. Placeholders, backticked names, command ids, double-quoted values and bare true, false and null stay as the English writes them. - The untranslated report now lists 40 Italian messages. 38 of those keys get Italian rows from open pull requests 7211, 7214 and 7116, so they are left out here. Menu strings, `tl!` literals, undo labels and swatch names are unchanged. - The Italian row of docs/localization-parity.md gives the catalog's current counts, and docs/target-app-parity.md has a line for the change.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
Merged
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Italian (
it) is inCOMPLETE_MESSAGES(crates/ui-egui/src/i18n/tests.rs), but onmainat4558196e1,i18n::tests::untranslated_reportlisted 1,842 status and error messages with no Italian row: 436 under "every language" and 1,406 for Italian alone. With the interface in Italian, those messages showed in English.crates/ui-egui/src/i18n/it.tsvgains 1,802@msgrows, in one block after the catalog's last row. Existing rows are unchanged.true,falseandnullare kept exactly as the English writes them.bundled_catalogs_are_consistentonce both merged. The other two are left for a separate change.docs/localization-parity.mdnow gives the catalog's counts: 8,757 rows, 3,422 of them@msgand 48@msgplural.docs/target-app-parity.mdhas one line for the change.Menu strings (47),
tl!literals (26), undo labels (11) and swatch names (45) that Italian still lacks are unchanged, and no other catalog changes.How it was tested
No new test: the change adds catalog rows only.
bundled_catalogs_are_consistentand the other i18n tests check every new row for TSV parsing, duplicate keys, placeholder agreement, kept parameter names, backticked names, double-quoted values, bare literals and command ids.Untranslated report (
cargo test -p vectorcraft-ui-egui --lib i18n::tests::untranslated_report -- --nocapture), onmainat4558196e1:Focused checks on the catalog change, on Linux; only the wording of the
docs/localization-parity.mdrow changed after they ran. The branch is one commit onmainat4558196e16and merges cleanly with it. It conflicts with open #7298 indocs/target-app-parity.md(both add a line after the Hindi terms line). It conflicts with open #6883 indocs/target-app-parity.md. It conflicts with open #7282 incrates/ui-egui/src/i18n/it.tsv. It conflicts with open #7051 incrates/ui-egui/src/i18n/it.tsv.cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo test -p vectorcraft-ui-egui --lib i18n: 107 passed, 0 failed.cargo xtask brands,layers(30 crates) andassets(337 files).cargo xtask ciruns in this pull request's CI.cargo xtask cipassed in this pull request's CI run on71fab5bd81: https://github.com/storytold/vectorcraft/actions/runs/43527723156/job/132237519425Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.