Repository navigation
Cutting Tools: Banner Hems and Grommets marks a banner's hems and grommet holes - #7282
Merged
Merged
Conversation
…mmet holes Object › Plug-ins › Cutting Tools › Banner Hems and Grommets… (`addon.cutting.banner`) marks where a printed banner is hemmed and where its grommets go. The banner is the bounds of the selected art, or each artboard when nothing is selected. On each chosen side the command adds a hem line a set depth inside the edge (1 in by default) and grommet marks a set inset inside it (0.5 in): one at each end of the side and the rest spread evenly, as few as keep them at most a set spacing apart (24 in). A corner that two chosen sides share gets one grommet. Each grommet mark is a circle (27 pt by default) with a cross through its center. The marks are stroked in a chosen swatch ([Registration] by default) with no fill, in one group named Banner Marks per banner on top of the current layer, selected, as one undo step. While a clip group is edited in isolation, the group goes outside the outermost clip group, as Weed Box and Lines does. The command refuses every side off, no hem and no grommets, and bad params with a message. It also refuses a hem or inset that reaches the far edge of the banner when one of two opposite sides is chosen, or that meets the marks of the opposite side when both are chosen, an inset of more than half a chosen side's length, and more than 100000 grommets. The dialog has Preview. The grommets' distance from the edge is `grommetInset`, so the dialog shows it as Grommet Inset with its own catalog rows. The new Diameter catalog rows also translate the Diameter field of the `shape.flare` command dialog, which had no rows. Docs: docs/mcp.md (Cutting Tools add-on), docs/target-app-parity.md and ROADMAP.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 13, 2026
Merged
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds Object › Plug-ins › Cutting Tools › Banner Hems and Grommets… (
addon.cutting.banner), which marks where a printed banner is hemmed (hem) and where its grommets go (grommet). The ranges, defaults and rules are VectorCraft's own.allArtboards).top,right,bottom,left) the command draws a hem lineheminside the edge (72 pt, 1 in, by default; 0 leaves it out).grommetson, each chosen side gets grommet marksgrommetInsetinside the edge (36 pt by default): one at each end and the rest spread evenly, as few as keep them at mostspacingapart (1728 pt, 24 in). A shared corner gets one grommet. Each mark is a circle (diameter, 27 pt) with a cross through its center.swatch([Registration] by default) with no fill, in one group named Banner Marks per banner, on top of the current layer (outside the outermost clip group while one is edited in isolation, as Weed Box and Lines does), selected, as one undo step.shape.flarecommand dialog, which had no rows.Docs:
docs/mcp.md(Cutting Tools add-on),docs/target-app-parity.mdand ROADMAP.How it was tested
Base
630ef6f549. Run on Linux:cargo test -p vectorcraft-engine: 6992 passed, 3 ignored, in 21 test binaries, including the 11 tests incmd::addons::cutting::banner::testsandcommand_sweepwith banner rows added.cargo test -p vectorcraft-ui-egui: 4519 passed, 2 ignored, in 7 test binaries, includingbanner_hems_and_grommets_previews_cancels_and_runs_on_ok(menu, dialog fields in English and German, Preview, Cancel, OK as one undo step).cargo clippy -p vectorcraft-engine -p vectorcraft-ui-egui --all-targets -- -D warnings,cargo fmt --all -- --checkandcargo xtask brands: clean.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.