Repository navigation
Conversation
…ntranslated report lists
The Spanish catalog lacked a row for 1,842 of the status and error
messages that the untranslated report finds in the sources, so the
status bar showed those messages in English.
- es.tsv gains 1,840 `@msg` rows: the errors of commands and their
parameter checks, scripts, file import and export, effects and
plug-ins. The translations are VectorCraft's own, written from the
English meaning in the catalog's neutral Spanish and its existing
feature names. Placeholders, backticked names, quoted values, bare
true, false and null, and command ids stay as the English writes
them.
- Two messages have no row and are still shown in English:
"unknown parameter `{within}{key}`; {why}" and
"{name} must be {lo}–{hi}{unit} (got {v})". Each has two
placeholders in a row, and the catalog does not load a row for such
a message. The untranslated report still lists both for Spanish.
- Menu strings, `tl!` literals, undo labels and swatch names are
unchanged.
- A test checks that Spanish shows rendered messages from the script
engine, the parameter checks, the importers, the 3D effects and the
trim add-on in Spanish with their values kept.
- The Spanish row of docs/localization-parity.md gives the catalog's
current message counts.
Docs: docs/target-app-parity.md, docs/localization-parity.md.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…torytold#7116 add Open storytold#7211, storytold#7214 and storytold#7116 add Spanish rows for 38 of the messages this branch translates. A second row for the same key fails bundled_catalogs_are_consistent once both sides merge, so this branch drops its 38 rows and leaves those messages to the other pull requests. The Spanish lines in docs/localization-parity.md and docs/target-app-parity.md give the new counts.
dotCooCoo
changed the title
This was referenced Nov 14, 2026
bflatastic
pushed a commit
that referenced
this pull request
Nov 15, 2026
…usals
No complete-message catalog had a row for "a linked JavaScript file is
outside the read roots" (an SVG or SVGZ export or save of a document
that links a script outside the read roots) or for "the art of a graph
design in a graph series is drawn again from the design: edit the
design to change it" (an appearance edit of only that art), so the
status bar showed both in English. "the library's file is outside the
read roots" (Copy to User Defined) and "{file} names more than one
linked JavaScript file" (svgInteractivity.removeFile) had no row in ca,
el, fi, hi, ka and vi.
- Add the two refusals to 20 complete-message catalogs and the two
siblings to ca, el, fi, hi, ka and vi (52 rows), next to each
catalog's read-root and graph-design link rows, using their terms.
The nl, sv and tr rows and the other catalogs' sibling rows are in
#7362, #7370, #7359, #7355, #7316, #7307, #7354, #7314, #7350, #7337
and #7352.
- Add a test that checks each reason's row in every complete-message
catalog that has one (translated, keeps `{file}`, and shown inside
the invalid-parameters error of the command that returns it), and
requires at least one catalog to have a row for each reason.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Spanish catalog had no row for 1,842 of the status and error messages that
i18n::tests::untranslated_reportfinds in the sources. A message without a row is shown in English, so the status bar showed those messages in English in a Spanish interface.crates/ui-egui/src/i18n/es.tsvgets an@msgrow for 1,802 of the 1,842 messages, at the end of the file: the errors of commands and their parameter checks, scripts, file import and export, effects and plug-ins, including theaddon.pathtools.trimerrors, thewarichuLinesandwarichuAlignchecks and the Warichu Settings dialog's field errors. Withmainmerged in, the catalog goes from 1,628 to 3,430@msgrows and has 48@msgpluralrows. No existing row changes.bundled_catalogs_are_consistentrejects a second row for the same key). The 2 keys this branch shares with open Compound Shapes #817 stay until it merges.true,falseandnullunchanged. Only the prose around them is Spanish.docs/target-app-parity.mdhas one line for it under "Evidence: what ships today".docs/localization-parity.mdnow gives the catalog's message counts: 3,430@msgand 48@msgpluralrows, counted 2026-11-13.This pull request changes only the Spanish
@msgrows. The counts of menu strings (47),tl!strings (24), undo labels (11) and swatch names (45) that Spanish still lacks are unchanged, and no other language's catalog is edited. Messages stay in English in command replies and MCP data; the status bar translates a message when it draws it.Two of the 1,842 messages have no Spanish row and still show in English:
unknown parameter `{within}{key}`; {why}and{name} must be {lo}–{hi}{unit} (got {v}).Template::parseincrates/ui-egui/src/i18n/catalog.rsreturnsNonefor a message with two placeholders in a row, and the catalog then does not load the row, so a row for either would not be used. The report still lists both for Spanish.How it was tested
New test in
crates/ui-egui/src/i18n/tests.rs:spanish_translates_engine_import_and_parameter_messages: Spanish shows eight rendered messages in Spanish with their values, names and command ids kept (a parameter range check, aJSON.parseerror with its offset, an unknown mode with its choices, the password-protected Word document error, a 3D mapping error with its object number, a missing custom arrowhead, thewarichuLinescheck and a trim error). With the trim row removed, it fails at that case with the English text.The existing i18n tests read the new rows too.
bundled_catalogs_are_consistentchecks every row's placeholders against its English and rejects duplicate keys, andtranslations_keep_the_backticked_names_of_their_english,translated_messages_keep_the_double_quoted_values_of_their_english,translated_messages_keep_the_bare_literals_of_their_english,translated_messages_keep_the_keys_and_values_their_english_namesandtranslated_messages_keep_the_command_ids_their_english_namescheck the names and values a row must keep.untranslated_reportprints the missing rows and does not fail on them, so its output is the evidence of the count. On the heade3ae1fb79, withmainmerged in:messages (3)and the section for all 23 complete-message languages listsmessages (47). 38 of the 50 are the rows left out for i18n: translate the composite font errors in the complete-message languages #7211, i18n: the "select a path" reason is translated in every complete-message language #7214 and i18n: the justification order error is translated in every complete catalog #7116, and two are the messages above. The Spanish section's other lines are unchanged:menu strings (47),tl! strings (24),undo labels (11),swatch names (45).Focused checks on Linux. It conflicts with open #7282 in
crates/ui-egui/src/i18n/es.tsv. It conflicts with open #7051 incrates/ui-egui/src/i18n/es.tsv. It conflicts with open #7134 indocs/localization-parity.md. It conflicts with open #7206 indocs/localization-parity.md. It conflicts with open #7298 indocs/target-app-parity.md. It conflicts with open #6883 indocs/target-app-parity.md.cargo test -p vectorcraft-ui-egui --lib i18n: 110 passed, 0 failed, 0 ignored, on the heade3ae1fb79.cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo xtask brands,cargo xtask layers(30 crates) andcargo xtask assets(337 files)cargo xtask ciruns in this pull request's CI.cargo xtask cipassed in this pull request's CI run one3ae1fb79f: https://github.com/storytold/vectorcraft/actions/runs/43531290077/job/132249491010Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.