Repository navigation
i18n: Korean has a row for 1,813 of the messages the untranslated report lists - #7350
Merged
Merged
Conversation
The Korean catalog lacked a row for 1,852 of the status and error messages that the untranslated report finds in the sources, so the status bar showed those messages in English. ko.tsv now has an @msg row for 1,813 of them: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. The other 39 are messages that open storytold#7211, storytold#7214, storytold#7116 and storytold#7330 also translate in ko.tsv. They are left out so the catalog has no duplicate key when those pull requests merge. The rows keep every placeholder, parameter name, command id and literal value of the English, and use the feature names the catalog already has. The report's Korean menu strings, tl! strings, undo labels and swatch names are unchanged. Docs: docs/localization-parity.md, docs/target-app-parity.md.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 of 4 tasks
3 of 4 tasks
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
bflatastic
pushed a commit
that referenced
this pull request
Nov 15, 2026
…usals
No complete-message catalog had a row for "a linked JavaScript file is
outside the read roots" (an SVG or SVGZ export or save of a document
that links a script outside the read roots) or for "the art of a graph
design in a graph series is drawn again from the design: edit the
design to change it" (an appearance edit of only that art), so the
status bar showed both in English. "the library's file is outside the
read roots" (Copy to User Defined) and "{file} names more than one
linked JavaScript file" (svgInteractivity.removeFile) had no row in ca,
el, fi, hi, ka and vi.
- Add the two refusals to 20 complete-message catalogs and the two
siblings to ca, el, fi, hi, ka and vi (52 rows), next to each
catalog's read-root and graph-design link rows, using their terms.
The nl, sv and tr rows and the other catalogs' sibling rows are in
#7362, #7370, #7359, #7355, #7316, #7307, #7354, #7314, #7350, #7337
and #7352.
- Add a test that checks each reason's row in every complete-message
catalog that has one (translated, keeps `{file}`, and shown inside
the invalid-parameters error of the command that returns it), and
requires at least one catalog to have a row for each reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Korean catalog had no row for 1,852 of the status and error messages that
i18n::tests::untranslated_reportfinds in the sources. A message without a row is shown in English, so the status bar showed those messages in English in a Korean interface.crates/ui-egui/src/i18n/ko.tsvgets one@msgrow for each of 1,813 of those messages, under one comment line at the end of the file: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. The catalog now has 3,438@msgrows (1,625 before) and 48@msgpluralrows. No existing row is changed.ko.tsvare left out, so the catalog stays consistent when they merge (bundled_catalogs_are_consistentrejects a second row for the same key). No other row duplicates a key inmain'sko.tsvor a row that another open pull request adds to it.{e},{name},{MAX_CSV_BYTES}), doubled brace, parameter name, command id, property and method name (Boolean.prototype.{name},JSON.parse) and quoted literal value unchanged. Only the prose around them is Korean.`{key}`은(는),`{_1}`을(를)).docs/target-app-parity.mdhas one line for it under "Evidence: what ships today".docs/localization-parity.mdnow gives the catalog's message counts: 3,438@msgand 48@msgpluralrows, counted 2026-11-13.This pull request changes only the Korean
@msgrows. The counts of menu strings (47),tl!strings (26), undo labels (11) and swatch names (45) that Korean still lacks are unchanged, and no other language's catalog is edited.Three of the 1,813 rows are in the file and are counted by the report, but do not yet put their message into Korean:
Template::parseincrates/ui-egui/src/i18n/catalog.rsreturnsNonefor a message with two placeholders in a row, so the catalog does not load the rows forunknown parameter `{within}{key}`; {why}and{name} must be {lo}–{hi}{unit} (got {v}).{k} has control characters{_1}does not match the message for a multi-line File Info field. Its last placeholder is empty there (crates/engine/src/cmd/fileinfo.rs), and the last placeholder of a row never matches empty text.How it was tested
No test is added: the change is catalog data, and the existing i18n tests read it.
bundled_catalogs_are_consistentchecks every row's placeholders against its English and rejects duplicate keys, andtranslations_keep_the_backticked_names_of_their_english,translated_messages_keep_the_double_quoted_values_of_their_english,translated_messages_keep_the_bare_literals_of_their_english,translated_messages_keep_the_keys_and_values_their_english_namesandtranslated_messages_keep_the_command_ids_their_english_namescheck the names and values a row must keep.untranslated_reportprints the missing rows and does not fail on them, so its output is the evidence of the count:mainat0b29b2b1f6: 1,852 Korean messages missing (1,406 under "ko" and 446 under "every language"); 43,084 missing rows in all.3b6f0f8051: 39 Korean messages missing (3 under "ko" and 36 under "every language"), all of them the messages left out for i18n: translate the composite font errors in the complete-message languages #7211, i18n: the "select a path" reason is translated in every complete-message language #7214, i18n: the justification order error is translated in every complete catalog #7116 and Blob Brush: path.blob rejects invalid fidelity, angle and roundness #7330; 41,271 missing rows in all. Korean'smenu strings (47),tl! strings (26),undo labels (11)andswatch names (45)are unchanged.Focused checks on Linux. The branch is one commit on
mainat0b29b2b1f6and merges cleanly with it. It conflicts with open #7309 indocs/localization-parity.mdanddocs/target-app-parity.md. It conflicts with open #7134 indocs/localization-parity.md.cargo test -p vectorcraft-ui-egui --lib i18n: 110 passed, 0 failed, 0 ignored, on the head3b6f0f8051.cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo xtask brands,cargo xtask layers(30 crates) andcargo xtask assets(337 files)cargo xtask ciruns in this pull request's CI.cargo xtask cipassed in this pull request's CI run on3b6f0f8051: https://github.com/storytold/vectorcraft/actions/runs/43536691532/job/132267315646Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.