Repository navigation
i18n: German has a row for 1,804 of the messages the untranslated report lists - #7309
Merged
Merged
Conversation
The German catalog lacked a row for 1,842 of the status and error messages that the untranslated report finds in the sources, so the status bar showed those messages in English. - de.tsv gains 1,842 `@msg` rows: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. The translations are VectorCraft's own, written from the English meaning with the catalog's conventions and its existing feature names. Placeholders, parameter names, command ids and literal values stay as the English writes them. - The untranslated report now lists no German messages. Menu strings, `tl!` literals, undo labels and swatch names are unchanged. - Two of the messages have two placeholders in a row. The catalog does not load such a row, so those two are still shown in English. - The German row of docs/localization-parity.md gives the catalog's current message counts. Docs: docs/target-app-parity.md, docs/localization-parity.md.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
4 tasks done
…torytold#7116 add Open storytold#7211, storytold#7214 and storytold#7116 add German rows for 38 of the messages this branch translates. A second row for the same key fails bundled_catalogs_are_consistent once both sides merge, so this branch drops its 38 rows and leaves those messages to the other pull requests. The German lines in docs/localization-parity.md and docs/target-app-parity.md give the new counts.
This was referenced Nov 14, 2026
Merged
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The German catalog had no row for 1,842 of the status and error messages that
i18n::tests::untranslated_reportfinds in the sources. A message without a row is shown in English, so the status bar showed those messages in English in a German interface.crates/ui-egui/src/i18n/de.tsvgets one@msgrow for each of 1,804 of those messages, under one comment line at the end of the file: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. The catalog now has 3,433@msgrows and 48@msgpluralrows.bundled_catalogs_are_consistentrejects a second row for the same key).{e},{name},{MAX_CSV_BYTES}), doubled brace, parameter name, command id, property and method name (Boolean.prototype.{name},JSON.parse) and quoted literal value unchanged. Only the prose around them is German.„ “quotation marks, the decimal comma,100 %, the initial-letter case of the English) and the feature names the catalog already uses, such as Zeichenfläche, Farbfelder, Kontur, Freiformverlauf, Tonwert and Vollfarbe. The translations are VectorCraft's own, written from the meaning of its English messages.docs/target-app-parity.mdhas one line for it under "Evidence: what ships today".docs/localization-parity.mdnow gives the catalog's message counts: 3,433@msgand 48@msgpluralrows, counted 2026-11-13.This pull request changes only the German
@msgrows. The counts of menu strings (47),tl!strings (26), undo labels (11) and swatch names (45) that German still lacks are unchanged, and no other language's catalog is edited. Messages stay in English in command replies and MCP data; the status bar translates a message when it draws it.Two of the messages with rows still show in English.
Template::parseincrates/ui-egui/src/i18n/catalog.rsreturnsNonefor a message with two placeholders in a row, and the catalog then does not load the row. The rows forunknown parameter `{within}{key}`; {why}and{name} must be {lo}–{hi}{unit} (got {v})are in the file and are counted by the report, but the status bar does not use them.How it was tested
No test is added: the change is catalog data, and the existing i18n tests read it.
bundled_catalogs_are_consistentchecks every row's placeholders against its English and rejects duplicate keys, andtranslations_keep_the_backticked_names_of_their_english,translated_messages_keep_the_double_quoted_values_of_their_english,translated_messages_keep_the_bare_literals_of_their_english,translated_messages_keep_the_keys_and_values_their_english_namesandtranslated_messages_keep_the_command_ids_their_english_namescheck the names and values a row must keep.untranslated_reportprints the missing rows and does not fail on them, so its output is the evidence of the count. Onmainat4558196e16a, before the 38 rows were left out:messagesline. Its other lines are unchanged:menu strings (47),tl! strings (26),undo labels (11),swatch names (45).messages (1842).On the head
9a355b1a7, withmainmerged in, the report lists 48 German messages, 46 of them under "every language". 38 of the 48 are the rows left out for #7211, #7214 and #7116.Focused checks on Linux. It conflicts with open #7282 in
crates/ui-egui/src/i18n/de.tsv. It conflicts with open #7051 incrates/ui-egui/src/i18n/de.tsv. It conflicts with open #7134 indocs/localization-parity.md.cargo test -p vectorcraft-ui-egui --lib i18n: 109 passed, 0 failed, 0 ignored, on the head9a355b1a7.cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo xtask brands,cargo xtask layers(30 crates) andcargo xtask assets(337 files)cargo xtask ciruns in this pull request's CI.cargo xtask cipassed in this pull request's CI run on9a355b1a75: https://github.com/storytold/vectorcraft/actions/runs/43530988944/job/132248477138Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.