Skip to content

i18n: German has a row for 1,804 of the messages the untranslated report lists - #7309

Merged
bflatastic merged 3 commits into
storytold:mainfrom
dotCooCoo:fix/de-message-rows
Nov 14, 2026
Merged

bflatastic merged 3 commits into
storytold:mainfrom
dotCooCoo:fix/de-message-rows

Conversation

@dotCooCoo

@dotCooCoo dotCooCoo commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What and why

The German catalog had no row for 1,842 of the status and error messages that i18n::tests::untranslated_report finds in the sources. A message without a row is shown in English, so the status bar showed those messages in English in a German interface.

  • crates/ui-egui/src/i18n/de.tsv gets one @msg row for each of 1,804 of those messages, under one comment line at the end of the file: the errors of commands and their parameter checks, scripts, file import and export, printing and plug-ins. The catalog now has 3,433 @msg rows and 48 @msgplural rows.
  • The 38 rows that open i18n: translate the composite font errors in the complete-message languages #7211, i18n: the "select a path" reason is translated in every complete-message language #7214 and i18n: the justification order error is translated in every complete catalog #7116 add are left out, so the catalogs stay consistent when they merge (bundled_catalogs_are_consistent rejects a second row for the same key).
  • Each row keeps the English key exactly, with every placeholder ({e}, {name}, {MAX_CSV_BYTES}), doubled brace, parameter name, command id, property and method name (Boolean.prototype.{name}, JSON.parse) and quoted literal value unchanged. Only the prose around them is German.
  • The rows follow the conventions in the catalog's header (formal address, „ “ quotation marks, the decimal comma, 100 %, the initial-letter case of the English) and the feature names the catalog already uses, such as Zeichenfläche, Farbfelder, Kontur, Freiformverlauf, Tonwert and Vollfarbe. The translations are VectorCraft's own, written from the meaning of its English messages.
  • docs/target-app-parity.md has one line for it under "Evidence: what ships today".
  • The German row of docs/localization-parity.md now gives the catalog's message counts: 3,433 @msg and 48 @msgplural rows, counted 2026-11-13.

This pull request changes only the German @msg rows. The counts of menu strings (47), tl! strings (26), undo labels (11) and swatch names (45) that German still lacks are unchanged, and no other language's catalog is edited. Messages stay in English in command replies and MCP data; the status bar translates a message when it draws it.

Two of the messages with rows still show in English. Template::parse in crates/ui-egui/src/i18n/catalog.rs returns None for a message with two placeholders in a row, and the catalog then does not load the row. The rows for unknown parameter `{within}{key}`; {why} and {name} must be {lo}–{hi}{unit} (got {v}) are in the file and are counted by the report, but the status bar does not use them.

How it was tested

No test is added: the change is catalog data, and the existing i18n tests read it. bundled_catalogs_are_consistent checks every row's placeholders against its English and rejects duplicate keys, and translations_keep_the_backticked_names_of_their_english, translated_messages_keep_the_double_quoted_values_of_their_english, translated_messages_keep_the_bare_literals_of_their_english, translated_messages_keep_the_keys_and_values_their_english_names and translated_messages_keep_the_command_ids_their_english_names check the names and values a row must keep.

untranslated_report prints the missing rows and does not fail on them, so its output is the evidence of the count. On main at 4558196e16a, before the 38 rows were left out:

  • The German section has no messages line. Its other lines are unchanged: menu strings (47), tl! strings (26), undo labels (11), swatch names (45).
  • In the same run, a language without these rows, such as Czech, lists messages (1842).
  • The 1,842 keys added are the same keys the report lists for a language without these rows, compared as sorted lists.

On the head 9a355b1a7, with main merged in, the report lists 48 German messages, 46 of them under "every language". 38 of the 48 are the rows left out for #7211, #7214 and #7116.

Focused checks on Linux. It conflicts with open #7282 in crates/ui-egui/src/i18n/de.tsv. It conflicts with open #7051 in crates/ui-egui/src/i18n/de.tsv. It conflicts with open #7134 in docs/localization-parity.md.

  • cargo test -p vectorcraft-ui-egui --lib i18n: 109 passed, 0 failed, 0 ignored, on the head 9a355b1a7.
  • cargo fmt --all -- --check
  • cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings
  • cargo check --workspace --tests
  • cargo xtask brands, cargo xtask layers (30 crates) and cargo xtask assets (337 files)
  • cargo xtask ci runs in this pull request's CI.

cargo xtask ci passed in this pull request's CI run on 9a355b1a75: https://github.com/storytold/vectorcraft/actions/runs/43530988944/job/132248477138

Checklist

  • cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
  • No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
    unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
    messages. Errors are returned as Result and shown to the user
    (why and how).
  • Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
  • Every new asset has a row in ASSETS.md.

The German catalog lacked a row for 1,842 of the status and error
messages that the untranslated report finds in the sources, so the
status bar showed those messages in English.

- de.tsv gains 1,842 `@msg` rows: the errors of commands and their
  parameter checks, scripts, file import and export, printing and
  plug-ins. The translations are VectorCraft's own, written from the
  English meaning with the catalog's conventions and its existing
  feature names. Placeholders, parameter names, command ids and
  literal values stay as the English writes them.
- The untranslated report now lists no German messages. Menu strings,
  `tl!` literals, undo labels and swatch names are unchanged.
- Two of the messages have two placeholders in a row. The catalog does
  not load such a row, so those two are still shown in English.
- The German row of docs/localization-parity.md gives the catalog's
  current message counts.

Docs: docs/target-app-parity.md, docs/localization-parity.md.
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 28bd9c9 and 9a355b1.

Files ignored due to path filters: 1

  • crates/ui-egui/src/i18n/de.tsv is excluded by !**/*.tsv
Files selected for processing: 2

  • docs/localization-parity.md
  • docs/target-app-parity.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…torytold#7116 add

Open storytold#7211, storytold#7214 and storytold#7116 add German rows for 38 of the messages this
branch translates. A second row for the same key fails
bundled_catalogs_are_consistent once both sides merge, so this branch
drops its 38 rows and leaves those messages to the other pull requests.
The German lines in docs/localization-parity.md and
docs/target-app-parity.md give the new counts.
@dotCooCoo dotCooCoo changed the title i18n: German has a row for every message the untranslated report lists i18n: German has a row for 1,804 of the messages the untranslated report lists Nov 13, 2026
@bflatastic
bflatastic merged commit b0a2dfd into storytold:main Nov 14, 2026
7 checks passed
@bflatastic

Copy link
Copy Markdown
Member

Merged, thanks @dotCooCoo! It passed its CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants