Repository navigation
refactor: move currency and base64 helpers to core - #1897
Open
gabrielseco wants to merge 2 commits into
Open
gabrielseco wants to merge 2 commits into
gabrielseco wants to merge 2 commits into
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (313 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
This was referenced Nov 5, 2026
remotecom
marked this pull request as ready for review
November 6, 2026 09:48
# Conflicts: # packages/core/src/index.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves two small helpers, a currency formatter and a base64 data URI helper, into the private core package. Behavior and the public API of
@remoteoss/remote-flowsare unchanged.Why
Phase 2 of the Angular support plan (#1833). Both are plain functions that any framework needs, and the Angular spike already uses the second. Stacked on #1896.
What changed
Toggle details
packages/core/src/format.tswithformatCurrencyandclearBase64Data, moved as they were.src/lib/utils.tsre-exports them from core, so every existing import keeps working.stripHtmlandprettifyFormValues(which uses it) need the browser'sDOMParser, the sanitizers need DOMPurify, andtransformYupErrorsIntoObjectneeds yup.src/index.tsx.Screenshots
N/A
Related Resources
Testing
The same checks CI runs pass locally: the lint command (exit 0),
type-check(both configs) and the full vitest suite (134 files, 1729 tests). No test changes.example/app in a browserNote
Low Risk
Mechanical relocation with re-exports preserving the previous API; no logic or security-sensitive behavior changes.
Overview
Moves
formatCurrencyandclearBase64Datafromsrc/lib/utils.tsintopackages/core/src/format.tsand exports them from@remoteoss/remote-flows-core.Keeps the same behavior:
src/lib/utils.tsnow re-exports those two from core, so existing imports from the app layer keep working without a breaking change to the flows package’s surface for consumers that usedutils.This supports sharing the helpers outside React (e.g. Angular) without duplicating logic.
Reviewed by Cursor Bugbot for commit f47faf3. Bugbot is set up for automated code reviews on this repo. Configure here.