Repository navigation
chore: add a pnpm workspace with an empty private core package - #1887
Open
gabrielseco wants to merge 1 commit into
Open
gabrielseco wants to merge 1 commit into
gabrielseco wants to merge 1 commit into
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (315 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
gabrielseco
marked this pull request as ready for review
November 5, 2026 14:42
This was referenced Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up the repo as a pnpm workspace with an empty, private
packages/corepackage. Nothing changes for people using@remoteoss/remote-flows.Why
First step of the Angular support plan (#1833, Phase 1). Later PRs move framework-neutral code into this package, and this one makes sure the workspace and build setup are ready before any code moves.
What changed
Toggle details
pnpm-workspace.yamlnow listspackages/*.example/has its own workspace file and is not part of this one.packages/core(@remoteoss/remote-flows-core): private, version0.0.0, exports an empty module from source.package.jsonhas it as aworkspace:*dev dependency, so tsdown bundles it into the React build and it is never published or listed as a runtime dependency.tsconfig.jsonincludespackagesin the type-check.exportsmap,filesand dependencies of the published package are untouched..jsfiles. The.d.tsfiles differ only in generated chunk file names, which depend on the checkout path.Screenshots
N/A
Related Resources
Testing
N/A, no code behavior changes. CI covers the build, exports check, size check, type check and tests.
example/app in a browserNote
Low Risk
Infrastructure-only: workspace config, empty private package, and TypeScript include scope—no product behavior or published API changes.
Overview
Introduces a pnpm monorepo layout so framework-neutral code can live in a separate package ahead of the Angular work (#1833).
pnpm-workspace.yamlnow registerspackages/*. A new private workspace package@remoteoss/remote-flows-core(packages/core) exports an empty module from source. The root package lists it as aworkspace:*devDependency (not published or exposed on the public@remoteoss/remote-flowsAPI).tsconfig.jsontype-checkspackages, and the lockfile records the workspace link.No runtime or public export changes in this PR; later PRs are expected to move shared code into core and consume it from the React build.
Reviewed by Cursor Bugbot for commit c925dc0. Bugbot is set up for automated code reviews on this repo. Configure here.