Repository navigation
refactor: move plain form data types to core - #1889
Open
gabrielseco wants to merge 3 commits into
Open
gabrielseco wants to merge 3 commits into
gabrielseco wants to merge 3 commits into
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (317 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
2 tasks
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 90.27% | 90.32% | -0.05% | 🔴 |
| Statements | 90.15% | 90.20% | -0.05% | 🔴 |
| Functions | 89.16% | 89.16% | 0% | ⚪ |
| Branches | 81.84% | 81.94% | -0.09% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 5854 / 6485
- Coverage: 90.27%
- Change: -0.05% (-3 lines)
Statements Coverage
- Covered: 5923 / 6570
- Coverage: 90.15%
- Change: -0.05% (-3 statements)
Functions Coverage
- Covered: 1555 / 1744
- Coverage: 89.16%
- Change: 0% (0 functions)
Branches Coverage
- Covered: 3620 / 4423
- Coverage: 81.84%
- Change: -0.09% (-4 branches)
✅ Coverage check passed
This was referenced Nov 5, 2026
gabrielseco
marked this pull request as ready for review
November 6, 2026 08:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves five plain data types into the private core package. Behavior and the public API of
@remoteoss/remote-flowsare unchanged.Why
Phase 2 of the Angular support plan (#1833). The form helpers and the form engine can only move to core once the types they use are there, so the types go first. Stacked on #1888.
What changed
Toggle details
packages/core/src/types.tswith$TSFixMe,JSFFields,JSFFieldset,UploadedFileReferenceandField, moved as they were (including the existing docs onUploadedFileReference).src/types/remoteFlows.ts,src/types/fields.tsandsrc/flows/types.tsimport and re-export them, so every existing import path keeps working.$TSFixMeandUploadedFileReferenceare still exported fromsrc/index.tsx.JSFFieldstays where it is for now because it usesReactNode, yup'sAnySchemaand the component field types..d.tsfiles, and the public$TSFixMeandUploadedFileReferencedeclarations are inlined.Screenshots
N/A
Related Resources
Testing
Existing tests, unchanged:
pnpm run type-checkand the full vitest suite (132 files, 1726 tests) pass locally.example/app in a browserNote
Low Risk
Type-only refactor with re-exports preserving existing imports; no runtime or auth/data-path changes.
Overview
Centralizes five JSON-schema–related plain types (
$TSFixMe,JSFFields,JSFFieldset,UploadedFileReference,Field) in@remoteoss/remote-flows-corevia a newtypes.tsand barrel export frompackages/core/src/index.ts.App package keeps the same import paths by deleting the local definitions in
src/types/remoteFlows.ts,src/types/fields.ts, andsrc/flows/types.tsand re-exporting those symbols from core (including a trailing re-export block inremoteFlows.ts).UploadedFileReferencedocs move with the type into core.No runtime or public API surface change beyond types living in one place for upcoming shared form tooling.
Reviewed by Cursor Bugbot for commit dfed52c. Bugbot is set up for automated code reviews on this repo. Configure here.