Repository navigation
refactor: move money and nested value helpers to core - #1888
Open
gabrielseco wants to merge 2 commits into
Open
gabrielseco wants to merge 2 commits into
gabrielseco wants to merge 2 commits into
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (317 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 90.29% | 90.29% | 0% | ⚪ |
| Statements | 90.17% | 90.17% | 0% | ⚪ |
| Functions | 89.16% | 89.19% | -0.03% | 🔴 |
| Branches | 81.89% | 81.89% | 0% | ⚪ |
Detailed Breakdown
Lines Coverage
- Covered: 5855 / 6485
- Coverage: 90.29%
- Change: 0% (-21 lines)
Statements Coverage
- Covered: 5924 / 6570
- Coverage: 90.17%
- Change: 0% (-21 statements)
Functions Coverage
- Covered: 1555 / 1744
- Coverage: 89.16%
- Change: -0.03% (-5 functions)
Branches Coverage
- Covered: 3622 / 4423
- Coverage: 81.89%
- Change: 0% (-22 branches)
✅ Coverage check passed
This was referenced Nov 5, 2026
gabrielseco
marked this pull request as ready for review
November 6, 2026 08:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves four small, dependency-free helpers into the private core package. Behavior and the public API of
@remoteoss/remote-flowsare unchanged.Why
Phase 2 of the Angular support plan (#1833) moves framework-neutral code into core in small refactor PRs. These are the leaf helpers with no framework or heavy-library dependencies, so they are the safest first move, and they are the first real code to go through the core package.
Stacked on #1887.
What changed
Toggle details
packages/core/src/money.ts:round,convertToCents,convertFromCents, moved as they were.packages/core/src/object.ts:getNestedValue, moved as it was.src/components/form/utils.tsandsrc/lib/utils.tsimport and re-export them, so every existing import path keeps working.convertFromCentsis still exported fromsrc/index.tsx.getNestedValueandconvertFromCents); this removes that dependency for these functions..d.tsfiles, and the publicconvertFromCentsdeclaration is inlined.Screenshots
N/A
Related Resources
Testing
Existing tests, unchanged:
pnpm run type-checkand the full vitest suite (132 files, 1726 tests) pass locally.example/app in a browserNote
Low Risk
Mechanical move and re-export of existing helpers with no logic changes; risk is limited to build/import wiring for the new core package.
Overview
Centralizes shared money helpers (
round,convertToCents,convertFromCents) and object helpergetNestedValuein the@remoteoss/remote-flows-corepackage instead of defining them in app modules.Updates
src/components/form/utils.tsandsrc/lib/utils.tsto import these helpers from core and re-export them where needed, so existing consumer import paths and behavior stay the same while removing the prior local implementations and the cross-module dependency between those files for these functions.This is a structural refactor preparing framework-neutral utilities for reuse (e.g. Angular) with no intended API or runtime behavior change for
@remoteoss/remote-flowsconsumers.Reviewed by Cursor Bugbot for commit 400d93c. Bugbot is set up for automated code reviews on this repo. Configure here.