Skip to content

cv-utils: build for rocm - #1320

Draft
drbh wants to merge 2 commits into
mainfrom
cv-utils-rocm
Draft

drbh wants to merge 2 commits into
mainfrom
cv-utils-rocm

Conversation

@drbh

@drbh drbh commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

this pr adds a rocm build for cv-utils

same change as causal-conv1d in #1319: the rocm backend, rocm = "2.10" stable abi and a cpp-rocm kernel with the same sources and activation archs, and stable_utils.h picks the hip runtime under USE_ROCM. the kernels have no warp intrinsics and nms already uses 64 bit masks, so no kernel changes. the triton functions from #1182 run on rocm as is

built all rocm variants (rocm70, rocm71, rocm714, rocm72, rocm100) and ran the tests on mi300x (gfx942) with torch 2.10.0+rocm7.0, 2.12.1+rocm7.1 and 2.14.1+rocm7.2, 136 pass on each (4 skipped, they need two gpus). generic_nms keeps the same boxes as torchvision.ops.nms on rocm at 1k, 5k and 20k boxes and is within 4% of its speed

note: this lands in v2, sam3 video still loads version=1 so transformers needs to bump that before it picks up the rocm build. no version bump here since this only adds a backend

*keeping as draft until ci support rocm

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Nov 10, 2026
@github-actions

Copy link
Copy Markdown

This PR changes source code for the following kernel(s): cv-utils.

If you have the kernel-bot build permissions, then trigger /kernel-bot build cv-utils yourself. Otherwise, a maintainer will review the PR and will take an appropriate action. Thanks for your patience.

@drbh
drbh marked this pull request as draft November 10, 2026 19:08
@drbh

drbh commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

waiting on #1328 to run build

drbh added 2 commits November 13, 2026 12:49
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
@drbh

drbh commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build cv-utils

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build cv-utils
Mode: build only
Target branch: pr-1320
PR head SHA: dcbcff67148be450245975eb1ab1a3588b7cd9a1
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant