Repository navigation
Conversation
|
This PR changes source code for the following kernel(s): If you have the kernel-bot build permissions, then trigger |
drbh
marked this pull request as draft
November 10, 2026 19:08
drbh
marked this pull request as ready for review
November 12, 2026 15:10
Collaborator
Author
|
waiting on #1328 to run build |
drbh
marked this pull request as draft
November 12, 2026 19:09
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Collaborator
Author
|
/kernel-bot build causal-conv1d |
drbh
force-pushed
the
causal-conv1d-rocm
branch
from
November 13, 2026 17:46
a980c03 to
8f818fb
Compare
|
Build request processed. Command: Dispatched (1):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds a rocm build for
causal-conv1dbuild.toml: add therocmbackend,rocm = "2.10"stable abi and acpp-rocmkernel with the same sources (samerocm-archsasactivation)causal_conv1d.cppincludes the hip runtime and aliasescudaStream_tunderUSE_ROCMsince kernel-builder only hipifies the.cufilestorch_binding.cppalso registers the ops forROCM_KERNEL. without it the kernel loads but every op raisesNotImplementedErrorthe kernels already have the upstream
USE_ROCMpaths so no kernel source changes were neededbuilt all rocm variants (
rocm70,rocm71,rocm714,rocm72,rocm100) withnix build .#backendBundle.rocmand ran the tests on mi300x (gfx942) against the bundle with torch2.10.0+rocm7.0,2.12.1+rocm7.1and2.14.1+rocm7.2same result on all three. the skips are the existing
Only channel_last support initial_statesskip.kernels benchmarkshows 2.81x / 3.00x / 4.50x over the torch reference for base / large / xlargenote: #1308 makes the same
causal_conv1d.cppchange in the mamba-ssm copy and #1300 touches the same files, so one of these will need a rebase. transformers also needsrocmentries forcausal_conv1d_fnandcausal_conv1d_updateinhub_kernels.pybefore it picks this up*keeping as draft until ci support rocm