Repository navigation
feat: run rocm kernel tests on the amd mi300 runners - #1313
Merged
Merged
Conversation
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Collaborator
Author
|
pending support for the runner from the infra team - once added I'll move the pr out of draft |
drbh
marked this pull request as ready for review
November 10, 2026 15:43
This was referenced Nov 10, 2026
danieldk
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds a
test-kernel-rocmjob that runs thekernels_citests on the amd mi300 runners used by the transformers amd ci https://github.com/huggingface/transformers/blob/main/.github/workflows/self-comment-ci-amd.ymlits split out like the stable abi jobs so it cant block the cuda tests.
.github/scripts/rocm_ci.pypicks the rocm variant and skips kernels that dont targetgfx942note:
build.yamlneeds access to thehfc-amd-mi300-1gpurunner group before this can run8 tests pass in
.github/scripts/test_rocm_ci.py