Repository navigation
fix: restore nix-installer cache as root on rocm container runners - #1328
Merged
Merged
Conversation
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
drbh
changed the title
drbh
force-pushed
the
fix-rocm-nix-tar-owner
branch
from
November 12, 2026 16:35
81b3658 to
ccde2ac
Compare
This was referenced Nov 12, 2026
Member
Then does it mean we should run it on |
danieldk
approved these changes
Nov 13, 2026
Collaborator
Author
nope shouldn't be a blocker - just a note so if the ci fails on rocm test its likely because the kernel needs to be bumped so it get the change that fixes the rocm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr fixes the nix install in
test-kernel-rocmhttps://github.com/huggingface/kernels-community/actions/runs/43093355445/job/130795729876tldr; the action restores its cached
nix-installerowned by uid 1001 with mode0110, so its executable check fails as root in the container.TAR_OPTIONS: --no-same-ownerrestores it as root and keeps the cachenote: kernels need
python3 scripts/update_flakes.py <kernel>to pick up huggingface/kernels#996 before their rocm tests passverified on the mi300 with activation bumped to kernels main,
torch215-rocm714loads and passes https://github.com/huggingface/kernels-community/actions/runs/43285735858