Repository navigation
chore: pin SDK version and go.mod for Dapr 1.19.0-rc.2 - #844
Conversation
Pin RUNTIME_VERSION in validate_examples.yaml to 1.19.0-rc.1, as the 1.18 cycle pinned its release candidates (dapr#824, dapr#823) before GA (dapr#831). Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
The example jobs print the scheduler logs once, right after dapr init and before any example runs. When an example fails, the job log has no placement or scheduler output from the time of the failure. Add a last step that runs only on failure and prints the logs of the dapr_placement and dapr_scheduler containers. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
Sets the SDK version to v1.16.0-rc.1 and pins go.mod (root and examples)
to the Dapr 1.19 release candidate line:
- github.com/dapr/dapr v1.18.0 -> v1.19.0-rc.1
- github.com/dapr/kit v0.18.1 -> v0.18.4
- github.com/dapr/durabletask-go v0.12.1 -> v0.14.2-0.20260930152504-a90f95c3898d
(the pseudo-version at a90f95c3, the commit dapr v1.19.0-rc.1's own go.mod
requires; v0.14.1 does not satisfy that requirement)
- go 1.26.4 -> 1.26.6
`go mod tidy` also moves go-chi/chi, go-spiffe, otel, golang.org/x/{net,sys,text},
google.golang.org/grpc and genproto/googleapis/rpc to the minimum versions the
new dapr/dapr requirement selects. No source change.
Once Dapr 1.19.0-rc.2 is tagged, the durabletask-go line needs a second pin to
that commit's own requirement (fe0e70b7, not yet tagged as of this PR).
Supersedes dapr#839, dapr#840 and dapr#841, whose changes are folded into this PR and the
two commits carried over from them:
- dapr#840 pinned `validate_examples.yaml` to runtime 1.19.0-rc.1 (carried as-is).
- dapr#841 added the placement/scheduler log dump on example failure (carried as-is).
- dapr#839 bumped durabletask-go to v0.14.1; this PR pins it to the runtime's own
requirement instead, which is lower in semver but is what rc.1 actually
pins, so v0.14.1 is not used.
Verified in a worktree off origin/main (e06de53):
- `go build ./...` and `go vet ./...` clean, root and examples modules.
- `go test ./... -count=1` (root module): all packages pass, including
`client` (TestEncrypt/context_canceled, the flake dapr#842 targets, did not
flake on this run).
Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 56.71% 56.71%
=======================================
Files 52 52
Lines 3784 3784
=======================================
Hits 2146 2146
Misses 1483 1483
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Update: this PR's own CI hit a live example of the class of flake #843 fixes, in the sibling example. `validate-example (actor-grpc)` failed on this PR's first run. The app got through `get user`, `get invoke`, `get post`, `get`, `start timer`, `stop timer`, `start reminder`, `stop reminder`, and the first `get user = {Name: Age:1}`, but the step's 60-second budget killed the process (`signal: killed`) before the expected final line, `get user = {Name: Age:2}`, appeared. Every other example in the run passed. #843 already documents this exact failure mode for the `actor` example, and its fix (`timeout_seconds: 120`) covers both `actor` and `actor-grpc`. This run just tipped the sibling example instead. It's the same root cause, not a new one, and not something this PR's dependency bumps change the mechanism of (the step budget includes the example's own build time either way). This doesn't change anything about this PR's own content, and reinforces task 1: #842 and #843 both need to land before any tag, since |
Pin github.com/dapr/dapr to v1.19.0-rc.2 and run the examples against runtime 1.19.0-rc.2. durabletask-go moves to the tag v0.15.0 and kit to f2a7561, the same versions that the runtime pins at rc.2. Kit v0.18.4 is on the release-0.18 line of kit and lacks changes that rc.2 ships. The rc.2 module requires Go 1.26.9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5 Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Summary
Prepares the go-sdk
v1.16.0-rc.1release for Dapr 1.19:version/sdk-version:v1.16.0-rc.1go.modandexamples/go.mod:github.com/dapr/dapr v1.19.0-rc.2,github.com/dapr/durabletask-go v0.15.0, andgithub.life-white.uk/dapr/kitatf2a7561. These are the versions the runtime pins at rc.2. Thegodirective is 1.26.9, as rc.2 requires.validate_examples.yaml: runs the examples against runtime 1.19.0-rc.2, and prints the placement and scheduler logs when an example fails.Supersedes #839, #840 and #841.
Kit stays at
f2a7561, notv0.18.4.v0.18.4is on therelease-0.18line of kit, and it lacks changes that the 1.19 runtime ships. dapr/dapr#10693 has the list.Tests
go build ./...,go vet ./...and the examples build pass.go test ./...passes in every package exceptclient, whereTestEncrypt/context_canceledfails at times. That is the known flake that test(client): make the Encrypt deadline subtest deterministic #842 fixes. It fails at the same rate onmain: 2 of 10 runs onmain, 1 of 10 on this branch.Merge order
Merge #842 and #843 first. The release workflow runs
make teston the tag, and these two fix the test and example flakes.🤖 Generated with Claude Code
https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5