Repository navigation
ci: give the actor example steps 120 seconds - #843
Merged
JoshVanL merged 2 commits intoOct 11, 2026
Merged
Conversation
Each actor example step has 60 seconds, and that budget includes the go run build of the example app. On the CI runners the server app starts 36 to 38 seconds after its sidecar, and the scenario then needs about 23 seconds. When the build takes more than about 37 seconds, mechanical-markdown stops the client before StopReminder returns, on any runtime version. Set both steps of the actor and actor-grpc examples to 120 seconds. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
JoshVanL
approved these changes
Oct 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
=======================================
Coverage 56.71% 56.71%
=======================================
Files 52 52
Lines 3784 3784
=======================================
Hits 2146 2146
Misses 1483 1483
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validate-example (actor)fails on some runs. It failed in #840 (runtime 1.19.0-rc.1, job) and in #841 (runtime 1.18.0, job), and it passed in #839 (runtime 1.18.0). In both failed runs, the client printedstart reminderbut notstop reminder.The cause is the 60-second step timeout, not the runtime. Each step runs
dapr run ... go run ./..., so the budget includes the build of the example app. These timings come from the sidecar logs and count from the start of theactor-servingsidecar:StopReminderdueAfter the server app is up, the client needs about 23 seconds. That is about 2 seconds for the placement dissemination, two 10-second waits for the timer and the reminder, and the two
IncrementAndGetcalls. When the build takes more than about 37 seconds, mechanical-markdown stops both steps at 60 seconds, beforeStopReminderreturns. The client sidecar then logs a placement lock for table version 2. That lock comes from the shutdown: in #841, the placement logs show both sidecar streams closing withcontext canceledat the same moment.actor-grpcruns the same scenario with the same 60-second steps.This PR sets
timeout_seconds: 120for both steps of theactorandactor-grpcexamples. Other examples already use longer steps:cryptouses 90 seconds, andworkflow-history-propagationuses 90 and 300 seconds. The example code and the expected output do not change.Issue reference
No issue.
Checklist
mm.py --dry-runof both READMEs parses all three steps.)🤖 Generated with Claude Code
https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5