Skip to content

ci: give the actor example steps 120 seconds - #843

Merged
JoshVanL merged 2 commits into
dapr:mainfrom
nelson-parente:ci/actor-examples-step-timeout
Oct 11, 2026
Merged

JoshVanL merged 2 commits into
dapr:mainfrom
nelson-parente:ci/actor-examples-step-timeout

Conversation

@nelson-parente

Copy link
Copy Markdown
Contributor

Description

validate-example (actor) fails on some runs. It failed in #840 (runtime 1.19.0-rc.1, job) and in #841 (runtime 1.18.0, job), and it passed in #839 (runtime 1.18.0). In both failed runs, the client printed start reminder but not stop reminder.

The cause is the 60-second step timeout, not the runtime. Each step runs dapr run ... go run ./..., so the budget includes the build of the example app. These timings come from the sidecar logs and count from the start of the actor-serving sidecar:

Run Server app up Timer created StopReminder due Result
#839 (1.18.0) 36.4 s 38.4 s 58.4 s pass
#841 (1.18.0) 37.8 s 39.8 s 59.8 s fail
#840 (1.19.0-rc.1) 37.9 s 39.9 s 59.9 s fail

After the server app is up, the client needs about 23 seconds. That is about 2 seconds for the placement dissemination, two 10-second waits for the timer and the reminder, and the two IncrementAndGet calls. When the build takes more than about 37 seconds, mechanical-markdown stops both steps at 60 seconds, before StopReminder returns. The client sidecar then logs a placement lock for table version 2. That lock comes from the shutdown: in #841, the placement logs show both sidecar streams closing with context canceled at the same moment.

actor-grpc runs the same scenario with the same 60-second steps.

This PR sets timeout_seconds: 120 for both steps of the actor and actor-grpc examples. Other examples already use longer steps: crypto uses 90 seconds, and workflow-history-propagation uses 90 and 300 seconds. The example code and the expected output do not change.

Issue reference

No issue.

Checklist

  • Code compiles correctly (step metadata only. A mm.py --dry-run of both READMEs parses all three steps.)
  • Created/updated tests (not applicable)
  • Extended the documentation (not applicable)

🤖 Generated with Claude Code

https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5

Each actor example step has 60 seconds, and that budget includes the
go run build of the example app. On the CI runners the server app
starts 36 to 38 seconds after its sidecar, and the scenario then needs
about 23 seconds. When the build takes more than about 37 seconds,
mechanical-markdown stops the client before StopReminder returns, on
any runtime version. Set both steps of the actor and actor-grpc
examples to 120 seconds.

Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.71%. Comparing base (fb58b83) to head (879e040).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   56.71%   56.71%           
=======================================
  Files          52       52           
  Lines        3784     3784           
=======================================
  Hits         2146     2146           
  Misses       1483     1483           
  Partials      155      155           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshVanL
JoshVanL merged commit 827dab4 into dapr:main Oct 11, 2026
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants