Repository navigation
ci: validate examples against Dapr runtime 1.19.0-rc.1 - #840
Closed
nelson-parente wants to merge 1 commit into
Closed
nelson-parente wants to merge 1 commit into
nelson-parente wants to merge 1 commit into
Conversation
Pin RUNTIME_VERSION in validate_examples.yaml to 1.19.0-rc.1, as the 1.18 cycle pinned its release candidates (dapr#824, dapr#823) before GA (dapr#831). Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 56.73% 56.73%
=======================================
Files 52 52
Lines 3784 3784
=======================================
Hits 2147 2147
Misses 1482 1482
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 4, 2026
Contributor
Author
|
Superseded by #844, which carries this change forward unchanged as its first commit, alongside the dapr/kit/durabletask-go/go version pins for 1.19.0-rc.1. |
JoshVanL
pushed a commit
that referenced
this pull request
Oct 11, 2026
Sets the SDK version to v1.16.0-rc.1 and pins go.mod (root and examples)
to the Dapr 1.19 release candidate line:
- github.com/dapr/dapr v1.18.0 -> v1.19.0-rc.1
- github.com/dapr/kit v0.18.1 -> v0.18.4
- github.com/dapr/durabletask-go v0.12.1 -> v0.14.2-0.20260930152504-a90f95c3898d
(the pseudo-version at a90f95c3, the commit dapr v1.19.0-rc.1's own go.mod
requires; v0.14.1 does not satisfy that requirement)
- go 1.26.4 -> 1.26.6
`go mod tidy` also moves go-chi/chi, go-spiffe, otel, golang.org/x/{net,sys,text},
google.golang.org/grpc and genproto/googleapis/rpc to the minimum versions the
new dapr/dapr requirement selects. No source change.
Once Dapr 1.19.0-rc.2 is tagged, the durabletask-go line needs a second pin to
that commit's own requirement (fe0e70b7, not yet tagged as of this PR).
Supersedes #839, #840 and #841, whose changes are folded into this PR and the
two commits carried over from them:
- #840 pinned `validate_examples.yaml` to runtime 1.19.0-rc.1 (carried as-is).
- #841 added the placement/scheduler log dump on example failure (carried as-is).
- #839 bumped durabletask-go to v0.14.1; this PR pins it to the runtime's own
requirement instead, which is lower in semver but is what rc.1 actually
pins, so v0.14.1 is not used.
Verified in a worktree off origin/main (e06de53):
- `go build ./...` and `go vet ./...` clean, root and examples modules.
- `go test ./... -count=1` (root module): all packages pass, including
`client` (TestEncrypt/context_canceled, the flake #842 targets, did not
flake on this run).
Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validate_examples.yamlpins the Dapr runtime that the examples run against. It still uses1.18.0, so the example validations do not test the 1.19 runtime.This PR sets
RUNTIME_VERSIONto1.19.0-rc.1. The 1.18 cycle took the same step for its release candidates (#824 for rc.3, #823 for rc.4) before the GA pin (#831). The TODO comment now refers to the 1.19 GA. The Dapr CLI version is not changed: the workflow still uses the latest CLI release, anddapr init --runtime-versioninstalls the RC runtime with it.The
validate-examplejobs on this PR run every example against1.19.0-rc.1.Issue reference
None.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5