Skip to content

ci: print placement and scheduler logs when an example fails - #841

Closed
nelson-parente wants to merge 1 commit into
dapr:mainfrom
nelson-parente:ci/print-placement-scheduler-logs-on-failure
Closed

nelson-parente wants to merge 1 commit into
dapr:mainfrom
nelson-parente:ci/print-placement-scheduler-logs-on-failure

Conversation

@nelson-parente

Copy link
Copy Markdown
Contributor

Description

The validate-example jobs print the scheduler logs once, right after dapr init and before any example runs. When an example fails, the job log has no placement or scheduler output from the time of the failure.

This PR adds a last step that runs only when the job fails. The step prints the logs of the dapr_placement and dapr_scheduler containers.

At the default info log level, placement writes one line for each sidecar stream that connects (Received status report connection from new namespace=... id=...) and one line for each stream that closes (Error receiving from stream ...: EOF). It also writes a warning when a dissemination round times out. These lines show what started a placement dissemination round and which sidecar did not respond.

Context: in #840 (example validation against runtime 1.19.0-rc.1), validate-example (actor) failed once. The StopReminder actor call did not return before the 70-second step limit, and the second reminder did not fire. The client sidecar logged a placement lock for table version 2 and no update or unlock after it. The server sidecar did not log that lock. The job log has no placement or scheduler output from that time, so the cause of that round is not known. validate-example (actor-grpc) passed in the same run, and local runs of the same example with the 1.19.0-rc.1 and 1.18.0 release binaries did not show the failure.

Issue reference

No issue. This is a CI diagnostics change.

Checklist

  • Code compiles correctly (workflow change only. actionlint v1.7.7 reports no findings.)
  • Created/updated tests (not applicable)
  • Extended the documentation (not applicable)

The step uses || true for each container, so it adds no second error when a container is not present.

🤖 Generated with Claude Code

https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5

The example jobs print the scheduler logs once, right after dapr init and
before any example runs. When an example fails, the job log has no
placement or scheduler output from the time of the failure.

Add a last step that runs only on failure and prints the logs of the
dapr_placement and dapr_scheduler containers.

Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.71%. Comparing base (c9af9fd) to head (cd213cf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   56.73%   56.71%   -0.03%     
==========================================
  Files          52       52              
  Lines        3784     3784              
==========================================
- Hits         2147     2146       -1     
- Misses       1482     1483       +1     
  Partials      155      155              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nelson-parente

Copy link
Copy Markdown
Contributor Author

Superseded by #844, which carries this change forward unchanged as its second commit, alongside the dapr/kit/durabletask-go/go version pins for 1.19.0-rc.1.

JoshVanL pushed a commit that referenced this pull request Oct 11, 2026
Sets the SDK version to v1.16.0-rc.1 and pins go.mod (root and examples)
to the Dapr 1.19 release candidate line:

- github.com/dapr/dapr v1.18.0 -> v1.19.0-rc.1
- github.com/dapr/kit v0.18.1 -> v0.18.4
- github.com/dapr/durabletask-go v0.12.1 -> v0.14.2-0.20260930152504-a90f95c3898d
  (the pseudo-version at a90f95c3, the commit dapr v1.19.0-rc.1's own go.mod
  requires; v0.14.1 does not satisfy that requirement)
- go 1.26.4 -> 1.26.6

`go mod tidy` also moves go-chi/chi, go-spiffe, otel, golang.org/x/{net,sys,text},
google.golang.org/grpc and genproto/googleapis/rpc to the minimum versions the
new dapr/dapr requirement selects. No source change.

Once Dapr 1.19.0-rc.2 is tagged, the durabletask-go line needs a second pin to
that commit's own requirement (fe0e70b7, not yet tagged as of this PR).

Supersedes #839, #840 and #841, whose changes are folded into this PR and the
two commits carried over from them:

- #840 pinned `validate_examples.yaml` to runtime 1.19.0-rc.1 (carried as-is).
- #841 added the placement/scheduler log dump on example failure (carried as-is).
- #839 bumped durabletask-go to v0.14.1; this PR pins it to the runtime's own
  requirement instead, which is lower in semver but is what rc.1 actually
  pins, so v0.14.1 is not used.

Verified in a worktree off origin/main (e06de53):
- `go build ./...` and `go vet ./...` clean, root and examples modules.
- `go test ./... -count=1` (root module): all packages pass, including
  `client` (TestEncrypt/context_canceled, the flake #842 targets, did not
  flake on this run).

Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant