Skip to content

feat: implement issue #293 — Compliance: sonar-s7637-exemption-missing - #295

Merged
don-petry merged 4 commits into
mainfrom
dev-lead/issue-293-20260626-1436
Jun 26, 2026
Merged

don-petry merged 4 commits into
mainfrom
dev-lead/issue-293-20260626-1436

Conversation

@don-petry

@don-petry don-petry commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

Closes #293

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated repository quality-check configuration to better handle known false positives in workflow files.
    • Added targeted quality-gate suppressions for specific first-party reusable workflow stubs, keeping broader workflow checks unaffected.

@don-petry
don-petry requested a review from a team as a code owner June 26, 2026 14:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 32a82a61-f2ae-456b-aa65-6d078acc9124

📥 Commits

Reviewing files that changed from the base of the PR and between 4d9a17e and 1288362.

📒 Files selected for processing (1)
  • sonar-project.properties

📝 Walkthrough

Walkthrough

Adjusts SonarCloud settings in sonar-project.properties to stop globally excluding workflow files and instead ignore githubactions:S7637 only for selected first-party reusable workflow stubs.

Changes

SonarCloud S7637 exemptions

Layer / File(s) Summary
Workflow exclusion update
sonar-project.properties
Removes the .github/workflows/** entry from sonar.exclusions while leaving the other exclusion patterns unchanged.
Workflow ignore criteria
sonar-project.properties
Adds sonar.issue.ignore.multicriteria entries that map githubactions:S7637 to specific workflow YAML globs, with comments limiting the exemption scope.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • donpetry-bot
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the issue and main change: adding the Sonar S7637 exemption.
Linked Issues check ✅ Passed The change adds the requested sonar.issue.ignore exemption for githubactions:S7637 on first-party reusable workflow stubs.
Out of Scope Changes check ✅ Passed The edits stay focused on Sonar workflow exemptions and do not ցույց any unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-293-20260626-1436

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds SonarCloud S7637 rule exemptions for several first-party reusable GitHub Actions workflow files in sonar-project.properties. However, there is a configuration conflict: the global sonar.exclusions already excludes .github/workflows/**, which makes these new workflow-specific exemptions redundant unless the global exclusion is removed.

Comment thread sonar-project.properties Resolved
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 26, 2026 14:40

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@sonar-project.properties`:
- Line 7: The SonarCloud exemption comment has an issue reference mismatch, so
update the inline reference in the reusable-ref caller stub exemption comment to
match the actual implemented issue number. Verify the reference in
sonar-project.properties and replace the copied template marker with the correct
PR/issue identifier used by this change, keeping the note aligned with the S7637
exemption and the first-party reusable-ref caller stubs context.
- Around line 5-16: The Sonar configuration currently excludes
.github/workflows/** in sonar.exclusions, which makes the S7637 multicriteria
ignores for those workflow files ineffective. Update sonar-project.properties by
either removing .github/workflows/** from sonar.exclusions so the workflow files
are analyzed and the existing s7637_* ignore entries can apply, or, if workflows
must stay excluded, remove the dead sonar.issue.ignore.multicriteria block tied
to those workflow stubs. Use sonar.exclusions and
sonar.issue.ignore.multicriteria as the key symbols to locate and adjust the
config.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 98410138-bf97-4cf3-9455-23dc3ea3ceaa

📥 Commits

Reviewing files that changed from the base of the PR and between 32cfc5b and 4d9a17e.

📒 Files selected for processing (1)
  • sonar-project.properties

Comment thread sonar-project.properties Resolved
Comment thread sonar-project.properties Resolved
@don-petry
don-petry disabled auto-merge June 26, 2026 14:42
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 26, 2026 14:43
@don-petry
don-petry disabled auto-merge June 26, 2026 14:44
@don-petry
don-petry enabled auto-merge (squash) June 26, 2026 14:45
@don-petry
don-petry disabled auto-merge June 26, 2026 16:27

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 08204689bdc8d03a94b42215b9310c9f56bb2b6d
Review mode: triage-approved (single reviewer)

Summary

Config-only change to sonar-project.properties (+42/-1): removes .github/workflows/** from sonar.exclusions and adds 10 narrowly-scoped githubactions:S7637 (SHA-pin) ignore entries for first-party reusable-ref caller stubs. Closes compliance issue #293. Aligned with org Action Pinning Policy exemption; SonarCloud Quality Gate passed with 0 new issues.

Linked issue analysis

Linked issue #293 (Compliance: sonar-s7637-exemption-missing) is substantively addressed — the PR adds the missing S7637 exemption block for the intended first-party reusable workflow stubs, and by un-excluding .github/workflows/** the exemptions now actually take effect.

Findings

Prior bot reviews (gemini-code-assist, CodeRabbit) reviewed the FIRST commit (4d9a17e) and flagged two issues — both resolved at HEAD (0820468):

  1. Config conflict: sonar.exclusions previously kept .github/workflows/** excluded, making the per-file S7637 ignores dead. RESOLVED — that glob is removed from sonar.exclusions, so workflows are now analyzed and the ignores apply.
  2. Issue-reference mismatch in the exemption comment. RESOLVED — comment correctly references #293.
    The 10 ignores are scoped per-file (e.g. **/agent-shield.yml, **/dev-lead.yml), not a blanket workflows/*.yml, so ci.yml/sonarcloud.yml and any third-party uses: keep full SHA-pin enforcement. SonarCloud Quality Gate passed with 0 new issues, confirming no new S7637 violations were introduced by un-excluding the workflow files. No secrets or security-sensitive content (properties config only); GitHub Secret Protection MCP tool not exposed in this run, so the gitleaks CI check (SUCCESS) stands as the secret gate.

CI status

Substantive gates green: CodeQL SUCCESS, SonarCloud SUCCESS (Quality Gate passed, 0 new issues), Secret scan (gitleaks) SUCCESS, AgentShield SUCCESS, CodeRabbit SUCCESS. The CANCELLED entries are dev-lead/review-agent orchestration jobs superseded by later pushes, not real failures. mergeStateStatus is BEHIND (needs rebase before merge) but mergeable=MERGEABLE.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: fix-reviews)

PR: #295
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-26T16:58:32Z

@don-petry
don-petry enabled auto-merge (squash) June 26, 2026 16:28
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 9025e95 into main Jun 26, 2026
19 of 22 checks passed
@don-petry
don-petry deleted the dev-lead/issue-293-20260626-1436 branch June 26, 2026 16:29
@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate
Root cause: Config error

This PR removes the blanket sonar.exclusions entry for .github/workflows/**, so SonarCloud now analyzes all workflow files. The replacement per-file S7637 suppressions cover 10 named stubs, but any workflow file not listed in sonar.issue.ignore.multicriteria (or triggering a rule other than S7637) will now produce new violations and can fail the quality gate.

Suggested fix: Check the SonarCloud dashboard for the specific file(s) and rule(s) now flagged, then either add the missing file to the sonar.issue.ignore.multicriteria list in sonar-project.properties or SHA-pin the offending action reference to satisfy S7637 directly.

View run logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: sonar-s7637-exemption-missing

2 participants