You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sonar-project.properties has no sonar.issue.ignore for githubactions:S7637. SonarCloud will flag first-party reusable-ref caller stubs (@<name>/stable, @v1/@v2) as unpinned actions even though the org exempts them from SHA-pinning. Add the canonical per-stub exemption.
Add the canonical per-stub githubactions:S7637 SonarCloud exemption block to sonar-project.properties, scoped to each first-party reusable-ref caller-stub workflow that exists in this repo (no blanket resourceKey).
Implementation Checklist
Append the canonical S7637 exemption block (comment + sonar.issue.ignore.multicriteria list + one ruleKey/resourceKey pair per stub) to sonar-project.properties, copied verbatim from petry-projects/.github
Confirm all 10 listed caller stubs exist in .github/workflows/ (agent-shield, pr-review-mention, pr-auto-review, auto-rebase, dependabot-rebase, dependabot-automerge, dependency-audit, feature-ideation, add-to-project, dev-lead) — all present, so full block applies
None — pure configuration change with no observable runtime behavior. Verification is by properties syntax validity and matching the canonical block per the standard. (Phase 2 TDD exemption: config-only change.)
Test Command
pnpm -r run test (repo test runner; no test covers this config file)
Appended the canonical githubactions:S7637 exemption block to sonar-project.properties, copied verbatim from petry-projects/.github
Confirmed all 10 listed first-party caller stubs exist in .github/workflows/ — so the full canonical block applies with no omissions and no blanket resourceKey
$ bash .dev-lead/scripts/dev-lead-lint.sh
[lint] shellcheck on 2 file(s)...
[lint] validating CODEOWNERS...
OK: CODEOWNERS
[lint] all checks passed
EXIT=0
Stub-existence check (every criterion maps to a real workflow file):
exists: agent-shield.yml, pr-review-mention.yml, pr-auto-review.yml, auto-rebase.yml,
dependabot-rebase.yml, dependabot-automerge.yml, dependency-audit.yml,
feature-ideation.yml, add-to-project.yml, dev-lead.yml
Repo JS/TS test suite (`pnpm -r run test`): pnpm not installed and no test
packages present yet — nothing to run. prettier `format:check` does not match
`.properties` files.
Files Changed
sonar-project.properties: added the per-stub S7637 SonarCloud exemption — explanatory comment, the sonar.issue.ignore.multicriteria list, and one ruleKey/resourceKey pair per first-party caller stub. Existing keys unchanged.
Notes
All 10 caller stubs named in the standard exist in this repo, so the canonical block was copied verbatim with no criteria omitted.
Each resourceKey is scoped to an individual stub file (**/<stub>.yml); no blanket workflow-path key is used, so ci.yml / sonarcloud.yml and any third-party uses: keep full SHA-pin enforcement (avoids the sonar-s7637-exemption-too-broad error).
feature-ideation.yml is currently SHA-pinned and pr-auto-review.yml uses @v2; the standard scopes the exemption by stub-file presence, and a non-firing criterion is harmless, so both are included per the canonical block.
Investigate the githubactions:S7637 exemption state and, if a gap exists, apply the canonical inline # NOSONAR(githubactions:S7637) marker (or legacy per-stub sonar-project.properties exemption) to every channel-pinned first-party caller stub.
No repo unit-test hooks cover CI workflow YAML; verification is the org compliance-audit condition itself (marker presence on every channel-pinned first-party stub). Repo lint: bash .dev-lead/scripts/dev-lead-lint.sh.
Dev-Lead: Implementation Complete — No Code Change Required (Already Remediated)
Finding
The repo already satisfies the githubactions:S7637 exemption via the canonical inline-marker mechanism (#549). Commit 71c3ba0 ("ci: inline NOSONAR(S7637) markers on first-party caller stubs (#549 canonical migration) (#359)") — which is the current HEAD of this branch — added the inline # NOSONAR(githubactions:S7637) marker to every channel-pinned first-party caller stub. This issue was filed by an audit run that predates that migration.
Verification Against the Org Audit
Per petry-projects/.githubscripts/compliance-audit.sh → check_sonar_s7637_exemption, a SonarCloud-gated repo is compliant when every channel-pinned first-party caller stub carries the inline marker (inline_seen=1 && inline_missing=0 → return 0). The standard (ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637) confirms the inline marker is canonical and requires zero per-repo sonar-project.properties entries.
All 10 channel-pinned first-party uses: lines carry the marker:
The 2 SHA-pinned first-party refs correctly carry no marker (a 40-char SHA already satisfies S7637):
feature-ideation.yml @c2beceb…816 # v1 (SHA-pinned — no marker needed)
ci-failure-analyst.yml @857bb18…4e # main (SHA-pinned — no marker needed)
Adding legacy sonar.issue.ignore entries to sonar-project.properties would be redundant and is explicitly "no longer required once the stubs carry the inline marker" per the standard, so no such entries were added.
Test Results
No repo unit-test hooks cover CI workflow YAML (behavior-preserving config; Phase-2 TDD exception applies). Verification is the org audit condition above. Required repo lint passed:
[lint] shellcheck on 2 file(s)...
[lint] validating CODEOWNERS...
OK: CODEOWNERS
[lint] all checks passed
Files Changed
None. Working tree is clean (git status empty); the exemption was already applied by 71c3ba0.
Notes
This is a stale compliance finding — already remediated by the #549 canonical migration before this issue was picked up. No PR content is produced because there is nothing to change. The next compliance-audit run will not re-file it.
Dev-Lead: issue #350 implementation failed — will retry
The engine failed (engine-error — e.g. a timeout or transient engine error). This was attempt 1 of 3; dev-lead will retry automatically. You can also re-apply the dev-lead label to retry now.
Dev-Lead: issue #350 implementation failed — will retry
The engine failed (engine-error — e.g. a timeout or transient engine error). This was attempt 2 of 3; dev-lead will retry automatically. You can also re-apply the dev-lead label to retry now.
Dev-Lead: Implementation Complete — No Changes Required (finding already remediated)
Summary
This sonar-s7637-exemption-missing finding is already resolved by the canonical inline-marker migration in commit 71c3ba0 (PR #359, "ci: inline NOSONAR(S7637) markers on first-party caller stubs — #549 canonical migration", merged 2026-06-30). No source changes are needed, and none were made.
Why no sonar-project.properties entry is added
Per ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637, the canonical mechanism is an inline # NOSONAR(githubactions:S7637) marker on each channel-pinned first-party uses: line. Once every stub carries it, zero per-repo sonar-project.properties entries are required. The legacy per-file properties exemption is explicitly "optional / transitional," and a blanket resourceKey is forbidden (it would file the sonar-s7637-exemption-too-broaderror by also dropping S7637 on ci.yml/sonarcloud.yml). Adding a properties exemption now would be redundant and against the standard.
Verification (audit logic replicated locally)
I replicated check_sonar_s7637_exemption / classify_inline_s7637_marker from petry-projects/.githubscripts/compliance-audit.sh against every workflow file. Every channel-pinned first-party caller stub carries the marker; the two SHA-pinned first-party refs correctly carry none:
OK (channel-pinned + marker): add-to-project.yml ref=add-to-project/stable
OK (channel-pinned + marker): agent-shield.yml ref=agent-shield/stable
OK (channel-pinned + marker): auto-rebase.yml ref=auto-rebase/stable
OK (channel-pinned + marker): dependabot-automerge.yml ref=dependabot-automerge/stable
OK (channel-pinned + marker): dependabot-rebase.yml ref=dependabot-rebase/stable
OK (channel-pinned + marker): dependency-audit.yml ref=dependency-audit/stable
OK (channel-pinned + marker): dev-lead.yml ref=dev-lead/stable
OK (channel-pinned + marker): pr-auto-review.yml ref=v2
OK (channel-pinned + marker): pr-review-mention.yml ref=pr-review-mention/stable
OK (channel-pinned + marker): pr-review.yml ref=pr-review/stable
inline_seen=1 inline_missing=0
VERDICT: COMPLIANT (canonical inline-marker mechanism satisfied)
SHA-pinned (no marker needed, correctly none): feature-ideation.yml@c2beceb…, ci-failure-analyst.yml@857bb18….
Given inline_seen=1 and inline_missing=0, check_sonar_s7637_exemption returns compliant (early return 0) and files no finding. The original audit run predated 71c3ba0 landing.
Lint
bash .dev-lead/scripts/dev-lead-lint.sh → all checks passed (exit 0).
Files Changed
None. The remediation is already present in .github/workflows/*.yml as of 71c3ba0.
Notes
No tests were added (Phase 2 exception: no source/behavior change — the finding is stale/already-remediated).
Recommend closing this issue as already-resolved. If the weekly audit re-fires against main, it should now classify the repo compliant; a persistent re-file would indicate an audit caching/scan-freshness issue rather than a repo gap.
Verify the githubactions:S7637 first-party reusable-ref exemption is present, and remediate only if a gap actually exists.
Investigation Findings (pre-implementation)
The canonical mechanism for this exemption (per standards/ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637) is an inline # NOSONAR(githubactions:S7637) marker on each channel-pinned first-party caller-stub uses: line — not a sonar-project.properties entry (which is the legacy/transitional mechanism, explicitly "no longer required once the stubs carry the inline marker").
All 10 channel-pinned first-party stubs in .github/workflows/ already carry the inline marker (added by PR ci: inline NOSONAR(S7637) markers on first-party caller stubs (#549 canonical migration) #359, merged 2026-06-30): add-to-project, agent-shield, auto-rebase, dependabot-automerge, dependabot-rebase, dependency-audit, dev-lead, pr-auto-review, pr-review, pr-review-mention.
The two SHA-pinned first-party refs (feature-ideation.yml @<sha> # v1, ci-failure-analyst.yml @<sha> # main) already satisfy S7637 and correctly carry no marker.
Ran the audit's own pure classifiers (classify_inline_s7637_marker, classify_sonar_s7637_exemption) from petry-projects/.githubscripts/compliance-audit.sh against the current local workflows. Result: inline_seen=1, inline_missing=0 → check_sonar_s7637_exemption returns 0 (compliant), no finding emitted.
Implementation Checklist
Confirm every channel-pinned first-party stub carries the inline marker
Confirm SHA-pinned/third-party refs correctly lack the marker
Run canonical classifier to reproduce audit verdict → COMPLIANT
No source changes required — adding legacy sonar-project.properties entries would be redundant and is discouraged by the standard
Tests to Write
None — behavior-preserving verification of an already-satisfied config exemption (Phase 2 documentation/config exception applies).
Dev-Lead: Implementation Complete — No Change Required (finding already remediated)
Conclusion
This finding is stale / already remediated. The repo is already compliant with the githubactions:S7637 first-party reusable-ref exemption via the canonical inline-marker mechanism. No source changes are needed, and none were made.
Why no sonar-project.properties edit
Per standards/ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637, the canonical exemption is an inline # NOSONAR(githubactions:S7637) marker on each channel-pinned first-party caller-stub uses: line. The sonar-project.propertiessonar.issue.ignore approach named in the finding is the legacy/transitional mechanism, which the standard states is "no longer required once the stubs carry the inline marker." Adding it now would be redundant, and a blanket resourceKey is explicitly forbidden.
The weekly audit that opened this issue ran before the markers existed.
Verification (audit's own classifier, run against current repo)
Extracted classify_inline_s7637_marker + classify_sonar_s7637_exemption from petry-projects/.githubscripts/compliance-audit.sh and ran them over .github/workflows/*:
All 10 channel-pinned first-party stubs carry the inline marker; the 2 SHA-pinned first-party refs correctly carry none. check_sonar_s7637_exemption short-circuits to return 0 on inline_seen=1 && inline_missing=0.
Repo lint
[lint] shellcheck on 2 file(s)...
[lint] validating CODEOWNERS...
OK: CODEOWNERS
[lint] all checks passed
Files Changed
None. git status is clean.
Notes
Phase 2 (TDD) skipped under the documented behavior-preserving/config exception — there is no behavioral change to test; verification instead reproduced the audit verdict directly.
Bring the first-party channel-pinned caller-stub workflows to byte-exact parity with their canonical standards/workflows/ templates, so the canonical inline # NOSONAR(githubactions:S7637) exemption travels with each stub verbatim. No sonar-project.properties change is made — the standard states the inline marker is the canonical mechanism requiring zero properties entries, and forbids a broad resourceKey (which would trigger sonar-s7637-exemption-too-broad).
Commit 71c3ba0 already added the markers, but the stubs drifted from the templates (missing trailing newlines; dev-lead.yml missing the S7637 header-comment block; dependency-audit.yml stale header anchor). Remediation = copy templates verbatim.
SHA-pinned first-party refs (feature-ideation.yml@<sha> # v1, ci-failure-analyst.yml@<sha> # main) correctly carry no marker and are out of scope. pr-review.yml (.github-private) has no template and already carries the marker; left untouched.
Implementation Checklist (re-sync verbatim from standards/workflows/)
.github/workflows/add-to-project.yml
.github/workflows/agent-shield.yml
.github/workflows/auto-rebase.yml
.github/workflows/dependabot-automerge.yml
.github/workflows/dependabot-rebase.yml
.github/workflows/dependency-audit.yml
.github/workflows/dev-lead.yml
.github/workflows/pr-auto-review.yml
.github/workflows/pr-review-mention.yml
Tests to Write
None. This is a CI-config / documentation change with no observable runtime behavior and no in-repo YAML-compliance test harness (Phase 2 exception). Verification is byte-exact diff against canonical templates + dev-lead-lint.sh + YAML parse.
Test Command
bash .dev-lead/scripts/dev-lead-lint.sh plus a byte-exact diff of each stub against its canonical template.
Identified the canonical exemption mechanism: an inline # NOSONAR(githubactions:S7637) marker on each channel-pinned first-party caller stub (NOT a sonar-project.properties entry)
Re-synced all 9 channel-pinned first-party caller stubs verbatim from standards/workflows/ so the marker travels byte-exact with each stub
Verified byte-exact parity with canonical templates, S7637 markers present, YAML validity, and required lint
Why no sonar-project.properties change
The finding's "Detail" reflects the legacy mechanism. Per the standard, the inline marker is the canonical exemption and requires zerosonar-project.properties entries; a repo is compliant when every channel-pinned stub carries the marker. Commit 71c3ba0 had already added the markers but the stubs had drifted from the templates (missing trailing newlines; dev-lead.yml missing the S7637 header-comment block; dependency-audit.yml stale doc anchor). The issue's remediation — "copy the template verbatim" — is exactly this re-sync. Adding a legacy properties entry would be redundant, and a blanket resourceKey would trigger the worse sonar-s7637-exemption-too-broad error, so none was added.
Out of scope (correctly unchanged): SHA-pinned first-party refs feature-ideation.yml (@<sha> # v1) and ci-failure-analyst.yml (@<sha> # main) need no marker; pr-review.yml (.github-private, no template) already carries the marker.
Test Results
No unit tests apply. Per the Phase 2 exception, this is a CI-config / documentation re-sync with no observable runtime behavior; the repo has no in-repo YAML-compliance test harness, and .github/workflows/** is excluded from Sonar sources and imported by zero packages/tests (so the JS/TS pnpm -r run test suite cannot exercise it; node_modules is not installed in this environment). Authoritative verification instead:
Required lint — bash .dev-lead/scripts/dev-lead-lint.sh:
[lint] shellcheck on 2 file(s)...
[lint] validating CODEOWNERS...
OK: CODEOWNERS
[lint] all checks passed (exit 0)
Byte-exact parity vs canonical standards/workflows/ templates:
MATCH: add-to-project.yml MATCH: dependency-audit.yml
MATCH: agent-shield.yml MATCH: dev-lead.yml
MATCH: auto-rebase.yml MATCH: pr-auto-review.yml
MATCH: dependabot-automerge.yml MATCH: pr-review-mention.yml
MATCH: dependabot-rebase.yml
YAML parse: OK for all 9 stubs
S7637 marker present on every channel-pinned first-party stub (10 files incl. pr-review.yml)
Activity
don-petry commentedon Jun 26, 2026
Dev-Lead Implementation Plan
Issue: #350 — Compliance: sonar-s7637-exemption-missing
Scope
Add the canonical per-stub
githubactions:S7637SonarCloud exemption block tosonar-project.properties, scoped to each first-party reusable-ref caller-stub workflow that exists in this repo (no blanketresourceKey).Implementation Checklist
sonar.issue.ignore.multicriterialist + one ruleKey/resourceKey pair per stub) tosonar-project.properties, copied verbatim frompetry-projects/.github.github/workflows/(agent-shield, pr-review-mention, pr-auto-review, auto-rebase, dependabot-rebase, dependabot-automerge, dependency-audit, feature-ideation, add-to-project, dev-lead) — all present, so full block appliessonar-project.propertieskeys (projectName, sources, exclusions)Tests to Write
propertiessyntax validity and matching the canonical block per the standard. (Phase 2 TDD exemption: config-only change.)Test Command
pnpm -r run test(repo test runner; no test covers this config file)don-petry commentedon Jun 26, 2026
Dev-Lead: Implementation Complete
Plan Execution
githubactions:S7637exemption block tosonar-project.properties, copied verbatim frompetry-projects/.github.github/workflows/— so the full canonical block applies with no omissions and no blanketresourceKeysonar-project.propertieskeys (projectKey, organization, projectName, sources, exclusions)Test Results
Config-only change — no automated tests cover
sonar-project.properties(Phase 2 TDD exemption applies). Verification performed:Files Changed
sonar-project.properties: added the per-stub S7637 SonarCloud exemption — explanatory comment, thesonar.issue.ignore.multicriterialist, and oneruleKey/resourceKeypair per first-party caller stub. Existing keys unchanged.Notes
resourceKeyis scoped to an individual stub file (**/<stub>.yml); no blanket workflow-path key is used, soci.yml/sonarcloud.ymland any third-partyuses:keep full SHA-pin enforcement (avoids thesonar-s7637-exemption-too-broaderror).feature-ideation.ymlis currently SHA-pinned andpr-auto-review.ymluses@v2; the standard scopes the exemption by stub-file presence, and a non-firing criterion is harmless, so both are included per the canonical block.don-petry commentedon Jul 2, 2026
Dev-Lead Implementation Plan
Issue: #350 — Compliance: sonar-s7637-exemption-missing
Scope
Investigate the
githubactions:S7637exemption state and, if a gap exists, apply the canonical inline# NOSONAR(githubactions:S7637)marker (or legacy per-stubsonar-project.propertiesexemption) to every channel-pinned first-party caller stub.Investigation Checklist
ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637scripts/compliance-audit.sh→check_sonar_s7637_exemptionto determine the exact compliance conditionuses: petry-projects/.github(-private)/…caller stub in.github/workflows/@<name>/stable,@v1/@v2) vs SHA-pinned# NOSONAR(githubactions:S7637)markerRemediation (only if a gap is found)
# NOSONAR(githubactions:S7637)marker to any channel-pinned first-partyuses:line missing it (canonical mechanism, per [Fleet Monitor] petry-projects/broodly — .github/workflows/dependency-audit.yml #549)Tests
No repo unit-test hooks cover CI workflow YAML; verification is the org compliance-audit condition itself (marker presence on every channel-pinned first-party stub). Repo lint:
bash .dev-lead/scripts/dev-lead-lint.sh.don-petry commentedon Jul 2, 2026
Dev-Lead: Implementation Complete — No Code Change Required (Already Remediated)
Finding
The repo already satisfies the
githubactions:S7637exemption via the canonical inline-marker mechanism (#549). Commit71c3ba0("ci: inline NOSONAR(S7637) markers on first-party caller stubs (#549 canonical migration) (#359)") — which is the currentHEADof this branch — added the inline# NOSONAR(githubactions:S7637)marker to every channel-pinned first-party caller stub. This issue was filed by an audit run that predates that migration.Verification Against the Org Audit
Per
petry-projects/.githubscripts/compliance-audit.sh→check_sonar_s7637_exemption, a SonarCloud-gated repo is compliant when every channel-pinned first-party caller stub carries the inline marker (inline_seen=1 && inline_missing=0 → return 0). The standard (ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637) confirms the inline marker is canonical and requires zero per-reposonar-project.propertiesentries.All 10 channel-pinned first-party
uses:lines carry the marker:The 2 SHA-pinned first-party refs correctly carry no marker (a 40-char SHA already satisfies S7637):
Adding legacy
sonar.issue.ignoreentries tosonar-project.propertieswould be redundant and is explicitly "no longer required once the stubs carry the inline marker" per the standard, so no such entries were added.Test Results
No repo unit-test hooks cover CI workflow YAML (behavior-preserving config; Phase-2 TDD exception applies). Verification is the org audit condition above. Required repo lint passed:
Files Changed
git statusempty); the exemption was already applied by71c3ba0.Notes
This is a stale compliance finding — already remediated by the #549 canonical migration before this issue was picked up. No PR content is produced because there is nothing to change. The next compliance-audit run will not re-file it.
don-petry commentedon Jul 2, 2026
Dev-Lead: issue #350 implementation failed — will retry
The engine failed (
engine-error— e.g. a timeout or transient engine error). This was attempt 1 of 3; dev-lead will retry automatically. You can also re-apply thedev-leadlabel to retry now.engine-errorLast 40 lines of engine output (redacted)
don-petry commentedon Jul 2, 2026
Dev-Lead: issue #350 implementation failed — will retry
The engine failed (
engine-error— e.g. a timeout or transient engine error). This was attempt 2 of 3; dev-lead will retry automatically. You can also re-apply thedev-leadlabel to retry now.engine-errorLast 40 lines of engine output (redacted)
don-petry commentedon Jul 2, 2026
Dev-Lead: Implementation Complete — No Changes Required (finding already remediated)
Summary
This
sonar-s7637-exemption-missingfinding is already resolved by the canonical inline-marker migration in commit71c3ba0(PR #359, "ci: inline NOSONAR(S7637) markers on first-party caller stubs — #549 canonical migration", merged 2026-06-30). No source changes are needed, and none were made.Why no
sonar-project.propertiesentry is addedPer
ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637, the canonical mechanism is an inline# NOSONAR(githubactions:S7637)marker on each channel-pinned first-partyuses:line. Once every stub carries it, zero per-reposonar-project.propertiesentries are required. The legacy per-file properties exemption is explicitly "optional / transitional," and a blanketresourceKeyis forbidden (it would file thesonar-s7637-exemption-too-broaderror by also dropping S7637 onci.yml/sonarcloud.yml). Adding a properties exemption now would be redundant and against the standard.Verification (audit logic replicated locally)
I replicated
check_sonar_s7637_exemption/classify_inline_s7637_markerfrompetry-projects/.githubscripts/compliance-audit.shagainst every workflow file. Every channel-pinned first-party caller stub carries the marker; the two SHA-pinned first-party refs correctly carry none:SHA-pinned (no marker needed, correctly none):
feature-ideation.yml@c2beceb…,ci-failure-analyst.yml@857bb18….Given
inline_seen=1andinline_missing=0,check_sonar_s7637_exemptionreturns compliant (earlyreturn 0) and files no finding. The original audit run predated71c3ba0landing.Lint
bash .dev-lead/scripts/dev-lead-lint.sh→ all checks passed (exit 0).Files Changed
.github/workflows/*.ymlas of71c3ba0.Notes
main, it should now classify the repo compliant; a persistent re-file would indicate an audit caching/scan-freshness issue rather than a repo gap.don-petry commentedon Jul 2, 2026
Dev-Lead Implementation Plan
Issue: #350 — Compliance: sonar-s7637-exemption-missing
Scope
Verify the
githubactions:S7637first-party reusable-ref exemption is present, and remediate only if a gap actually exists.Investigation Findings (pre-implementation)
standards/ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637) is an inline# NOSONAR(githubactions:S7637)marker on each channel-pinned first-party caller-stubuses:line — not asonar-project.propertiesentry (which is the legacy/transitional mechanism, explicitly "no longer required once the stubs carry the inline marker")..github/workflows/already carry the inline marker (added by PR ci: inline NOSONAR(S7637) markers on first-party caller stubs (#549 canonical migration) #359, merged 2026-06-30):add-to-project,agent-shield,auto-rebase,dependabot-automerge,dependabot-rebase,dependency-audit,dev-lead,pr-auto-review,pr-review,pr-review-mention.feature-ideation.yml @<sha> # v1,ci-failure-analyst.yml @<sha> # main) already satisfy S7637 and correctly carry no marker.Verification Method
Ran the audit's own pure classifiers (
classify_inline_s7637_marker,classify_sonar_s7637_exemption) frompetry-projects/.githubscripts/compliance-audit.shagainst the current local workflows. Result:inline_seen=1, inline_missing=0→check_sonar_s7637_exemptionreturns0(compliant), no finding emitted.Implementation Checklist
sonar-project.propertiesentries would be redundant and is discouraged by the standardTests to Write
Test Command
bash .dev-lead/scripts/dev-lead-lint.shdon-petry commentedon Jul 2, 2026
Dev-Lead: Implementation Complete — No Change Required (finding already remediated)
Conclusion
This finding is stale / already remediated. The repo is already compliant with the
githubactions:S7637first-party reusable-ref exemption via the canonical inline-marker mechanism. No source changes are needed, and none were made.Why no
sonar-project.propertieseditPer
standards/ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637, the canonical exemption is an inline# NOSONAR(githubactions:S7637)marker on each channel-pinned first-party caller-stubuses:line. Thesonar-project.propertiessonar.issue.ignoreapproach named in the finding is the legacy/transitional mechanism, which the standard states is "no longer required once the stubs carry the inline marker." Adding it now would be redundant, and a blanketresourceKeyis explicitly forbidden.Timeline
ci: inline NOSONAR(S7637) markers on first-party caller stubs) merged: 2026-06-30 — 4 days laterVerification (audit's own classifier, run against current repo)
Extracted
classify_inline_s7637_marker+classify_sonar_s7637_exemptionfrompetry-projects/.githubscripts/compliance-audit.shand ran them over.github/workflows/*:All 10 channel-pinned first-party stubs carry the inline marker; the 2 SHA-pinned first-party refs correctly carry none.
check_sonar_s7637_exemptionshort-circuits toreturn 0oninline_seen=1 && inline_missing=0.Repo lint
Files Changed
git statusis clean.Notes
don-petry commentedon Jul 2, 2026
Dev-Lead Implementation Plan
Issue: #350 — Compliance: sonar-s7637-exemption-missing
Scope
Bring the first-party channel-pinned caller-stub workflows to byte-exact parity with their canonical
standards/workflows/templates, so the canonical inline# NOSONAR(githubactions:S7637)exemption travels with each stub verbatim. Nosonar-project.propertieschange is made — the standard states the inline marker is the canonical mechanism requiring zero properties entries, and forbids a broadresourceKey(which would triggersonar-s7637-exemption-too-broad).Findings from investigation
71c3ba0already added the markers, but the stubs drifted from the templates (missing trailing newlines;dev-lead.ymlmissing the S7637 header-comment block;dependency-audit.ymlstale header anchor). Remediation = copy templates verbatim.feature-ideation.yml@<sha> # v1,ci-failure-analyst.yml@<sha> # main) correctly carry no marker and are out of scope.pr-review.yml(.github-private) has no template and already carries the marker; left untouched.Implementation Checklist (re-sync verbatim from standards/workflows/)
.github/workflows/add-to-project.yml.github/workflows/agent-shield.yml.github/workflows/auto-rebase.yml.github/workflows/dependabot-automerge.yml.github/workflows/dependabot-rebase.yml.github/workflows/dependency-audit.yml.github/workflows/dev-lead.yml.github/workflows/pr-auto-review.yml.github/workflows/pr-review-mention.ymlTests to Write
dev-lead-lint.sh+ YAML parse.Test Command
bash .dev-lead/scripts/dev-lead-lint.shplus a byte-exact diff of each stub against its canonical template.don-petry commentedon Jul 2, 2026
Dev-Lead: Implementation Complete
Plan Execution
# NOSONAR(githubactions:S7637)marker on each channel-pinned first-party caller stub (NOT asonar-project.propertiesentry)standards/workflows/so the marker travels byte-exact with each stubWhy no
sonar-project.propertieschangeThe finding's "Detail" reflects the legacy mechanism. Per the standard, the inline marker is the canonical exemption and requires zero
sonar-project.propertiesentries; a repo is compliant when every channel-pinned stub carries the marker. Commit71c3ba0had already added the markers but the stubs had drifted from the templates (missing trailing newlines;dev-lead.ymlmissing the S7637 header-comment block;dependency-audit.ymlstale doc anchor). The issue's remediation — "copy the template verbatim" — is exactly this re-sync. Adding a legacy properties entry would be redundant, and a blanketresourceKeywould trigger the worsesonar-s7637-exemption-too-broaderror, so none was added.Out of scope (correctly unchanged): SHA-pinned first-party refs
feature-ideation.yml(@<sha> # v1) andci-failure-analyst.yml(@<sha> # main) need no marker;pr-review.yml(.github-private, no template) already carries the marker.Test Results
No unit tests apply. Per the Phase 2 exception, this is a CI-config / documentation re-sync with no observable runtime behavior; the repo has no in-repo YAML-compliance test harness, and
.github/workflows/**is excluded from Sonar sources and imported by zero packages/tests (so the JS/TSpnpm -r run testsuite cannot exercise it;node_modulesis not installed in this environment). Authoritative verification instead:Files Changed
.github/workflows/add-to-project.yml,agent-shield.yml,auto-rebase.yml,dependabot-automerge.yml,dependabot-rebase.yml,pr-auto-review.yml,pr-review-mention.yml: re-synced verbatim (added canonical trailing newline;uses:line + S7637 marker already matched byte-for-byte).github/workflows/dependency-audit.yml: re-synced verbatim (fixed stale doc-anchor comment#5-…auditym→#7-…audityml; trailing newline).github/workflows/dev-lead.yml: re-synced verbatim (restored the S7637 explanatory header-comment block documenting the marker; corrected twoci-standards.md→../ci-standards.mdcomment refs; trailing newline)Notes
sonar-project.propertiesintentionally not modified (see rationale above).pr-review.ymlintentionally left untouched.don-petry commentedon Jul 3, 2026
Resolved! This check is now passing as of 2026-07-03. Closing automatically.