Repository navigation
feat: implement issue #218 — Compliance: non-stub-dependency-audit.yml - #279
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesDependency Audit Workflow Compliance Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-19T16:58:59Z. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: d277a0d4a768acbaad6918a6d49ba4b9a60df812
Cascade: triage → deep (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5)
Summary
Single-line CI change adopting the org-canonical thin-caller stub: reusable-workflow ref moves from a drifted local SHA pin (@376a4fcb… '# v2') to the org-standard floating tag @v1. Verified against the source of truth at petry-projects/.github/standards/workflows/dependency-audit.yml, which pins @v1 verbatim; this directly remediates compliance issue #218. The triage 'SHA→tag downgrade' and 'v2→v1' signals are intentional and standard-mandated for this first-party reusable workflow, not a security regression.
Findings
- INFO: Ref changed from immutable SHA pin '@376a4fcb1117444595e3e702fa450873d0e54310 # v2' to floating tag '@v1'. This is the deliberate org centralization standard for FIRST-PARTY reusable workflows (petry-projects/.github), letting the org push fixes to all consumers without per-repo PRs. Confirmed the canonical stub at petry-projects/.github/standards/workflows/dependency-audit.yml uses '@v1' verbatim. Caller permissions are minimal (contents: read), bounding blast radius even if the tag were repointed. Not a vulnerability in this trust context.
- INFO: MCP run_secret_scanning was not executed — permission to call the tool was not granted in this environment. Per procedure this is non-blocking. The diff is a single workflow 'uses:' line with no secret material.
- INFO: All gates pass: CodeQL (actions) SUCCESS, AgentShield SUCCESS, gitleaks SUCCESS, SonarCloud Quality Gate passed (0 new issues/hotspots), and 'dependency-audit / Detect ecosystems' SUCCESS — confirming the @v1 reusable workflow resolves and runs. SKIPPED checks are non-applicable ecosystems/dependabot. Advisory bots (Codex/Gemini/CodeRabbit) were rate-limited or unsupported and raised no findings.
Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5). Reply if you need a human review.
|
|
CI checks on this PR are still running. Once they complete, re-mention Posted by the donpetry-bot PR-review cascade. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
1 similar comment
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: c65ba824371272e5b9605e670c5a4fdd328f5a57
Review mode: triage-approved (single reviewer)
Summary
Single-line CI compliance fix: the dependency-audit thin-caller stub's reusable-workflow ref changes from a drifted local SHA pin (@376a4fcb… '# v2') to the org-canonical floating tag @v1. This is exactly the remediation required by linked issue #218 (non-stub-dependency-audit.yml), and matches the source-of-truth stub at petry-projects/.github/standards/workflows/dependency-audit.yml verbatim. The SHA→tag and v2→v1 signals are intentional and org-standard-mandated for this FIRST-PARTY reusable workflow, not a security regression. Triage assessment confirmed.
Linked issue analysis
Closes #218 (CLOSED). The issue mandates pinning dependency-audit.yml to '@v1' per the org centralization standard. The diff makes precisely that change and the resulting file is byte-for-byte the canonical stub (header banner, on: triggers, 'permissions: contents: read', job name, and 'uses: …@v1'). Issue substantively addressed.
Findings
- INFO: Ref moved from immutable SHA pin '@376a4fcb1117444595e3e702fa450873d0e54310 # v2' to floating tag '@v1'. For FIRST-PARTY org reusable workflows (petry-projects/.github) this is the deliberate centralization standard, letting the org push fixes to all consumers without per-repo PRs. The issue body and the canonical stub both specify '@v1' verbatim. Caller permissions are minimal ('contents: read'), bounding blast radius. Not a vulnerability in this trust context.
- INFO: MCP run_secret_scanning was not executed — calling the tool was not permitted in this environment. Per procedure this is non-blocking; the diff is a single workflow 'uses:' line with no secret material. The CI gitleaks check passed independently.
- INFO: Triage-approved confirmation — re-verified the triage assessment against the diff, linked issue, and canonical source of truth. Nothing missed.
CI status
All applicable checks green: CodeQL Analyze (actions) SUCCESS, AgentShield SUCCESS, Secret scan (gitleaks) SUCCESS, SonarCloud Quality Gate passed (0 new issues/hotspots), 'dependency-audit / Detect ecosystems' SUCCESS (confirms the @v1 reusable resolves and runs), and CI 'Detect ecosystems' SUCCESS. SKIPPED checks are non-applicable ecosystems/dependabot. Advisory bots (Codex/Gemini) were rate-limited or unsupported; CodeRabbit and SonarCloud raised no actionable findings.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
1 similar comment
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: c65ba824371272e5b9605e670c5a4fdd328f5a57
Cascade: triage → deep (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5)
Summary
Single-line CI compliance fix in markets' dependency-audit.yml thin-caller stub: the reusable-workflow ref moves from a locally-drifted SHA pin labeled '# v2' to the floating tag '@v1'. I independently verified the org canonical source of truth at petry-projects/.github/standards/workflows/dependency-audit.yml, which pins '@v1' verbatim, so this aligns the stub to the standard and resolves issue #218. The triage 'v2->v1 downgrade' and 'SHA->tag' signals are resolved: '@v1' is the canonical org version, and AGENTS.md's mutable-ref exception explicitly sanctions floating tags on FIRST-PARTY reusable workflows (not an unpinned-action smell). Caller permissions are minimal (contents: read), all gates are green, and there is no secret material.
Findings
- INFO: Ref changed from SHA pin '@376a4fcb1117444595e3e702fa450873d0e54310 # v2' to floating tag '@v1'. Verified against canonical petry-projects/.github/standards/workflows/dependency-audit.yml which uses '@v1' verbatim; the prior '# v2' SHA was local drift, so this is alignment to the standard, not a downgrade. Triage v2->v1 signal resolved.
- INFO: SHA pin -> floating tag is acceptable here: AGENTS.md ('mutable-ref exception') states the SHA-pin standard targets THIRD-PARTY actions, while floating/channel tags on FIRST-PARTY org-owned reusable workflows are the sanctioned version-selection mechanism and must not be flagged as unpinned. Blast radius bounded by 'permissions: contents: read'.
- INFO: MCP run_secret_scanning was not executed (tool permission not granted in this environment). Non-blocking per procedure; the diff is a single workflow 'uses:' line with no secret material, and CI 'Secret scan (gitleaks)' passed independently.
- INFO: All applicable checks green: CodeQL Analyze (actions) SUCCESS, AgentShield SUCCESS, gitleaks SUCCESS, SonarCloud Quality Gate passed (0 new issues/hotspots), 'dependency-audit / Detect ecosystems' SUCCESS (confirms @v1 reusable resolves and runs). SKIPPED checks are non-applicable ecosystems/dependabot. Advisory bots (Codex/Gemini) were rate-limited or unsupported; CodeRabbit raised no actionable findings.
- INFO: Closes #218 (Compliance: non-stub-dependency-audit.yml). The change makes the stub byte-aligned with the canonical source of truth, which is exactly the required remediation. Issue substantively addressed.
Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5). Reply if you need a human review.
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
2 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
CI checks on this PR are still running. Once they complete, re-mention Posted by the donpetry-bot PR-review cascade. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
5 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
28 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |



Closes #218
Implemented by dev-lead agent. Please review.
Summary by CodeRabbit