Skip to content

Compliance: non-stub-dependency-audit.yml #325

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: error
Check: non-stub-dependency-audit.yml

Detail

Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on May 26, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #325 — Compliance: non-stub-dependency-audit.yml

    Scope

    Update .github/workflows/dependency-audit.yml to pin the reusable workflow reference to @v1 (org standard) instead of the current @v2, replacing the file with the canonical stub verbatim.

    Implementation Checklist

    • Change .github/workflows/dependency-audit.yml line 33: @v2 → @v1 to match the canonical stub at petry-projects/.github/standards/workflows/dependency-audit.yml

    Tests to Write

    • N/A — Pure CI configuration change with no observable behavioral change in application code (TDD Phase 2 exception applies). No Jest tests are relevant to workflow YAML files.

    Test Command

    npm run check && npm test

  2. don-petry commented on May 26, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Changed .github/workflows/dependency-audit.yml line 33: @v2 → @v1 to match the canonical stub at petry-projects/.github/standards/workflows/dependency-audit.yml
    • TDD Phase 2 exception noted — pure CI YAML configuration change, no application behavior, no Jest tests applicable
    • Full test suite verified passing (301 tests, 12 suites)

    Test Results

    > google-app-scripts@0.0.0 test
    > jest --runInBand
    
    Test Suites: 12 passed, 12 total
    Tests:       301 passed, 301 total
    Snapshots:   0 total
    Time:        4.199 s
    Ran all test suites.
    

    Files Changed

    • .github/workflows/dependency-audit.yml: Changed reusable workflow ref from @v2 to @v1 to match the org canonical stub (one-line diff)

    Notes

    • A pre-existing prettier formatting issue exists in .github/workflows/ci-failure-analyst.yml (unrelated to this fix; that file was not modified). It was already flagged by npm run check before this change.
    • The dependency-audit.yml file was already structured as a thin caller stub; only the version pin was incorrect (@v2 vs. @v1 required by the standard).
  3. don-petry commented on May 29, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-29)

    This finding is still open.

    Detail: Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  4. don-petry commented on May 30, 2026

    @don-petry
    CollaboratorAuthor
    Already working on this: an open PR exists for issue #325.
  5. don-petry commented on May 30, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-30)

    This finding is still open.

    Detail: Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  6. don-petry commented on May 30, 2026

    @don-petry
    CollaboratorAuthor

    @don-petry-dev-lead

  7. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 3, 2026
  8. don-petry commented on Jun 5, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-06-05)

    This finding is still open.

    Detail: Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  9. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 6, 2026
  10. don-petry commented on Jun 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-06-12)

    This finding is still open.

    Detail: Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  11. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 12, 2026
  12. don-petry commented on Jun 19, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-06-19)

    This finding is still open.

    Detail: Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  13. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 19, 2026
  14. don-petry commented on Jun 26, 2026

    @don-petry
    CollaboratorAuthor

    Resolved! This check is now passing as of 2026-06-26. Closing automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions