You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sonar-project.properties has no sonar.issue.ignore for githubactions:S7637. SonarCloud will flag first-party reusable-ref caller stubs (@<name>/stable, @v1/@v2) as unpinned actions even though the org exempts them from SHA-pinning. Add the canonical per-stub exemption.
Add the canonical per-stub githubactions:S7637sonar.issue.ignore exemption to the root sonar-project.properties, scoped to the first-party reusable-ref caller stubs this repo actually carries.
Caller stubs present in this repo (8 of the 10 canonical)
agent-shield.yml, pr-review-mention.yml, auto-rebase.yml, dependabot-automerge.yml, dependency-audit.yml, feature-ideation.yml, add-to-project.yml, dev-lead.yml — each confirmed to carry a petry-projects/.github(-private) reusable uses: ref pinned to a moving channel/tag. (pr-auto-review.yml and dependabot-rebase.yml are absent and are omitted, per the standard.)
Implementation Checklist
tests/test_sonar_s7637_exemption.sh — new regression test (TDD, written first)
sonar-project.properties — add canonical sonar.issue.ignore.multicriteria block (verbatim from the org .github repo, omitting absent stubs)
.github/workflows/test.yml — register the new test step
Tests to Write
Assert an S7637 exemption exists (githubactions:S7637)
Assert each present caller stub has its own per-file criterion with resourceKey=**/<stub>.yml
Assert no forbidden blanket resourceKey (e.g. **/.github/workflows/*.yml, *.yml, **) is used
Assert no criterion is declared for an absent/non-stub file
Test Command
bash tests/test_sonar_s7637_exemption.sh (full suite: the test.yml steps + bash .dev-lead/scripts/dev-lead-lint.sh)
Added the canonical per-stub githubactions:S7637sonar.issue.ignore exemption to root sonar-project.properties, scoped to the 8 first-party reusable-ref caller stubs this repo carries
Wrote tests/test_sonar_s7637_exemption.sh (TDD: red before implementation) and registered it in .github/workflows/test.yml
Verified test catches all three violation classes (blanket resourceKey, missing present-stub exemption, stale exemption for an absent stub)
Full test suite + dev-lead-lint.sh (shellcheck + agent-profile validation) all green
Stub selection
Canonical standard lists 10 caller stubs. This repo carries 8 of them — exempted: agent-shield.yml, pr-review-mention.yml, auto-rebase.yml, dependabot-automerge.yml, dependency-audit.yml, feature-ideation.yml, add-to-project.yml, dev-lead.yml. Omitted (not present, per standard): pr-auto-review.yml, dependabot-rebase.yml. Each present stub was confirmed to carry a petry-projects/.github(-private) reusable uses: ref on a moving channel tag. No blanket resourceKey is used, so ci.yml/sonarcloud.yml and third-party actions keep full SHA-pin enforcement.
tests/test_sonar_s7637_exemption.sh: new regression guard asserting the exemption exists, is per-file scoped, uses no blanket resourceKey, and has no stale/non-canonical entries
.github/workflows/test.yml: registered the new test step
Notes
.dev-lead/sonar-project.properties is an untracked agent-runtime scaffold (not in git) and is not the file SonarCloud reads — intentionally left untouched.
Activity
don-petry commentedon Jun 26, 2026
Dev-Lead Implementation Plan
Issue: #943 — Compliance: sonar-s7637-exemption-missing
Scope
Add the canonical per-stub
githubactions:S7637sonar.issue.ignoreexemption to the rootsonar-project.properties, scoped to the first-party reusable-ref caller stubs this repo actually carries.Caller stubs present in this repo (8 of the 10 canonical)
agent-shield.yml,pr-review-mention.yml,auto-rebase.yml,dependabot-automerge.yml,dependency-audit.yml,feature-ideation.yml,add-to-project.yml,dev-lead.yml— each confirmed to carry apetry-projects/.github(-private)reusableuses:ref pinned to a moving channel/tag. (pr-auto-review.ymlanddependabot-rebase.ymlare absent and are omitted, per the standard.)Implementation Checklist
tests/test_sonar_s7637_exemption.sh— new regression test (TDD, written first)sonar-project.properties— add canonicalsonar.issue.ignore.multicriteriablock (verbatim from the org.githubrepo, omitting absent stubs).github/workflows/test.yml— register the new test stepTests to Write
githubactions:S7637)resourceKey=**/<stub>.ymlresourceKey(e.g.**/.github/workflows/*.yml,*.yml,**) is usedTest Command
bash tests/test_sonar_s7637_exemption.sh(full suite: thetest.ymlsteps +bash .dev-lead/scripts/dev-lead-lint.sh)don-petry commentedon Jun 26, 2026
Dev-Lead: Implementation Complete
Plan Execution
githubactions:S7637sonar.issue.ignoreexemption to rootsonar-project.properties, scoped to the 8 first-party reusable-ref caller stubs this repo carriestests/test_sonar_s7637_exemption.sh(TDD: red before implementation) and registered it in.github/workflows/test.ymldev-lead-lint.sh(shellcheck + agent-profile validation) all greenStub selection
Canonical standard lists 10 caller stubs. This repo carries 8 of them — exempted:
agent-shield.yml,pr-review-mention.yml,auto-rebase.yml,dependabot-automerge.yml,dependency-audit.yml,feature-ideation.yml,add-to-project.yml,dev-lead.yml. Omitted (not present, per standard):pr-auto-review.yml,dependabot-rebase.yml. Each present stub was confirmed to carry apetry-projects/.github(-private)reusableuses:ref on a moving channel tag. No blanketresourceKeyis used, soci.yml/sonarcloud.ymland third-party actions keep full SHA-pin enforcement.Test Results
Files Changed
sonar-project.properties: added canonicalsonar.issue.ignore.multicriteriaS7637 block (one per-file criterion per present caller stub)tests/test_sonar_s7637_exemption.sh: new regression guard asserting the exemption exists, is per-file scoped, uses no blanket resourceKey, and has no stale/non-canonical entries.github/workflows/test.yml: registered the new test stepNotes
.dev-lead/sonar-project.propertiesis an untracked agent-runtime scaffold (not in git) and is not the file SonarCloud reads — intentionally left untouched.feat: implement issue #943 — Compliance: sonar-s7637-exemption-missing (