Skip to content

add JobDelete / JobDeleteTx APIs to Client - #390

Merged
bgentry merged 3 commits into
masterfrom
bg-job-delete
Jun 12, 2024
Merged

add JobDelete / JobDeleteTx APIs to Client#390
bgentry merged 3 commits into
masterfrom
bg-job-delete

Conversation

@bgentry

@bgentry bgentry commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

This adds new APIs to permanently delete a job from the job table, so long as it is not currently running.

@bgentry
bgentry requested a review from brandur June 11, 2024 22:30
@bgentry
bgentry force-pushed the bg-job-delete branch 2 times, most recently from 4b0a79a to e86010d Compare June 11, 2024 22:36
@bgentry bgentry mentioned this pull request Jun 11, 2024
Merged
brandur
brandur reviewed Jun 12, 2024
View reviewed changes
Comment thread riverdriver/riverpgxv5/river_pgx_v5_driver.go Outdated
brandur
brandur reviewed Jun 12, 2024
View reviewed changes
Comment thread client.go Outdated
@bgentry
bgentry requested a review from brandur June 12, 2024 04:01
@bgentry
add JobDelete / JobDeleteTx APIs to Client
350947d 
This adds new APIs to permanently delete a job from the job table, so
long as it is not currently running.
@bgentry
fix another flaky insertNotifyLimiter test
9207bea 
Just as in #391, the insert notify limiter uses the FetchCooldown
setting for its own debounce interval. This defaults to 100ms, which is
short enough to occasionally fail in GitHub Actions when testing two
trigger attempts back to back.
@bgentry

bgentry commented Jun 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Also fixed another flaky test with the same cause as #391.

brandur
brandur approved these changes Jun 12, 2024
View reviewed changes

@brandur brandur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Comment thread rivertype/river_type.go Outdated
@bgentry @brandur
Update ErrJobRunning text
52d6bff 
Co-authored-by: Brandur Leach <brandur@brandur.org>
@bgentry
bgentry merged commit 5592599 into master Jun 12, 2024
@bgentry
bgentry deleted the bg-job-delete branch June 12, 2024 14:52
@bgentry bgentry mentioned this pull request Jun 13, 2024
Merged
bgentry added a commit that referenced this pull request Jun 13, 2024
@bgentry
Prepare version 0.7.0
e36d135 
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
bgentry added a commit that referenced this pull request Jun 14, 2024
@bgentry
Prepare version 0.7.0 (#394)
c1aa4ee 
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandur brandur brandur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgentry @brandur