add ability to delete jobs - #22
Merged
Merged
Conversation
brandur
approved these changes
Jun 12, 2024
| return | ||
| } | ||
|
|
||
| writeResponse(ctx, rw, []byte("{\"status\": \"ok\", \"num_deleted\": "+strconv.Itoa(numDeleted)+"}")) |
Collaborator
There was a problem hiding this comment.
OOC, is making your own JSON like this an optimization? IMO probably not worth the trade off of maybe accidentally returning invalid JSON. The JSON encoder is definitely slower than Rust's, but it's heavily optimized and pretty darn fast.
Contributor
Author
There was a problem hiding this comment.
Nah, I just only had static payloads up until this one and didn't bother to change it here. Definitely down with switching it to proper serialization!
bgentry
force-pushed
the
bg-job-delete
branch
2 times, most recently
from
June 13, 2024 15:36
6ea1597 to
fae956b
Compare
Fixes #19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
Depends on riverqueue/river#390 being merged and released (in order to avoid needing a
replacein thego.mod).