Skip to content

customizable MaxAttempts default value - #383

Merged
bgentry merged 1 commit into
masterfrom
bg-client-level-max-attempts-default
Jun 5, 2024
Merged

customizable MaxAttempts default value#383
bgentry merged 1 commit into
masterfrom
bg-client-level-max-attempts-default

Conversation

@bgentry

@bgentry bgentry commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

This adds a MaxAttempts setting to Config to enable the default max attempts to be customized (instead of the global default MaxAttemptsDefault of 25).

Fixes #381.

@bgentry bgentry added the enhancement New feature or request label Jun 4, 2024
@bgentry
bgentry requested a review from brandur June 4, 2024 18:18
This adds a `MaxAttempts` setting to `Config` to enable the default max
attempts to be customized (instead of the global default
`MaxAttemptsDefault` of 25).

Fixes #381.
@bgentry
bgentry force-pushed the bg-client-level-max-attempts-default branch from 882cc5b to dcc0360 Compare June 4, 2024 18:22

@brandur brandur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wicked, LGTM.

@bgentry
bgentry merged commit edb42d2 into master Jun 5, 2024
@bgentry
bgentry deleted the bg-client-level-max-attempts-default branch June 5, 2024 04:34
@bgentry bgentry mentioned this pull request Jun 13, 2024
bgentry added a commit that referenced this pull request Jun 13, 2024
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
bgentry added a commit that referenced this pull request Jun 14, 2024
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change default retry count

2 participants