Skip to content

Resync the Instruction Set with the Hub - #502

Merged
ptr727 merged 2 commits into
developfrom
resync/hub-45669468
Sep 26, 2026
Merged

ptr727 merged 2 commits into
developfrom
resync/hub-45669468

Conversation

@ptr727

@ptr727 ptr727 commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Resyncs the carried instruction set with the hub at 45669468.

  • AGENTS.md and GOVERNANCE.md: the stale verbatim sections re-vendored with carry.py apply-sections, which touches only declared verbatim regions and asserts the local preamble and sections came through byte-identical.
  • CODESTYLE.md, WORKFLOW.md, AUDIT.md: the hub's changes since the last sync three-way merged in. CODESTYLE.md keeps its OPERATIONS.md "Local Verification" references and the Utilities .NET conventions. WORKFLOW.md now matches the hub, which already carries the D1.6 wording from Remove Version Literals From WORKFLOW.md's D1.6 Item #500.
  • .github/workflows/publish-release.yml: the resynced D5.2 gates the post-push artifact delete on the download's outcome, so the download step gains id: download and the delete step the matching if:. A failed push no longer leaves the consumed artifact to the retention backstop.

The skill names these docs now route to (fleet-code-review, branching-and-release-model, and others) land with #501, so the two merge together.

Also applied during this resync, outside any PR: repo-config/configure.sh apply created the 11 hub-declared labels this repository was missing, and check now reports the configuration matches.

Audit run 2026-09-26T02:21:08Z | hub 45669468 | branch override develop. Local strict review took two rounds: round 1 raised the D5.2 gap fixed here, and round 2 found nothing. Markdownlint and actionlint pass.

🤖 Generated with Claude Code

ptr727 and others added 2 commits September 25, 2026 19:23
Re-vendor the stale AGENTS.md and GOVERNANCE.md verbatim sections with
carry.py apply-sections, and merge the hub's changes since the last sync
into CODESTYLE.md, WORKFLOW.md and AUDIT.md, keeping the repository's
own adaptations.

Audit run 2026-09-26T02:21:08Z | hub 45669468 | branch override develop

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The resynced WORKFLOW.md D5.2 requires the post-push delete to run on
the download's outcome rather than the push's, so a failed push no
longer leaves the consumed artifact to the retention backstop.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 26, 2026 02:28
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9dde3ea8-670e-447f-ba27-48377278bc44


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.54%. Comparing base (237fe8d) to head (d57d4e9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #502   +/-   ##
========================================
  Coverage    70.54%   70.54%           
========================================
  Files           13       13           
  Lines         1219     1219           
  Branches       111      111           
========================================
  Hits           860      860           
  Misses         319      319           
  Partials        40       40           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The NuGet artifact cleanup step is still likely to be skipped on the push-failure path unless the if: condition includes always().

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

This PR resyncs Utilities’ carried instruction set (AGENTS/GOVERNANCE/CODESTYLE/WORKFLOW/AUDIT) with the upstream hub contract and updates the NuGet publish workflow to align artifact-cleanup behavior with the updated workflow contract.

Changes:

  • Re-vendored/merged updates to the instruction-set Markdown files (AGENTS.md, GOVERNANCE.md, CODESTYLE.md, WORKFLOW.md, AUDIT.md) to match current hub wording and routing.
  • Updated WORKFLOW.md’s workflow contract language (notably applicability/N/A rules, cleanup gating rationale, and audit methodology details) to the newer hub model.
  • Adjusted .github/workflows/publish-release.yml to add a download step id and gate artifact deletion on the download step outcome.

Issues to address before approval:

  • In .github/workflows/publish-release.yml, the artifact-delete step should include always() in its if: so it still runs after a failed NuGet push (otherwise the failure path this PR is targeting can still skip cleanup).
  • The workflow comment on .github/workflows/publish-release.yml:75 references an upstream issue as ptr727/ProjectTemplate#1126; this conflicts with the updated governance rule permitting issue/PR references in code/workflow comments only as a URL citation.
File Description
WORKFLOW.md Resynced CI/CD contract text and clarified guarantees/audit methodology language.
GOVERNANCE.md Resynced governance wording and updated references/skill routing, including new “References” constraints.
CODESTYLE.md Resynced style guidance and expanded Markdown-ignore and coverage-related guidance references.
AUDIT.md Resynced audit procedure wording and expanded/clarified mechanized checks and example scripts.
AGENTS.md Resynced agent workflow guidance, especially around audit/report ownership and handoff procedure.
.github/​workflows/​publish-release.yml Added download step id and gated build-artifact deletion based on download outcome.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/publish-release.yml
@ptr727
ptr727 merged commit 125d48f into develop Sep 26, 2026
15 checks passed
ptr727 added a commit that referenced this pull request Sep 26, 2026
Promotes `develop` to `main`, bringing the carried governance content in
line with the hub at `45669468`. Replaces #503, which went unmergeable
once #504 removed a package line that `main` had bumped on its own.

This branch is `main` with `develop` merged in, the one
`Directory.Packages.props` conflict resolved to `develop`'s removal, and
its tree is byte-identical to `develop`'s.

- #466 re-vendors the carried skills tree and the stale verbatim rule
sections.
- #500 removes the version literals from `WORKFLOW.md`'s D1.6 item.
- #501 re-vendors `.github/skills` (adding `fleet-code-review`,
`branching-and-release-model` and the handoff skills, pruning the
renamed ones), points `.github/copilot-instructions.md` at
`fleet-code-review`, and updates the markdownlint and
editorconfig-checker configs.
- #502 re-vendors the stale `AGENTS.md` and `GOVERNANCE.md` sections,
merges the hub's `CODESTYLE.md`, `WORKFLOW.md` and `AUDIT.md` changes,
and gates the NuGet artifact delete in `publish-release.yml` on the
download per D5.2.
- #504 drops the `xunit.runner.visualstudio` VSTest adapter, which the
carried dotnet-codestyle rules exclude for an MTP-based test project.
- The remaining commits are Dependabot bumps.

No library code changes, and a human merge to `main` does not
auto-publish, so no release is implied.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@ptr727
ptr727 deleted the resync/hub-45669468 branch September 26, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants