Remove Version Literals From WORKFLOW.md's D1.6 Item - #500
Merged
Merged
Conversation
D1.6's coverage bullet carried a stale, hand-edited copy of the hub's Codecov item with hard-coded MTP/xunit.v3/coverage-extension version numbers (4.0.0, 18.9.0, 18.1.0, 18.0.0), violating the fleet rule that AGENTS.md, GOVERNANCE.md, CODESTYLE.md, and WORKFLOW.md carry no version literal. AGENTS.md, GOVERNANCE.md, and CODESTYLE.md already had none. Replaced the bullet with the hub's current develop wording for D1.6 (read via the GitHub API), which points to CODESTYLE.md's .NET and Python sides for the runner declaration, package references, and version floors instead of restating the numbers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #500 +/- ##
========================================
Coverage 70.54% 70.54%
========================================
Files 13 13
Lines 1219 1219
Branches 111 111
========================================
Hits 860 860
Misses 319 319
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
D1.6 now claims the MTP runner/package version floors live in CODESTYLE.md, but in this repo the authoritative runner selection and package pins are in global.json/UtilitiesTests.csproj and Directory.Packages.props, respectively.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates the repository’s CI/CD contract documentation by replacing stale, version-literal guidance in WORKFLOW.md D1.6 with wording that points readers to the authoritative sources for version floors and test/coverage configuration.
Changes:
- Rewrites WORKFLOW.md D1.6 to remove specific minimum-version literals and instead reference where those constraints/configuration live.
- Updates the D1.6 narrative around Codecov, secrets handling, and coverage report handling for multi-project solutions.
| File | Description |
|---|---|
| WORKFLOW.md | Updates D1.6 wording to avoid embedding stale version floors and to reference authoritative sources. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptr727
added a commit
that referenced
this pull request
Sep 26, 2026
Resyncs the carried instruction set with the hub at `45669468`. - `AGENTS.md` and `GOVERNANCE.md`: the stale verbatim sections re-vendored with `carry.py apply-sections`, which touches only declared verbatim regions and asserts the local preamble and sections came through byte-identical. - `CODESTYLE.md`, `WORKFLOW.md`, `AUDIT.md`: the hub's changes since the last sync three-way merged in. `CODESTYLE.md` keeps its `OPERATIONS.md` "Local Verification" references and the Utilities .NET conventions. `WORKFLOW.md` now matches the hub, which already carries the D1.6 wording from #500. - `.github/workflows/publish-release.yml`: the resynced D5.2 gates the post-push artifact delete on the download's outcome, so the download step gains `id: download` and the delete step the matching `if:`. A failed push no longer leaves the consumed artifact to the retention backstop. The skill names these docs now route to (`fleet-code-review`, `branching-and-release-model`, and others) land with #501, so the two merge together. Also applied during this resync, outside any PR: `repo-config/configure.sh apply` created the 11 hub-declared labels this repository was missing, and `check` now reports the configuration matches. Audit run `2026-09-26T02:21:08Z | hub 45669468 | branch override develop`. Local strict review took two rounds: round 1 raised the D5.2 gap fixed here, and round 2 found nothing. Markdownlint and actionlint pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 26, 2026
ptr727
added a commit
that referenced
this pull request
Sep 26, 2026
Promotes `develop` to `main`, bringing the carried governance content in line with the hub at `45669468`. Replaces #503, which went unmergeable once #504 removed a package line that `main` had bumped on its own. This branch is `main` with `develop` merged in, the one `Directory.Packages.props` conflict resolved to `develop`'s removal, and its tree is byte-identical to `develop`'s. - #466 re-vendors the carried skills tree and the stale verbatim rule sections. - #500 removes the version literals from `WORKFLOW.md`'s D1.6 item. - #501 re-vendors `.github/skills` (adding `fleet-code-review`, `branching-and-release-model` and the handoff skills, pruning the renamed ones), points `.github/copilot-instructions.md` at `fleet-code-review`, and updates the markdownlint and editorconfig-checker configs. - #502 re-vendors the stale `AGENTS.md` and `GOVERNANCE.md` sections, merges the hub's `CODESTYLE.md`, `WORKFLOW.md` and `AUDIT.md` changes, and gates the NuGet artifact delete in `publish-release.yml` on the download per D5.2. - #504 drops the `xunit.runner.visualstudio` VSTest adapter, which the carried dotnet-codestyle rules exclude for an MTP-based test project. - The remaining commits are Dependabot bumps. No library code changes, and a human merge to `main` does not auto-publish, so no release is implied. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D1.6 carried stale MTP and xunit.v3 minimum versions. It is replaced with the hub's current D1.6 wording, which names where the floors live instead of the numbers.