Resync the Skills Tree and Lint Configs with the Hub - #501
Merged
Merged
Conversation
Re-vendor .github/skills with carry.py apply, which adds the new skills, refreshes the stale ones, and prunes code-review, operational-vs-release-workflow and fleet-conformance-check, which the hub renamed or retired. Point .github/copilot-instructions.md at fleet-code-review in the same change, and pick up the hub's .markdownlint-cli2.jsonc and .editorconfig-checker.json updates while keeping the local .artifacts exclusion. Audit run 2026-09-26T02:21:08Z | hub 45669468 | branch override develop Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #501 +/- ##
========================================
Coverage 70.54% 70.54%
========================================
Files 13 13
Lines 1219 1219
Branches 111 111
========================================
Hits 860 860
Misses 319 319
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added
the
comments
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It introduces a temporary but concrete inconsistency where .github/copilot-instructions.md references the renamed skills while AGENTS.md still points to the retired names/paths, which can break the documented entry points unless merged in lockstep with the companion resync.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Resyncs this repository’s manifest-owned .github/skills/ distribution and updates local lint configs to match the current hub versions, plus refreshes .github/copilot-instructions.md to point at the renamed fleet-code-review skill.
Changes:
- Re-vendors
.github/skills/from the hub, including renames/additions (e.g.,fleet-code-review,branching-and-release-model,check-this-repo) and new handoff-related skills. - Updates
.markdownlint-cli2.jsonc(adds MD024 siblings-only behavior, adds explicitglobs, and ignoresnode_modules). - Updates
.editorconfig-checker.jsonto exclude common Python cache/venv directories.
| File | Description |
|---|---|
| .markdownlint-cli2.jsonc | Adds MD024 config, defines Markdown globs, and ignores node_modules. |
| .editorconfig-checker.json | Excludes Python cache/venv directories (keeps .artifacts/ excluded). |
| .github/copilot-instructions.md | Updates review bootstrap to fleet-code-review and refreshes runbook wording. |
| .github/skills/fleet-code-review/SKILL.md | Renames/reframes the core review skill as fleet-code-review. |
| .github/skills/workflow-ci-contract/SKILL.md | Resynced workflow CI contract wording and added actionlint/schema details. |
| .github/skills/workflow-ci-contract/references/d-guarantees.md | Resynced D-guarantees contract text. |
| .github/skills/workflow-ci-contract/references/architecture.md | Resynced architecture/seam contract reference text. |
| .github/skills/branching-and-release-model/SKILL.md | Renames/reframes branching/release policy skill. |
| .github/skills/branching-and-release-model/references/release-publish-mechanics.md | Points release/publish mechanics reference to WORKFLOW.md/CI contract sources. |
| .github/skills/branching-and-release-model/references/branch-protection-and-promotion.md | Resynced promotion/branch-protection guidance wording. |
| .github/skills/check-this-repo/SKILL.md | Renames/reframes in-repo conformance check skill. |
| .github/skills/resync-a-repo/SKILL.md | Updates resync procedure wording (audit invocation, branching notes, co-firing skills). |
| .github/skills/standup-a-repo/SKILL.md | Updates references from retired/renamed skills to current names. |
| .github/skills/skill-lifecycle/SKILL.md | Updates dist/include semantics and install reporting wording. |
| .github/skills/repo-worktree/SKILL.md | Tightens wording and quoting in git worktree examples/flow. |
| .github/skills/pr-review-conduct/SKILL.md | Resyncs PR review-loop rules (coverage carry semantics, refusal handling). |
| .github/skills/local-strict-review/SKILL.md | Resyncs strict-review skill and updates canonical sweep terminology. |
| .github/skills/merge-and-release/SKILL.md | Resyncs merge/release guidance and references renamed branching skill. |
| .github/skills/drive-pr/SKILL.md | Resyncs drive-loop guidance and references renamed branching skill. |
| .github/skills/backlog-burndown/SKILL.md | Adds handoff/blocked-label ranking semantics and references renamed branching skill. |
| .github/skills/session-handoff/SKILL.md | Adds/refreshes session handoff chain skill content. |
| .github/skills/unattended-handoff/SKILL.md | Adds new unattended handoff loop skill content. |
| .github/skills/audit-a-repo/SKILL.md | Updates triangle reference to check-this-repo. |
| .github/skills/agent-conduct/SKILL.md | Expands conduct triggers (questions/prompts, cross-repo blockers, sweep model). |
| .github/skills/carried-instruction-file-guard/SKILL.md | Expands scope/clarifies when it fires and how it composes with other skills. |
| .github/skills/copilot-instructions-keeper/SKILL.md | Updates wording and clarifies audit vs content drift responsibilities. |
| .github/skills/comment-and-doc-style/SKILL.md | Adds guidance around markdownlint config placement and “comment-added” gate mechanics. |
| .github/skills/comment-and-doc-style/references/carried-doc-references.md | Expands carried-doc reference bans to include version/SHA literals in certain docs. |
| .github/skills/python-codestyle/references/profiles.md | Removes a now-stale bullet about markdownlint rule customization. |
| .github/skills/upstream-contribution-workflow/SKILL.md | Updates reference to renamed branching model skill. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptr727
added a commit
that referenced
this pull request
Sep 26, 2026
Resyncs the carried instruction set with the hub at `45669468`. - `AGENTS.md` and `GOVERNANCE.md`: the stale verbatim sections re-vendored with `carry.py apply-sections`, which touches only declared verbatim regions and asserts the local preamble and sections came through byte-identical. - `CODESTYLE.md`, `WORKFLOW.md`, `AUDIT.md`: the hub's changes since the last sync three-way merged in. `CODESTYLE.md` keeps its `OPERATIONS.md` "Local Verification" references and the Utilities .NET conventions. `WORKFLOW.md` now matches the hub, which already carries the D1.6 wording from #500. - `.github/workflows/publish-release.yml`: the resynced D5.2 gates the post-push artifact delete on the download's outcome, so the download step gains `id: download` and the delete step the matching `if:`. A failed push no longer leaves the consumed artifact to the retention backstop. The skill names these docs now route to (`fleet-code-review`, `branching-and-release-model`, and others) land with #501, so the two merge together. Also applied during this resync, outside any PR: `repo-config/configure.sh apply` created the 11 hub-declared labels this repository was missing, and `check` now reports the configuration matches. Audit run `2026-09-26T02:21:08Z | hub 45669468 | branch override develop`. Local strict review took two rounds: round 1 raised the D5.2 gap fixed here, and round 2 found nothing. Markdownlint and actionlint pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 26, 2026
ptr727
added a commit
that referenced
this pull request
Sep 26, 2026
Removes `xunit.runner.visualstudio` from `UtilitiesTests.csproj` and `Directory.Packages.props`. The test project runs `xunit.v3` on native Microsoft.Testing.Platform (`global.json` runner declaration plus `UseMicrosoftTestingPlatformRunner`), and the dotnet-codestyle testing reference carried by #501 requires an MTP-based project to carry no VSTest adapter, since MTP replaces it. Raised by Copilot on the promotion PR #503. `dotnet build` reports 0 warnings, and `dotnet test --coverage --coverage-output-format cobertura --results-directory ./coverage` passes 212 of 212 tests and writes the Cobertura report. CI's validate task runs that same MTP invocation, and nothing in the tree references the adapter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Sep 26, 2026
Promotes `develop` to `main`, bringing the carried governance content in line with the hub at `45669468`. Replaces #503, which went unmergeable once #504 removed a package line that `main` had bumped on its own. This branch is `main` with `develop` merged in, the one `Directory.Packages.props` conflict resolved to `develop`'s removal, and its tree is byte-identical to `develop`'s. - #466 re-vendors the carried skills tree and the stale verbatim rule sections. - #500 removes the version literals from `WORKFLOW.md`'s D1.6 item. - #501 re-vendors `.github/skills` (adding `fleet-code-review`, `branching-and-release-model` and the handoff skills, pruning the renamed ones), points `.github/copilot-instructions.md` at `fleet-code-review`, and updates the markdownlint and editorconfig-checker configs. - #502 re-vendors the stale `AGENTS.md` and `GOVERNANCE.md` sections, merges the hub's `CODESTYLE.md`, `WORKFLOW.md` and `AUDIT.md` changes, and gates the NuGet artifact delete in `publish-release.yml` on the download per D5.2. - #504 drops the `xunit.runner.visualstudio` VSTest adapter, which the carried dotnet-codestyle rules exclude for an MTP-based test project. - The remaining commits are Dependabot bumps. No library code changes, and a human merge to `main` does not auto-publish, so no release is implied. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyncs the manifest-owned
.github/skillstree and two lint configs with the hub at45669468..github/skillsre-vendored withcarry.py apply: addsbacklog-burndown,branching-and-release-model,check-this-repo,fleet-code-review,session-handoff,unattended-handoff, refreshes the stale skills, and prunescode-review,operational-vs-release-workflowandfleet-conformance-check, which the hub renamed or retired. The tree now matches the hub byte for byte..github/copilot-instructions.mdpoints atfleet-code-reviewin the same change and picks up the hub's rewording, with the local Disproved Claims ledger kept..markdownlint-cli2.jsoncre-vendored..editorconfig-checker.jsongains the hub's Python-cache exclusions and keeps the local.artifacts/exclusion.The companion instruction-set resync PR updates
AGENTS.mdandGOVERNANCE.mdto the new skill names.Audit run
2026-09-26T02:21:08Z | hub 45669468 | branch override develop. Local strict review found nothing, and markdownlint and editorconfig-checker pass on the tree.🤖 Generated with Claude Code